From: Hannes Reinecke <hare@suse•de>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
James Bottomley <James.Bottomley@HansenPartnership•com>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Robert Elliott <elliott@hp•com>, Christoph Hellwig <hch@lst•de>
Subject: Re: linux-next: build failure after merge of the scsi tree
Date: Tue, 04 Nov 2014 08:07:51 +0100 [thread overview]
Message-ID: <54587B47.2080309@suse.de> (raw)
In-Reply-To: <20141104154320.2919bf64@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 2069 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/04/2014 05:43 AM, Stephen Rothwell wrote:
> Hi James,
>
> After merging the scsi tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> In file included from include/linux/sched.h:17:0, from
> include/linux/blkdev.h:4, from drivers/scsi/constants.c:10:
> drivers/scsi/constants.c: In function 'scsi_opcode_sa_name':
> include/linux/kernel.h:54:32: error: invalid application of
> 'sizeof' to incomplete type 'const char *[]' #define
> ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) +
> __must_be_array(arr)) ^ drivers/scsi/constants.c:300:15: note:
> in expansion of macro 'ARRAY_SIZE' if (opcode <
> ARRAY_SIZE(cdb_byte0_names)) ^
>
> Caused by 94bafab0008c ("scsi: consolidate opcode lookup in
> scsi_opcode_sa_name()"). This build does not have
> CONFIG_SCSI_CONSTANTS set.
>
> I have used the scsi tree from next-20141031 again (since
> yesterday's tree had a different build problem).
>
Sorry. Here's the patch.
Cheers,
Hannes
- --
Dr. Hannes Reinecke zSeries & Storage
hare@suse•de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iQIcBAEBAgAGBQJUWHtHAAoJEGz4yi9OyKjPfdgP+wZweCbK1HJ7PBz8CCqT6n6d
HDOv0oX4Ia3Oo53NhdIAD9745sCWWegSBYZf7C/gTXVtmBxJ30NnuI+Cg0otaTHA
DPJZ26mBCNijYvpVGqgcSkXRdQQMiBGo6TLmsdpXxn4NFuh3IoRS+8gMgEFxpQdK
aAsHnRBTbfaeYpuNR2P5IJVc1L89rg3DkLWMw3ybSO5WzAcjg4yDiasCsGNHq/T4
e9t+V7/+YA14UOMAHfsAnD/B7UI/7B0ealDbepr/cq1NdJ1F0G7JoCS0yAExRumv
3KBznE29YMZTXCqJg6DNQqkV1xmuB2l2/eAZrM/pHTHGWBQk27WI/KsmqISt9Vb+
vmowDuJQNwZG784KSmbRcjSnuNTIltUybhgF/r+m3dNq4j+H/SroBIi5xI+5HJR+
m7G0tjQkpI3Hie3kf9Egwj09goMZ5ka8tIETMqgJFa2AZ3VpnBekxXGe1OtFgfeo
3nOCnYNNADUSIFUmGmAUusPlgFyMGoWvTHs+koYN8cS+q+X9WJgI3mihnMuiVIux
jG2W7IDCimiss/g0Bnol7M7FdL4QMVeg9/LX5wIl2G1b9Nz4ZDCSI/ooHL+xMFrm
H1wwBF9/xjpc0J6RWimkSvFa4iRCti4Ac8w41l+APwEtH2mWdrefTaadV0JXH/wh
brJGtCQhTrCLGuyLluPx
=xaoW
-----END PGP SIGNATURE-----
[-- Attachment #2: 0001-scsi-Fixup-compilation-warning-when-SCSI_CONSTANTS-i.patch --]
[-- Type: text/x-patch, Size: 863 bytes --]
>From 355eac426aea2e1f98b99a41707b37e9ba3ef02b Mon Sep 17 00:00:00 2001
From: Hannes Reinecke <hare@suse•de>
Date: Tue, 4 Nov 2014 08:06:03 +0100
Subject: [PATCH] scsi: Fixup compilation warning when SCSI_CONSTANTS is not
set
ARRAY_SIZE() requires the array to actually have a size.
Signed-off-by: Hannes Reinecke <hare@suse•de>
---
drivers/scsi/constants.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c
index b3cbf3a..a1a7fca 100644
--- a/drivers/scsi/constants.c
+++ b/drivers/scsi/constants.c
@@ -267,7 +267,7 @@ static struct sa_name_list sa_names_arr[] = {
};
#else /* ifndef CONFIG_SCSI_CONSTANTS */
-static const char *cdb_byte0_names[];
+static const char *cdb_byte0_names[0];
static struct sa_name_list sa_names_arr[] = {
{VARIABLE_LENGTH_CMD, NULL, 0},
--
1.8.5.2
next prev parent reply other threads:[~2014-11-04 7:07 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 4:43 linux-next: build failure after merge of the scsi tree Stephen Rothwell
2014-11-04 7:07 ` Hannes Reinecke [this message]
2014-11-05 4:48 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2019-03-20 0:48 Stephen Rothwell
2017-08-28 8:02 Stephen Rothwell
2017-02-06 5:04 Stephen Rothwell
2017-02-13 0:32 ` Stephen Rothwell
2017-02-13 16:18 ` Jens Axboe
2016-12-23 0:45 Stephen Rothwell
2016-12-23 0:56 ` James Bottomley
[not found] ` <20161224123853.08284e8a@canb.auug.org.au>
2016-12-24 10:15 ` Ingo Molnar
2016-12-24 10:44 ` Stephen Rothwell
2016-12-24 11:46 ` Thomas Gleixner
2016-12-24 16:48 ` James Bottomley
2015-11-13 1:35 Stephen Rothwell
2015-11-13 8:32 ` Sreekanth Reddy
2015-06-02 8:06 Stephen Rothwell
2015-06-02 15:02 ` James Bottomley
2015-02-04 6:29 Stephen Rothwell
2015-02-04 6:47 ` Joe Perches
2015-02-04 15:26 ` James Bottomley
2014-11-10 6:15 Stephen Rothwell
2014-11-10 6:27 ` Anish Bhatt
2014-11-10 13:46 ` Christoph Hellwig
2014-11-10 15:21 ` James Bottomley
2014-11-10 15:48 ` Christoph Hellwig
2014-11-10 15:50 ` James Bottomley
2014-11-10 16:01 ` Christoph Hellwig
2014-11-03 2:52 Stephen Rothwell
2014-11-03 7:51 ` Hannes Reinecke
2014-11-03 18:31 ` Christoph Hellwig
2014-09-26 8:34 Stephen Rothwell
2014-09-26 8:36 ` Christoph Hellwig
2014-09-26 9:57 ` James Bottomley
2014-09-26 12:43 ` Brian King
2013-01-12 2:23 wenxiong
2013-01-11 1:03 Stephen Rothwell
2013-01-11 7:34 ` James Bottomley
2013-01-11 15:27 ` Brian King
2013-01-11 15:37 ` James Bottomley
2013-01-11 16:05 ` Greg KH
2013-01-11 17:35 ` Brian King
2013-01-11 18:04 ` James Bottomley
2012-07-20 0:41 Stephen Rothwell
2012-07-20 8:50 ` James Bottomley
2012-03-26 1:17 Stephen Rothwell
2012-03-26 7:57 ` James Bottomley
2012-03-26 14:07 ` Greg KH
2012-03-27 7:29 ` James Bottomley
2012-03-27 22:17 ` Alexey Dobriyan
2012-03-27 22:22 ` Greg KH
2012-03-27 22:35 ` Alexey Dobriyan
2012-03-27 22:39 ` Alexey Dobriyan
2012-03-28 23:54 ` Greg KH
2012-03-29 19:38 ` Greg KH
2012-03-28 23:52 ` Greg KH
2012-03-29 7:32 ` Gerard Snitselaar
2012-03-29 8:25 ` Stephen Rothwell
2012-03-29 8:35 ` James Bottomley
2012-03-29 9:03 ` Gerard Snitselaar
2012-03-29 16:15 ` Greg KH
2012-03-23 2:00 Stephen Rothwell
2012-03-23 4:50 ` Benjamin Herrenschmidt
2012-03-23 8:14 ` James Bottomley
2012-03-23 8:53 ` Benjamin Herrenschmidt
2012-03-23 9:01 ` James Bottomley
2012-03-23 15:22 ` Jeff Garzik
2012-03-23 10:26 ` Alexey Dobriyan
2012-03-23 15:30 ` Jeff Garzik
2012-03-23 8:20 ` James Bottomley
2012-03-23 9:24 ` Stephen Rothwell
2011-12-15 1:58 Stephen Rothwell
2011-12-15 6:53 ` James Bottomley
2011-08-29 2:09 Stephen Rothwell
2011-08-29 7:17 ` James Bottomley
2011-08-29 8:07 ` Giridhar Malavali
2011-05-27 3:25 Stephen Rothwell
2011-05-27 13:47 ` James Bottomley
2010-10-26 0:19 Stephen Rothwell
2010-10-26 15:50 ` James Bottomley
2010-02-10 1:33 Stephen Rothwell
2010-02-10 22:16 ` James Bottomley
2010-02-10 23:11 ` Stephen Rothwell
2010-02-16 0:38 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54587B47.2080309@suse.de \
--to=hare@suse$(echo .)de \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=elliott@hp$(echo .)com \
--cc=hch@lst$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox