From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Michal Marek <mmarek@suse•cz>,
Michael Ellerman <mpe@ellerman•id.au>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
linuxppc-dev@lists•ozlabs.org
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Masahiro Yamada <yamada.masahiro@socionext•com>
Subject: linux-next: build failure after merge of the kbuild tree
Date: Thu, 28 Jul 2016 12:08:14 +1000 [thread overview]
Message-ID: <20160728120814.59e42bc8@canb.auug.org.au> (raw)
Hi Michal,
After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
In file included from <command-line>:0:0:
arch/powerpc/mm/hash_utils_64.c: In function 'hash__early_init_mmu':
include/linux/kconfig.h:19:65: error: expected '(' before numeric constant
#define ____or(arg1_or_junk, y) __take_second_arg(arg1_or_junk 1, y)
^
include/linux/kconfig.h:7:48: note: in definition of macro '__take_second_arg'
#define __take_second_arg(__ignored, val, ...) val
^
include/linux/kconfig.h:18:23: note: in expansion of macro '____or'
#define ___or(x, y) ____or(__ARG_PLACEHOLDER_##x, y)
^
include/linux/kconfig.h:17:22: note: in expansion of macro '___or'
#define __or(x, y) ___or(x, y)
^
include/linux/kconfig.h:65:28: note: in expansion of macro '__or'
#define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
^
arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 'IS_ENABLED'
else if IS_ENABLED(CONFIG_PPC_NATIVE)
^
include/linux/kconfig.h:19:65: error: statement with no effect [-Werror=unused-value]
#define ____or(arg1_or_junk, y) __take_second_arg(arg1_or_junk 1, y)
^
include/linux/kconfig.h:7:48: note: in definition of macro '__take_second_arg'
#define __take_second_arg(__ignored, val, ...) val
^
include/linux/kconfig.h:18:23: note: in expansion of macro '____or'
#define ___or(x, y) ____or(__ARG_PLACEHOLDER_##x, y)
^
include/linux/kconfig.h:17:22: note: in expansion of macro '___or'
#define __or(x, y) ___or(x, y)
^
include/linux/kconfig.h:65:28: note: in expansion of macro '__or'
#define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
^
arch/powerpc/mm/hash_utils_64.c:929:10: note: in expansion of macro 'IS_ENABLED'
else if IS_ENABLED(CONFIG_PPC_NATIVE)
^
cc1: all warnings being treated as errors
Caused by commit
7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")
from the powerpc tree interacting with commit
5e8754fd80b0 ("kconfig.h: allow to use IS_{ENABLE,REACHABLE} in macro expansion")
from the kbuild tree.
I have applied the following fix patch (that should be applied to the
powerpc tree):
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Thu, 28 Jul 2016 12:03:25 +1000
Subject: [PATCH] powerpc/mm: parenthesise the if condition
The breakage here used to be hidden by the macro expansion.
Fixes: 7353644fa9df ("powerpc/mm: Fix build break when PPC_NATIVE=n")
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
arch/powerpc/mm/hash_utils_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index 1ff11c1bb182..b78b5d211278 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -926,7 +926,7 @@ void __init hash__early_init_mmu(void)
ps3_early_mm_init();
else if (firmware_has_feature(FW_FEATURE_LPAR))
hpte_init_pseries();
- else if IS_ENABLED(CONFIG_PPC_NATIVE)
+ else if (IS_ENABLED(CONFIG_PPC_NATIVE))
hpte_init_native();
if (!mmu_hash_ops.hpte_insert)
--
2.8.1
--
Cheers,
Stephen Rothwell
next reply other threads:[~2016-07-28 2:08 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 2:08 Stephen Rothwell [this message]
2016-07-28 2:40 ` linux-next: build failure after merge of the kbuild tree Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2026-03-16 14:18 Mark Brown
2026-03-16 16:02 ` Nicolas Schier
2026-03-16 16:16 ` Yonghong Song
2026-03-16 17:42 ` Mark Brown
2026-03-16 17:56 ` Nicolas Schier
2025-08-18 4:01 Stephen Rothwell
2025-08-18 4:27 ` Nathan Chancellor
2025-07-30 6:12 Stephen Rothwell
2025-08-04 1:25 ` Stephen Rothwell
2025-08-04 7:09 ` Alexey Gladkov
2025-08-04 22:17 ` Stephen Rothwell
2025-08-05 3:33 ` Stephen Rothwell
2025-08-12 21:51 ` Alexey Gladkov
2025-06-03 6:39 Stephen Rothwell
2025-03-23 23:30 Stephen Rothwell
2025-03-24 13:52 ` Jeff Johnson
2025-03-24 17:37 ` Arnd Bergmann
2025-03-24 17:40 ` Jeff Johnson
2025-03-26 23:16 ` Stephen Rothwell
2025-03-27 0:20 ` Jeff Johnson
2025-03-27 10:13 ` Alessandro Carminati
2024-09-11 0:18 Stephen Rothwell
2024-09-11 9:38 ` Masahiro Yamada
2024-09-11 13:20 ` Kris Van Hees
2024-09-12 1:49 ` Masahiro Yamada
2022-10-14 1:42 Stephen Rothwell
2022-10-14 13:31 ` Masahiro Yamada
2022-10-12 22:17 Stephen Rothwell
2022-10-12 22:34 ` Masahiro Yamada
2022-10-12 23:51 ` Stephen Rothwell
2022-09-08 23:00 Stephen Rothwell
2022-09-09 5:10 ` Masahiro Yamada
2022-09-09 5:24 ` Stephen Rothwell
2022-09-09 6:13 ` Stephen Rothwell
2022-09-09 6:48 ` Masahiro Yamada
2022-09-09 7:49 ` Stephen Rothwell
[not found] ` <CAK7LNARiW66Hk5JJgRYb-edkb6sgTWPbNr1iETkq-RASCo-YkA@mail.gmail.com>
2022-09-11 23:55 ` Stephen Rothwell
2022-09-12 5:06 ` Masahiro Yamada
2022-09-12 7:43 ` Stephen Rothwell
2022-09-09 8:26 ` Stephen Rothwell
2022-09-08 0:06 Stephen Rothwell
2022-09-08 4:14 ` Masahiro Yamada
2022-09-07 12:34 Stephen Rothwell
2022-09-07 13:49 ` Masahiro Yamada
2022-05-23 10:59 Stephen Rothwell
2022-05-23 15:59 ` Masahiro Yamada
2021-08-26 9:13 Stephen Rothwell
2021-08-27 0:52 ` Masahiro Yamada
2021-08-27 1:50 ` Stephen Rothwell
2021-08-27 2:49 ` Masahiro Yamada
2021-02-21 21:33 Stephen Rothwell
2021-02-21 23:21 ` Masahiro Yamada
2020-07-07 7:07 Stephen Rothwell
2020-07-13 1:56 ` Stephen Rothwell
2020-07-13 7:52 ` Masahiro Yamada
2020-04-06 2:34 Stephen Rothwell
2020-04-07 4:41 ` Masahiro Yamada
2020-03-10 22:53 Stephen Rothwell
2020-03-11 4:22 ` Masahiro Yamada
2019-07-16 4:31 Stephen Rothwell
2019-07-16 4:59 ` Masahiro Yamada
2019-07-16 6:42 ` Stephen Rothwell
2019-07-05 8:31 Stephen Rothwell
2019-07-06 0:05 ` Michael Kelley
2019-07-06 0:58 ` Masahiro Yamada
2019-05-05 23:46 Stephen Rothwell
2019-05-05 23:35 Stephen Rothwell
2019-05-05 22:40 Stephen Rothwell
2018-08-22 22:35 Stephen Rothwell
2018-08-23 9:03 ` Masahiro Yamada
2018-05-30 1:29 Stephen Rothwell
2018-05-30 1:44 ` Masahiro Yamada
2018-05-15 5:50 Stephen Rothwell
2018-05-16 6:01 ` Masahiro Yamada
2018-05-16 7:26 ` Stephen Rothwell
2018-05-17 13:45 ` Masahiro Yamada
2018-03-28 21:58 Stephen Rothwell
2018-03-29 1:59 ` Masahiro Yamada
2016-09-15 6:08 Stephen Rothwell
2016-09-22 12:52 ` Michal Marek
2016-03-15 23:58 Stephen Rothwell
2016-03-16 7:53 ` Daniel Wagner
2016-03-16 7:56 ` Michal Marek
2016-03-16 11:29 ` Stephen Rothwell
2016-03-16 11:31 ` Michal Marek
2013-02-24 23:56 Stephen Rothwell
2013-02-25 10:28 ` Michal Marek
2013-02-25 10:58 ` Stephen Rothwell
2013-02-25 11:02 ` Stephen Rothwell
2013-02-25 11:36 ` Michal Marek
2011-04-19 22:25 Stephen Rothwell
2011-04-19 22:30 ` Stephen Rothwell
2011-04-20 13:50 ` Michal Marek
2010-03-11 5:15 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728120814.59e42bc8@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mmarek@suse$(echo .)cz \
--cc=mpe@ellerman$(echo .)id.au \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox