From: Masahiro Yamada <yamada.masahiro@socionext•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Linux-Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Taehee Yoo <ap420073@gmail•com>
Subject: Re: linux-next: build failure after merge of the kbuild tree
Date: Thu, 29 Mar 2018 10:59:44 +0900 [thread overview]
Message-ID: <CAK7LNARRbEacK7Y9+yYjLEDVOu7iz8BJetaFd82NMw2cEnbaJg@mail.gmail.com> (raw)
In-Reply-To: <20180329085809.78af08ff@canb.auug.org.au>
Hi Stephen,
2018-03-29 6:58 GMT+09:00 Stephen Rothwell <sfr@canb•auug.org.au>:
> Hi Masahiro,
>
> After merging the kbuild tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> net/ipv4/netfilter/nf_nat_snmp_basic_main.c:57:10: fatal err
> or: nf_nat_snmp_basic.asn1.h: No such file or directory
> #include "nf_nat_snmp_basic.asn1.h"
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Presuambly caused by commit
>
> 9ee1b1bb8743 ("kbuild: rename *-asn1.[ch] to *.asn1.[ch]")
>
> though I am not sure why it didn't fail yesterday.
>
> I reverted that commit (and the following one because of a conflict)
> for today.
>
> --
> Cheers,
> Stephen Rothwell
Thanks for the report.
I think my patch is just a coincidence.
The netfilter Makefile seems weird.
I queued up the following fix-up to my kbuild tree.
Hopefully linux-next will be OK tomorrow.
commit 28913ee8191adf4bbc01cbfb9ee18cca782ab141
Author: Masahiro Yamada <yamada.masahiro@socionext•com>
Date: Thu Mar 29 09:24:28 2018 +0900
netfilter: nf_nat_snmp_basic: add correct dependency to Makefile
nf_nat_snmp_basic_main.c includes a generated header, but the
necessary dependency is missing in Makefile. This could cause
build error in parallel building.
Remove a weird line, and add a correct one.
Fixes: cc2d58634e0f ("netfilter: nf_nat_snmp_basic: use asn1
decoder library")
Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext•com>
diff --git a/net/ipv4/netfilter/Makefile b/net/ipv4/netfilter/Makefile
index 2dad20e..9bd19cd 100644
--- a/net/ipv4/netfilter/Makefile
+++ b/net/ipv4/netfilter/Makefile
@@ -29,7 +29,7 @@ obj-$(CONFIG_NF_NAT_H323) += nf_nat_h323.o
obj-$(CONFIG_NF_NAT_PPTP) += nf_nat_pptp.o
nf_nat_snmp_basic-y := nf_nat_snmp_basic-asn1.o nf_nat_snmp_basic_main.o
-nf_nat_snmp_basic-y : nf_nat_snmp_basic-asn1.h nf_nat_snmp_basic-asn1.c
+$(obj)/nf_nat_snmp_basic_main.o: $(obj)/nf_nat_snmp_basic-asn1.h
obj-$(CONFIG_NF_NAT_SNMP_BASIC) += nf_nat_snmp_basic.o
clean-files := nf_nat_snmp_basic-asn1.c nf_nat_snmp_basic-asn1.h
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-03-29 1:59 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 21:58 linux-next: build failure after merge of the kbuild tree Stephen Rothwell
2018-03-29 1:59 ` Masahiro Yamada [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-16 14:18 Mark Brown
2026-03-16 16:02 ` Nicolas Schier
2026-03-16 16:16 ` Yonghong Song
2026-03-16 17:42 ` Mark Brown
2026-03-16 17:56 ` Nicolas Schier
2025-08-18 4:01 Stephen Rothwell
2025-08-18 4:27 ` Nathan Chancellor
2025-07-30 6:12 Stephen Rothwell
2025-08-04 1:25 ` Stephen Rothwell
2025-08-04 7:09 ` Alexey Gladkov
2025-08-04 22:17 ` Stephen Rothwell
2025-08-05 3:33 ` Stephen Rothwell
2025-08-12 21:51 ` Alexey Gladkov
2025-06-03 6:39 Stephen Rothwell
2025-03-23 23:30 Stephen Rothwell
2025-03-24 13:52 ` Jeff Johnson
2025-03-24 17:37 ` Arnd Bergmann
2025-03-24 17:40 ` Jeff Johnson
2025-03-26 23:16 ` Stephen Rothwell
2025-03-27 0:20 ` Jeff Johnson
2025-03-27 10:13 ` Alessandro Carminati
2024-09-11 0:18 Stephen Rothwell
2024-09-11 9:38 ` Masahiro Yamada
2024-09-11 13:20 ` Kris Van Hees
2024-09-12 1:49 ` Masahiro Yamada
2022-10-14 1:42 Stephen Rothwell
2022-10-14 13:31 ` Masahiro Yamada
2022-10-12 22:17 Stephen Rothwell
2022-10-12 22:34 ` Masahiro Yamada
2022-10-12 23:51 ` Stephen Rothwell
2022-09-08 23:00 Stephen Rothwell
2022-09-09 5:10 ` Masahiro Yamada
2022-09-09 5:24 ` Stephen Rothwell
2022-09-09 6:13 ` Stephen Rothwell
2022-09-09 6:48 ` Masahiro Yamada
2022-09-09 7:49 ` Stephen Rothwell
[not found] ` <CAK7LNARiW66Hk5JJgRYb-edkb6sgTWPbNr1iETkq-RASCo-YkA@mail.gmail.com>
2022-09-11 23:55 ` Stephen Rothwell
2022-09-12 5:06 ` Masahiro Yamada
2022-09-12 7:43 ` Stephen Rothwell
2022-09-09 8:26 ` Stephen Rothwell
2022-09-08 0:06 Stephen Rothwell
2022-09-08 4:14 ` Masahiro Yamada
2022-09-07 12:34 Stephen Rothwell
2022-09-07 13:49 ` Masahiro Yamada
2022-05-23 10:59 Stephen Rothwell
2022-05-23 15:59 ` Masahiro Yamada
2021-08-26 9:13 Stephen Rothwell
2021-08-27 0:52 ` Masahiro Yamada
2021-08-27 1:50 ` Stephen Rothwell
2021-08-27 2:49 ` Masahiro Yamada
2021-02-21 21:33 Stephen Rothwell
2021-02-21 23:21 ` Masahiro Yamada
2020-07-07 7:07 Stephen Rothwell
2020-07-13 1:56 ` Stephen Rothwell
2020-07-13 7:52 ` Masahiro Yamada
2020-04-06 2:34 Stephen Rothwell
2020-04-07 4:41 ` Masahiro Yamada
2020-03-10 22:53 Stephen Rothwell
2020-03-11 4:22 ` Masahiro Yamada
2019-07-16 4:31 Stephen Rothwell
2019-07-16 4:59 ` Masahiro Yamada
2019-07-16 6:42 ` Stephen Rothwell
2019-07-05 8:31 Stephen Rothwell
2019-07-06 0:05 ` Michael Kelley
2019-07-06 0:58 ` Masahiro Yamada
2019-05-05 23:46 Stephen Rothwell
2019-05-05 23:35 Stephen Rothwell
2019-05-05 22:40 Stephen Rothwell
2018-08-22 22:35 Stephen Rothwell
2018-08-23 9:03 ` Masahiro Yamada
2018-05-30 1:29 Stephen Rothwell
2018-05-30 1:44 ` Masahiro Yamada
2018-05-15 5:50 Stephen Rothwell
2018-05-16 6:01 ` Masahiro Yamada
2018-05-16 7:26 ` Stephen Rothwell
2018-05-17 13:45 ` Masahiro Yamada
2016-09-15 6:08 Stephen Rothwell
2016-09-22 12:52 ` Michal Marek
2016-07-28 2:08 Stephen Rothwell
2016-07-28 2:40 ` Michael Ellerman
2016-03-15 23:58 Stephen Rothwell
2016-03-16 7:53 ` Daniel Wagner
2016-03-16 7:56 ` Michal Marek
2016-03-16 11:29 ` Stephen Rothwell
2016-03-16 11:31 ` Michal Marek
2013-02-24 23:56 Stephen Rothwell
2013-02-25 10:28 ` Michal Marek
2013-02-25 10:58 ` Stephen Rothwell
2013-02-25 11:02 ` Stephen Rothwell
2013-02-25 11:36 ` Michal Marek
2011-04-19 22:25 Stephen Rothwell
2011-04-19 22:30 ` Stephen Rothwell
2011-04-20 13:50 ` Michal Marek
2010-03-11 5:15 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNARRbEacK7Y9+yYjLEDVOu7iz8BJetaFd82NMw2cEnbaJg@mail.gmail.com \
--to=yamada.masahiro@socionext$(echo .)com \
--cc=ap420073@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox