From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Masahiro Yamada <yamada.masahiro@socionext•com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Alexey Gladkov <gladkov.alexey@gmail•com>,
Keshava Munegowda <keshava_mgowda@ti•com>,
Samuel Ortiz <sameo@linux•intel.com>
Subject: linux-next: build failure after merge of the kbuild tree
Date: Mon, 6 May 2019 09:46:09 +1000 [thread overview]
Message-ID: <20190506094609.08e930f2@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]
Hi Masahiro,
After merging the kbuild tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
In file included from include/linux/module.h:18,
from drivers/mfd/omap-usb-tll.c:21:
drivers/mfd/omap-usb-tll.c:462:26: error: expected ',' or ';' before 'USBHS_DRIVER_NAME'
MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
^~~~~~~~~~~~~~~~~
include/linux/moduleparam.h:26:47: note: in definition of macro '__MODULE_INFO'
= __MODULE_INFO_PREFIX __stringify(tag) "=" info
^~~~
include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO'
#define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias)
^~~~~~~~~~~
drivers/mfd/omap-usb-tll.c:462:1: note: in expansion of macro 'MODULE_ALIAS'
MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
^~~~~~~~~~~~
Caused by commit
6a26793a7891 ("moduleparam: Save information about built-in modules in separate file")
USBHS_DRIVER_NAME is not defined and this kbuild tree change has
exposed it. It has been this way since commit
16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
From v3.7-rc1 in 2012.
I have applied the following patch for today.
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 6 May 2019 09:39:14 +1000
Subject: [PATCH] mfd: omap: remove unused MODULE_ALIAS from omap-usb-tll.c
USBHS_DRIVER_NAME has never been defined, so this cannot have ever
been used.
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/mfd/omap-usb-tll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 446713dbee27..1cc8937e8bec 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -459,7 +459,7 @@ EXPORT_SYMBOL_GPL(omap_tll_disable);
MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti•com>");
MODULE_AUTHOR("Roger Quadros <rogerq@ti•com>");
-MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
+// MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");
--
2.20.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2019-05-05 23:46 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 23:46 Stephen Rothwell [this message]
2019-05-06 2:19 ` Fwd: linux-next: build failure after merge of the kbuild tree Masahiro Yamada
2019-05-06 3:31 ` Paul Gortmaker
2019-05-06 12:07 ` Masahiro Yamada
2019-05-06 14:20 ` Paul Gortmaker
2019-05-08 4:31 ` Masahiro Yamada
-- strict thread matches above, loose matches on Subject: below --
2026-03-16 14:18 Mark Brown
2026-03-16 16:02 ` Nicolas Schier
2026-03-16 16:16 ` Yonghong Song
2026-03-16 17:42 ` Mark Brown
2026-03-16 17:56 ` Nicolas Schier
2025-08-18 4:01 Stephen Rothwell
2025-08-18 4:27 ` Nathan Chancellor
2025-07-30 6:12 Stephen Rothwell
2025-08-04 1:25 ` Stephen Rothwell
2025-08-04 7:09 ` Alexey Gladkov
2025-08-04 22:17 ` Stephen Rothwell
2025-08-05 3:33 ` Stephen Rothwell
2025-08-12 21:51 ` Alexey Gladkov
2025-06-03 6:39 Stephen Rothwell
2025-03-23 23:30 Stephen Rothwell
2025-03-24 13:52 ` Jeff Johnson
2025-03-24 17:37 ` Arnd Bergmann
2025-03-24 17:40 ` Jeff Johnson
2025-03-26 23:16 ` Stephen Rothwell
2025-03-27 0:20 ` Jeff Johnson
2025-03-27 10:13 ` Alessandro Carminati
2024-09-11 0:18 Stephen Rothwell
2024-09-11 9:38 ` Masahiro Yamada
2024-09-11 13:20 ` Kris Van Hees
2024-09-12 1:49 ` Masahiro Yamada
2022-10-14 1:42 Stephen Rothwell
2022-10-14 13:31 ` Masahiro Yamada
2022-10-12 22:17 Stephen Rothwell
2022-10-12 22:34 ` Masahiro Yamada
2022-10-12 23:51 ` Stephen Rothwell
2022-09-08 23:00 Stephen Rothwell
2022-09-09 5:10 ` Masahiro Yamada
2022-09-09 5:24 ` Stephen Rothwell
2022-09-09 6:13 ` Stephen Rothwell
2022-09-09 6:48 ` Masahiro Yamada
2022-09-09 7:49 ` Stephen Rothwell
[not found] ` <CAK7LNARiW66Hk5JJgRYb-edkb6sgTWPbNr1iETkq-RASCo-YkA@mail.gmail.com>
2022-09-11 23:55 ` Stephen Rothwell
2022-09-12 5:06 ` Masahiro Yamada
2022-09-12 7:43 ` Stephen Rothwell
2022-09-09 8:26 ` Stephen Rothwell
2022-09-08 0:06 Stephen Rothwell
2022-09-08 4:14 ` Masahiro Yamada
2022-09-07 12:34 Stephen Rothwell
2022-09-07 13:49 ` Masahiro Yamada
2022-05-23 10:59 Stephen Rothwell
2022-05-23 15:59 ` Masahiro Yamada
2021-08-26 9:13 Stephen Rothwell
2021-08-27 0:52 ` Masahiro Yamada
2021-08-27 1:50 ` Stephen Rothwell
2021-08-27 2:49 ` Masahiro Yamada
2021-02-21 21:33 Stephen Rothwell
2021-02-21 23:21 ` Masahiro Yamada
2020-07-07 7:07 Stephen Rothwell
2020-07-13 1:56 ` Stephen Rothwell
2020-07-13 7:52 ` Masahiro Yamada
2020-04-06 2:34 Stephen Rothwell
2020-04-07 4:41 ` Masahiro Yamada
2020-03-10 22:53 Stephen Rothwell
2020-03-11 4:22 ` Masahiro Yamada
2019-07-16 4:31 Stephen Rothwell
2019-07-16 4:59 ` Masahiro Yamada
2019-07-16 6:42 ` Stephen Rothwell
2019-07-05 8:31 Stephen Rothwell
2019-07-06 0:05 ` Michael Kelley
2019-07-06 0:58 ` Masahiro Yamada
2019-05-05 23:35 Stephen Rothwell
2019-05-05 22:40 Stephen Rothwell
2018-08-22 22:35 Stephen Rothwell
2018-08-23 9:03 ` Masahiro Yamada
2018-05-30 1:29 Stephen Rothwell
2018-05-30 1:44 ` Masahiro Yamada
2018-05-15 5:50 Stephen Rothwell
2018-05-16 6:01 ` Masahiro Yamada
2018-05-16 7:26 ` Stephen Rothwell
2018-05-17 13:45 ` Masahiro Yamada
2018-03-28 21:58 Stephen Rothwell
2018-03-29 1:59 ` Masahiro Yamada
2016-09-15 6:08 Stephen Rothwell
2016-09-22 12:52 ` Michal Marek
2016-07-28 2:08 Stephen Rothwell
2016-07-28 2:40 ` Michael Ellerman
2016-03-15 23:58 Stephen Rothwell
2016-03-16 7:53 ` Daniel Wagner
2016-03-16 7:56 ` Michal Marek
2016-03-16 11:29 ` Stephen Rothwell
2016-03-16 11:31 ` Michal Marek
2013-02-24 23:56 Stephen Rothwell
2013-02-25 10:28 ` Michal Marek
2013-02-25 10:58 ` Stephen Rothwell
2013-02-25 11:02 ` Stephen Rothwell
2013-02-25 11:36 ` Michal Marek
2011-04-19 22:25 Stephen Rothwell
2011-04-19 22:30 ` Stephen Rothwell
2011-04-20 13:50 ` Michal Marek
2010-03-11 5:15 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506094609.08e930f2@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=gladkov.alexey@gmail$(echo .)com \
--cc=keshava_mgowda@ti$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sameo@linux$(echo .)intel.com \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox