From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Theodore Ts'o <tytso@mit•edu>, "Jason A. Donenfeld" <Jason@zx2c4•com>
Cc: Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: linux-next: build failure after merge of the random tree
Date: Thu, 3 Mar 2022 19:04:50 +1100 [thread overview]
Message-ID: <20220303190450.18626eea@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 3638 bytes --]
Hi all,
After merging the random tree, today's linux-next build (arm64 defconfig)
failed like this:
In file included from include/linux/srcu.h:49,
from include/linux/notifier.h:16,
from include/linux/random.h:10,
from arch/arm64/include/asm/pointer_auth.h:7,
from arch/arm64/include/asm/processor.h:43,
from include/linux/mutex.h:19,
from include/linux/kernfs.h:11,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/of.h:17,
from include/linux/irqdomain.h:35,
from include/linux/acpi.h:13,
from include/acpi/apei.h:9,
from include/acpi/ghes.h:5,
from include/linux/arm_sdei.h:8,
from arch/arm64/kernel/asm-offsets.c:10:
include/linux/srcutree.h:67:22: error: field 'srcu_cb_mutex' has incomplete type
67 | struct mutex srcu_cb_mutex; /* Serialize CB preparation. */
| ^~~~~~~~~~~~~
include/linux/srcutree.h:69:22: error: field 'srcu_gp_mutex' has incomplete type
69 | struct mutex srcu_gp_mutex; /* Serialize GP work. */
| ^~~~~~~~~~~~~
include/linux/srcutree.h:80:22: error: field 'srcu_barrier_mutex' has incomplete type
80 | struct mutex srcu_barrier_mutex; /* Serialize barrier ops. */
| ^~~~~~~~~~~~~~~~~~
In file included from include/linux/random.h:10,
from arch/arm64/include/asm/pointer_auth.h:7,
from arch/arm64/include/asm/processor.h:43,
from include/linux/mutex.h:19,
from include/linux/kernfs.h:11,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/of.h:17,
from include/linux/irqdomain.h:35,
from include/linux/acpi.h:13,
from include/acpi/apei.h:9,
from include/acpi/ghes.h:5,
from include/linux/arm_sdei.h:8,
from arch/arm64/kernel/asm-offsets.c:10:
include/linux/notifier.h:75:22: error: field 'mutex' has incomplete type
75 | struct mutex mutex;
| ^~~~~
Caused by commit
c3b03baac3f2 ("random: replace custom notifier chain with standard one")
Which added the include of linux/notifier.h to linux/random.h :-(
I have added this patch for today:
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Thu, 3 Mar 2022 18:43:56 +1100
Subject: [PATCH] fix up for "random: replace custom notifier chain with standard one"
Only the forward declaration of struct notifier_block is needed.
This prevents a circular include dependency on arm64 (at least).
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
include/linux/random.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/random.h b/include/linux/random.h
index 7fccbc7e5a75..c0baffe7afb1 100644
--- a/include/linux/random.h
+++ b/include/linux/random.h
@@ -7,10 +7,11 @@
#include <linux/kernel.h>
#include <linux/list.h>
#include <linux/once.h>
-#include <linux/notifier.h>
#include <uapi/linux/random.h>
+struct notifier_block;
+
extern void add_device_randomness(const void *, size_t);
extern void add_bootloader_randomness(const void *, size_t);
--
2.34.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2022-03-03 8:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 8:04 Stephen Rothwell [this message]
2022-03-03 10:41 ` linux-next: build failure after merge of the random tree Jason A. Donenfeld
-- strict thread matches above, loose matches on Subject: below --
2026-01-23 21:48 Mark Brown
2026-01-23 21:56 ` Andy Shevchenko
2026-01-23 22:10 ` Mark Brown
2026-01-23 22:18 ` Andy Shevchenko
2026-01-23 22:22 ` Mark Brown
2026-01-23 22:44 ` Andy Shevchenko
2026-02-02 15:22 ` Mark Brown
2026-02-02 17:34 ` Andy Shevchenko
2026-02-02 19:51 ` Jason A. Donenfeld
2024-10-01 3:44 Stephen Rothwell
2024-10-01 8:06 ` Uros Bizjak
2024-10-10 4:38 ` Stephen Rothwell
2024-11-20 2:34 ` Stephen Rothwell
2024-09-05 10:19 Stephen Rothwell
2024-09-05 12:47 ` Jason A. Donenfeld
2024-03-25 1:01 Stephen Rothwell
2024-03-26 16:08 ` Jason A. Donenfeld
2022-12-14 1:53 Stephen Rothwell
2022-12-14 5:37 ` Jason A. Donenfeld
2022-12-13 3:36 Stephen Rothwell
2022-12-13 4:02 ` Jason A. Donenfeld
2022-10-31 6:09 Stephen Rothwell
2022-10-31 10:31 ` Jason A. Donenfeld
2022-10-24 2:23 Stephen Rothwell
2022-10-24 4:28 ` Jason A. Donenfeld
2022-10-24 6:33 ` Stephen Rothwell
2018-06-29 6:06 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303190450.18626eea@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=Jason@zx2c4$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=tytso@mit$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox