public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Theodore Ts'o <tytso@mit•edu>,
	"Jason A. Donenfeld" <Jason@zx2c4•com>,
	Thomas Gleixner <tglx@linutronix•de>,
	Ingo Molnar <mingo@redhat•com>, "H. Peter Anvin" <hpa@zytor•com>,
	Peter Zijlstra <peterz@infradead•org>
Cc: Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: linux-next: build failure after merge of the random tree
Date: Mon, 24 Oct 2022 13:23:19 +1100	[thread overview]
Message-ID: <20221024132319.4b3910ad@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]

Hi all,

After merging the random tree, today's linux-next build (x86_64
allmodconfig) failed like this:

arch/x86/mm/cpu_entry_area.c: In function 'init_cea_offsets':
arch/x86/mm/cpu_entry_area.c:38:23: error: implicit declaration of function 'prandom_u32_max'; did you mean 'prandom_u32_state'? [-Werror=implicit-function-declaration]
   38 |                 cea = prandom_u32_max(max_cea);
      |                       ^~~~~~~~~~~~~~~
      |                       prandom_u32_state
cc1: all warnings being treated as errors

Caused by commit

  921b09c09fe7 ("prandom: remove prandom_u32_max()")

interacting with commit

  1248fb6a8201 ("x86/mm: Randomize per-cpu entry area")

from the tip tree.

I have applied the following fix up patch for today.

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 24 Oct 2022 12:37:28 +1100
Subject: [PATCH] fix up for "prandom: remove prandom_u32_max()"

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 arch/x86/mm/cpu_entry_area.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/mm/cpu_entry_area.c b/arch/x86/mm/cpu_entry_area.c
index ad1f750517a1..7a1b63fb80d3 100644
--- a/arch/x86/mm/cpu_entry_area.c
+++ b/arch/x86/mm/cpu_entry_area.c
@@ -35,7 +35,7 @@ static __init void init_cea_offsets(void)
 		unsigned int cea;
 
 again:
-		cea = prandom_u32_max(max_cea);
+		cea = get_random_u32_below(max_cea);
 
 		/* Make sure that no previous CPU shares the offset: */
 		for_each_possible_cpu(j) {
-- 
2.34.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2022-10-24  2:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24  2:23 Stephen Rothwell [this message]
2022-10-24  4:28 ` linux-next: build failure after merge of the random tree Jason A. Donenfeld
2022-10-24  6:33   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2026-01-23 21:48 Mark Brown
2026-01-23 21:56 ` Andy Shevchenko
2026-01-23 22:10   ` Mark Brown
2026-01-23 22:18     ` Andy Shevchenko
2026-01-23 22:22       ` Mark Brown
2026-01-23 22:44         ` Andy Shevchenko
2026-02-02 15:22 ` Mark Brown
2026-02-02 17:34   ` Andy Shevchenko
2026-02-02 19:51     ` Jason A. Donenfeld
2024-10-01  3:44 Stephen Rothwell
2024-10-01  8:06 ` Uros Bizjak
2024-10-10  4:38 ` Stephen Rothwell
2024-11-20  2:34   ` Stephen Rothwell
2024-09-05 10:19 Stephen Rothwell
2024-09-05 12:47 ` Jason A. Donenfeld
2024-03-25  1:01 Stephen Rothwell
2024-03-26 16:08 ` Jason A. Donenfeld
2022-12-14  1:53 Stephen Rothwell
2022-12-14  5:37 ` Jason A. Donenfeld
2022-12-13  3:36 Stephen Rothwell
2022-12-13  4:02 ` Jason A. Donenfeld
2022-10-31  6:09 Stephen Rothwell
2022-10-31 10:31 ` Jason A. Donenfeld
2022-03-03  8:04 Stephen Rothwell
2022-03-03 10:41 ` Jason A. Donenfeld
2018-06-29  6:06 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221024132319.4b3910ad@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=Jason@zx2c4$(echo .)com \
    --cc=hpa@zytor$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=mingo@redhat$(echo .)com \
    --cc=peterz@infradead$(echo .)org \
    --cc=tglx@linutronix$(echo .)de \
    --cc=tytso@mit$(echo .)edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox