From: "Jason A. Donenfeld" <Jason@zx2c4•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Theodore Ts'o <tytso@mit•edu>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the random tree
Date: Tue, 13 Dec 2022 22:37:04 -0700 [thread overview]
Message-ID: <Y5lhAK6oR/ovwSn5@zx2c4.com> (raw)
In-Reply-To: <20221214125359.147f33fa@canb.auug.org.au>
On Wed, Dec 14, 2022 at 12:53:59PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the random tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> arch/x86/mm/cpu_entry_area.c: In function 'init_cea_offsets':
> arch/x86/mm/cpu_entry_area.c:39:23: error: implicit declaration of function 'prandom_u32_max'; did you mean 'prandom_u32_state'? [-Werror=implicit-function-declaration]
> 39 | cea = prandom_u32_max(max_cea);
> | ^~~~~~~~~~~~~~~
> | prandom_u32_state
> net/ipv4/tcp_plb.c: In function 'tcp_plb_update_state_upon_rto':
> net/ipv4/tcp_plb.c:100:18: error: implicit declaration of function 'prandom_u32_max'; did you mean 'prandom_u32_state'? [-Werror=implicit-function-declaration]
> 100 | pause += prandom_u32_max(pause);
> | ^~~~~~~~~~~~~~~
> | prandom_u32_state
>
> Caused by commit
>
> 1effd020f82d ("prandom: remove prandom_u32_max()")
>
> interacting with some new usages. Why not leave this removal until
> just after -rc1 has been released?
>
> I have reverted this commit for today.
The plan was the last chance before rc1, yea. I'll remove it for now so
that it stops breaking -next.
Jason
next prev parent reply other threads:[~2022-12-14 5:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 1:53 linux-next: build failure after merge of the random tree Stephen Rothwell
2022-12-14 5:37 ` Jason A. Donenfeld [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-01-23 21:48 Mark Brown
2026-01-23 21:56 ` Andy Shevchenko
2026-01-23 22:10 ` Mark Brown
2026-01-23 22:18 ` Andy Shevchenko
2026-01-23 22:22 ` Mark Brown
2026-01-23 22:44 ` Andy Shevchenko
2026-02-02 15:22 ` Mark Brown
2026-02-02 17:34 ` Andy Shevchenko
2026-02-02 19:51 ` Jason A. Donenfeld
2024-10-01 3:44 Stephen Rothwell
2024-10-01 8:06 ` Uros Bizjak
2024-10-10 4:38 ` Stephen Rothwell
2024-11-20 2:34 ` Stephen Rothwell
2024-09-05 10:19 Stephen Rothwell
2024-09-05 12:47 ` Jason A. Donenfeld
2024-03-25 1:01 Stephen Rothwell
2024-03-26 16:08 ` Jason A. Donenfeld
2022-12-13 3:36 Stephen Rothwell
2022-12-13 4:02 ` Jason A. Donenfeld
2022-10-31 6:09 Stephen Rothwell
2022-10-31 10:31 ` Jason A. Donenfeld
2022-10-24 2:23 Stephen Rothwell
2022-10-24 4:28 ` Jason A. Donenfeld
2022-10-24 6:33 ` Stephen Rothwell
2022-03-03 8:04 Stephen Rothwell
2022-03-03 10:41 ` Jason A. Donenfeld
2018-06-29 6:06 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5lhAK6oR/ovwSn5@zx2c4.com \
--to=jason@zx2c4$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tytso@mit$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox