* [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n
@ 2013-01-19 0:54 Sedat Dilek
2013-01-19 0:54 ` [PATCH next-20130118 2/2] KEYS: MODSIGN: Fix wrong select in MODULE_SIG Kconfig Sedat Dilek
2013-01-19 1:07 ` [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n David Howells
0 siblings, 2 replies; 4+ messages in thread
From: Sedat Dilek @ 2013-01-19 0:54 UTC (permalink / raw)
To: David Howells, Rusty Russell, linux-kernel, linux-next,
Stephen Rothwell
Cc: Sedat Dilek
When SYSTEM_TRUSTED_KEYRING=n my build fails like this:
kernel/module_signing.c: In function 'request_asymmetric_key':
kernel/module_signing.c:161:36: error: 'system_trusted_keyring' undeclared (first use in this function)
kernel/module_signing.c:161:36: note: each undeclared identifier is reported only once for each function it appears in
Fix this by replacing "select" with "depends on" KEYS Kconfig.
For more details follow the thread in [1].
[1] http://marc.info/?t=135854545000001&r=1&w=2
Tested against Linux-Next (next-20130118).
Signed-off-by: Sedat Dilek <sedat.dilek@gmail•com>
---
init/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/Kconfig b/init/Kconfig
index fb2959d..f7e1b32 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1607,7 +1607,7 @@ config BASE_SMALL
config SYSTEM_TRUSTED_KEYRING
bool "Provide system-wide ring of trusted keys"
- select KEYS
+ depends on KEYS
help
Provide a system keyring to which trusted keys can be added. Keys in
the keyring are considered to be trusted. Keys may be added at will
--
1.8.1.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH next-20130118 2/2] KEYS: MODSIGN: Fix wrong select in MODULE_SIG Kconfig
2013-01-19 0:54 [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n Sedat Dilek
@ 2013-01-19 0:54 ` Sedat Dilek
2013-01-19 1:07 ` [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n David Howells
1 sibling, 0 replies; 4+ messages in thread
From: Sedat Dilek @ 2013-01-19 0:54 UTC (permalink / raw)
To: David Howells, Rusty Russell, linux-kernel, linux-next,
Stephen Rothwell
Cc: Sedat Dilek
There exists no SYSTEM_TRUSTED_KEYS Kconfig option but
SYSTEM_TRUSTED_KEYRING.
Tested against Linux-Next (next-20130118).
Signed-off-by: Sedat Dilek <sedat.dilek@gmail•com>
---
init/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/Kconfig b/init/Kconfig
index f7e1b32..7191ccf 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1689,7 +1689,7 @@ config MODULE_SRCVERSION_ALL
config MODULE_SIG
bool "Module signature verification"
depends on MODULES
- select SYSTEM_TRUSTED_KEYS
+ select SYSTEM_TRUSTED_KEYRING
select KEYS
select CRYPTO
select ASYMMETRIC_KEY_TYPE
--
1.8.1.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n
2013-01-19 0:54 [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n Sedat Dilek
2013-01-19 0:54 ` [PATCH next-20130118 2/2] KEYS: MODSIGN: Fix wrong select in MODULE_SIG Kconfig Sedat Dilek
@ 2013-01-19 1:07 ` David Howells
2013-01-19 1:13 ` Sedat Dilek
1 sibling, 1 reply; 4+ messages in thread
From: David Howells @ 2013-01-19 1:07 UTC (permalink / raw)
To: Sedat Dilek
Cc: dhowells, Rusty Russell, linux-kernel, linux-next,
Stephen Rothwell
Sedat Dilek <sedat.dilek@gmail•com> wrote:
> - select KEYS
> + depends on KEYS
This change was pushed upstream a few hours ago. It may not have made it into
linux-next yet.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n
2013-01-19 1:07 ` [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n David Howells
@ 2013-01-19 1:13 ` Sedat Dilek
0 siblings, 0 replies; 4+ messages in thread
From: Sedat Dilek @ 2013-01-19 1:13 UTC (permalink / raw)
To: David Howells; +Cc: Rusty Russell, linux-kernel, linux-next, Stephen Rothwell
On Sat, Jan 19, 2013 at 2:07 AM, David Howells <dhowells@redhat•com> wrote:
> Sedat Dilek <sedat.dilek@gmail•com> wrote:
>
>> - select KEYS
>> + depends on KEYS
>
> This change was pushed upstream a few hours ago. It may not have made it into
> linux-next yet.
>
I know, but this patch is 1/2.
OK, I could have done one single patch, but anyway :-).
The series is for people testing Linux-Next (see my label in the
subject-line) and trapping into the pitfall.
Patches are cheap...
- Sedat -
> David
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-19 1:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-19 0:54 [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n Sedat Dilek
2013-01-19 0:54 ` [PATCH next-20130118 2/2] KEYS: MODSIGN: Fix wrong select in MODULE_SIG Kconfig Sedat Dilek
2013-01-19 1:07 ` [PATCH next-20130118 1/2] KEYS: Fix build-error when SYSTEM_TRUSTED_KEYRING=n David Howells
2013-01-19 1:13 ` Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox