* Re: [PATCH] media: i2c: max9271: Add MODULE_* macros
2021-02-10 15:49 [PATCH] media: i2c: max9271: Add MODULE_* macros Jacopo Mondi
@ 2021-02-10 16:08 ` Sakari Ailus
2021-02-10 16:15 ` Laurent Pinchart
2021-02-10 16:28 ` Nathan Chancellor
2 siblings, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2021-02-10 16:08 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Mauro Carvalho Chehab, Laurent Pinchart, Sakari Ailus,
linux-media, linux-next, linux-renesas-soc, Stephen Rothwell,
Nathan Chancellor
On Wed, Feb 10, 2021 at 04:49:08PM +0100, Jacopo Mondi wrote:
> Since commit 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271
> a module") the max9271 library is built as a module but no
> MODULE_*() attributes were specified, causing a build error
> due to missing license information.
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/media/i2c/max9271.o
>
> Fix this by adding MODULE attributes to the driver.
>
> Fixes: 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 a module")
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> Reported-by: Nathan Chancellor <nathan@kernel•org>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi•org>
> ---
> drivers/media/i2c/max9271.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c
> index c247db569bab..c495582dcff6 100644
> --- a/drivers/media/i2c/max9271.c
> +++ b/drivers/media/i2c/max9271.c
> @@ -18,6 +18,7 @@
>
> #include <linux/delay.h>
> #include <linux/i2c.h>
> +#include <linux/module.h>
>
> #include "max9271.h"
>
> @@ -339,3 +340,7 @@ int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest)
> return 0;
> }
> EXPORT_SYMBOL_GPL(max9271_set_translation);
> +
> +MODULE_DESCRIPTION("Maxim MAX9271 GMSL Serializer");
> +MODULE_AUTHOR("Jacopo Mondi");
> +MODULE_LICENSE("GPL v2");
Acked-by: Sakari Ailus <sakari.ailus@linux•intel.com>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] media: i2c: max9271: Add MODULE_* macros
2021-02-10 15:49 [PATCH] media: i2c: max9271: Add MODULE_* macros Jacopo Mondi
2021-02-10 16:08 ` Sakari Ailus
@ 2021-02-10 16:15 ` Laurent Pinchart
2021-02-10 16:28 ` Nathan Chancellor
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2021-02-10 16:15 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Mauro Carvalho Chehab, Sakari Ailus, linux-media, linux-next,
linux-renesas-soc, Stephen Rothwell, Nathan Chancellor
Hi Jacopo,
Thank you for the patch.
On Wed, Feb 10, 2021 at 04:49:08PM +0100, Jacopo Mondi wrote:
> Since commit 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271
> a module") the max9271 library is built as a module but no
> MODULE_*() attributes were specified, causing a build error
> due to missing license information.
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/media/i2c/max9271.o
>
> Fix this by adding MODULE attributes to the driver.
>
> Fixes: 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 a module")
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> Reported-by: Nathan Chancellor <nathan@kernel•org>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi•org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard•com>
> ---
> drivers/media/i2c/max9271.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c
> index c247db569bab..c495582dcff6 100644
> --- a/drivers/media/i2c/max9271.c
> +++ b/drivers/media/i2c/max9271.c
> @@ -18,6 +18,7 @@
>
> #include <linux/delay.h>
> #include <linux/i2c.h>
> +#include <linux/module.h>
>
> #include "max9271.h"
>
> @@ -339,3 +340,7 @@ int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest)
> return 0;
> }
> EXPORT_SYMBOL_GPL(max9271_set_translation);
> +
> +MODULE_DESCRIPTION("Maxim MAX9271 GMSL Serializer");
> +MODULE_AUTHOR("Jacopo Mondi");
> +MODULE_LICENSE("GPL v2");
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] media: i2c: max9271: Add MODULE_* macros
2021-02-10 15:49 [PATCH] media: i2c: max9271: Add MODULE_* macros Jacopo Mondi
2021-02-10 16:08 ` Sakari Ailus
2021-02-10 16:15 ` Laurent Pinchart
@ 2021-02-10 16:28 ` Nathan Chancellor
2 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2021-02-10 16:28 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Mauro Carvalho Chehab, Laurent Pinchart, Sakari Ailus,
linux-media, linux-next, linux-renesas-soc, Stephen Rothwell
On Wed, Feb 10, 2021 at 04:49:08PM +0100, Jacopo Mondi wrote:
> Since commit 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271
> a module") the max9271 library is built as a module but no
> MODULE_*() attributes were specified, causing a build error
> due to missing license information.
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/media/i2c/max9271.o
>
> Fix this by adding MODULE attributes to the driver.
>
> Fixes: 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 a module")
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> Reported-by: Nathan Chancellor <nathan@kernel•org>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi•org>
Reviewed-by: Nathan Chancellor <nathan@kernel•org>
> ---
> drivers/media/i2c/max9271.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c
> index c247db569bab..c495582dcff6 100644
> --- a/drivers/media/i2c/max9271.c
> +++ b/drivers/media/i2c/max9271.c
> @@ -18,6 +18,7 @@
>
> #include <linux/delay.h>
> #include <linux/i2c.h>
> +#include <linux/module.h>
>
> #include "max9271.h"
>
> @@ -339,3 +340,7 @@ int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest)
> return 0;
> }
> EXPORT_SYMBOL_GPL(max9271_set_translation);
> +
> +MODULE_DESCRIPTION("Maxim MAX9271 GMSL Serializer");
> +MODULE_AUTHOR("Jacopo Mondi");
> +MODULE_LICENSE("GPL v2");
> --
> 2.30.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread