* linux-next: x86 tree build warning
@ 2009-03-06 0:47 Stephen Rothwell
2009-03-06 4:01 ` Cyrill Gorcunov
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2009-03-06 0:47 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin; +Cc: linux-next, Cyrill Gorcunov
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
Hi all,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
In file included from drivers/char/epca.c:49:
drivers/char/digiFep1.h:7:1: warning: "GLOBAL" redefined
In file included from include/linux/linkage.h:5,
from include/linux/kernel.h:11,
from arch/x86/include/asm/system.h:10,
from arch/x86/include/asm/processor.h:17,
from include/linux/prefetch.h:14,
from include/linux/list.h:6,
from include/linux/module.h:9,
from drivers/char/epca.c:29:
arch/x86/include/asm/linkage.h:55:1: warning: this is the location of the previous definition
Probably introduced by commit 95695547a7db44b88a7ee36cf5df188de267e99e
("x86: asm linkage - introduce GLOBAL macro") from the x86 tree.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: x86 tree build warning
2009-03-06 0:47 linux-next: x86 tree build warning Stephen Rothwell
@ 2009-03-06 4:01 ` Cyrill Gorcunov
2009-03-06 5:23 ` Cyrill Gorcunov
0 siblings, 1 reply; 4+ messages in thread
From: Cyrill Gorcunov @ 2009-03-06 4:01 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next
On 3/6/09, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> Hi all,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> In file included from drivers/char/epca.c:49:
> drivers/char/digiFep1.h:7:1: warning: "GLOBAL" redefined
> In file included from include/linux/linkage.h:5,
> from include/linux/kernel.h:11,
> from arch/x86/include/asm/system.h:10,
> from arch/x86/include/asm/processor.h:17,
> from include/linux/prefetch.h:14,
> from include/linux/list.h:6,
> from include/linux/module.h:9,
> from drivers/char/epca.c:29:
> arch/x86/include/asm/linkage.h:55:1: warning: this is the location of the
> previous definition
>
> Probably introduced by commit 95695547a7db44b88a7ee36cf5df188de267e99e
> ("x86: asm linkage - introduce GLOBAL macro") from the x86 tree.
> --
> Cheers,
> Stephen Rothwell sfr@canb•auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
Thanks Stephen, i will take a look. Iirc the same macro used as well
in ia64 arch, weird.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: x86 tree build warning
2009-03-06 4:01 ` Cyrill Gorcunov
@ 2009-03-06 5:23 ` Cyrill Gorcunov
2009-03-06 11:05 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Cyrill Gorcunov @ 2009-03-06 5:23 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-next
On Fri, Mar 6, 2009 at 7:01 AM, Cyrill Gorcunov <gorcunov@gmail•com> wrote:
> On 3/6/09, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>> Hi all,
>>
>> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>>
>> In file included from drivers/char/epca.c:49:
>> drivers/char/digiFep1.h:7:1: warning: "GLOBAL" redefined
>> In file included from include/linux/linkage.h:5,
>> from include/linux/kernel.h:11,
>> from arch/x86/include/asm/system.h:10,
>> from arch/x86/include/asm/processor.h:17,
>> from include/linux/prefetch.h:14,
>> from include/linux/list.h:6,
>> from include/linux/module.h:9,
>> from drivers/char/epca.c:29:
>> arch/x86/include/asm/linkage.h:55:1: warning: this is the location of the
>> previous definition
>>
>> Probably introduced by commit 95695547a7db44b88a7ee36cf5df188de267e99e
>> ("x86: asm linkage - introduce GLOBAL macro") from the x86 tree.
>> --
>> Cheers,
>> Stephen Rothwell sfr@canb•auug.org.au
>> http://www.canb.auug.org.au/~sfr/
>>
>
> Thanks Stephen, i will take a look. Iirc the same macro used as well
> in ia64 arch, weird.
>
I've just checked the sources -- it seems some definitions in
arch/x86/include/asm/linkage.h should be guarded by __ASSEMBLY__ (ie
-- __ALIGN, __ALIGN_STR and eventually GLOBAL). I'll make a patch
today evening (can't get access to linux machine right now). Ingo?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: x86 tree build warning
2009-03-06 5:23 ` Cyrill Gorcunov
@ 2009-03-06 11:05 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2009-03-06 11:05 UTC (permalink / raw)
To: Cyrill Gorcunov
Cc: Stephen Rothwell, Thomas Gleixner, H. Peter Anvin, linux-next
* Cyrill Gorcunov <gorcunov@gmail•com> wrote:
> On Fri, Mar 6, 2009 at 7:01 AM, Cyrill Gorcunov <gorcunov@gmail•com> wrote:
> > On 3/6/09, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >> Hi all,
> >>
> >> Today's linux-next build (x86_64 allmodconfig) produced this warning:
> >>
> >> In file included from drivers/char/epca.c:49:
> >> drivers/char/digiFep1.h:7:1: warning: "GLOBAL" redefined
> >> In file included from include/linux/linkage.h:5,
> >> from include/linux/kernel.h:11,
> >> from arch/x86/include/asm/system.h:10,
> >> from arch/x86/include/asm/processor.h:17,
> >> from include/linux/prefetch.h:14,
> >> from include/linux/list.h:6,
> >> from include/linux/module.h:9,
> >> from drivers/char/epca.c:29:
> >> arch/x86/include/asm/linkage.h:55:1: warning: this is the location of the
> >> previous definition
> >>
> >> Probably introduced by commit 95695547a7db44b88a7ee36cf5df188de267e99e
> >> ("x86: asm linkage - introduce GLOBAL macro") from the x86 tree.
> >> --
> >> Cheers,
> >> Stephen Rothwell sfr@canb•auug.org.au
> >> http://www.canb.auug.org.au/~sfr/
> >>
> >
> > Thanks Stephen, i will take a look. Iirc the same macro used as well
> > in ia64 arch, weird.
> >
>
> I've just checked the sources -- it seems some definitions in
> arch/x86/include/asm/linkage.h should be guarded by
> __ASSEMBLY__ (ie -- __ALIGN, __ALIGN_STR and eventually
> GLOBAL). I'll make a patch today evening (can't get access to
> linux machine right now). Ingo?
sure, that's fine. It's not a fatal warning.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-03-06 11:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-06 0:47 linux-next: x86 tree build warning Stephen Rothwell
2009-03-06 4:01 ` Cyrill Gorcunov
2009-03-06 5:23 ` Cyrill Gorcunov
2009-03-06 11:05 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox