From: Shuah Khan <skhan@linuxfoundation•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>, David Gow <davidgow@google•com>
Cc: "Brendan Higgins" <brendanhiggins@google•com>,
"Daniel Vetter" <daniel.vetter@ffwll•ch>,
"Intel Graphics" <intel-gfx@lists•freedesktop.org>,
DRI <dri-devel@lists•freedesktop.org>,
"Christian König" <christian.koenig@amd•com>,
"Matthew Auld" <matthew.auld@intel•com>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Linux Next Mailing List" <linux-next@vger•kernel.org>,
"Dave Airlie" <airlied@redhat•com>,
"Shuah Khan" <skhan@linuxfoundation•org>
Subject: Re: linux-next: build failure after merge of the kunit-next tree
Date: Fri, 1 Mar 2024 15:30:17 -0700 [thread overview]
Message-ID: <b0abafb8-65c8-4e54-a410-8a5ac7dccee6@linuxfoundation.org> (raw)
In-Reply-To: <20240302074643.6e1086ff@canb.auug.org.au>
Hi Stephen,
On 3/1/24 13:46, Stephen Rothwell wrote:
> Hi Shuah,
>
> On Fri, 1 Mar 2024 09:05:57 -0700 Shuah Khan <skhan@linuxfoundation•org> wrote:
>>
>> On 3/1/24 03:43, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> On Fri, 1 Mar 2024 15:15:02 +0800 David Gow <davidgow@google•com> wrote:
>>>>
>>>> On Thu, 29 Feb 2024 at 23:07, Shuah Khan <skhan@linuxfoundation•org> wrote:
>>>>>
>>>>> I can carry the fix through kselftest kunit if it works
>>>>> for all.
>>>>
>>>> I'm happy for this to go in with the KUnit changes if that's the best
>>>> way to keep all of the printk formatting fixes together.
>
> Unfortunately you can't fix this in the kunit-next tree without pulling
> in Linus' tree (or the drm-fixes tree) - which seems excessive.
>
>>> I am pretty sure that the proper fix has been applied to the
>>> drm-fixes tree today (in the merge of the drm-misc-fixes tree).
>>>
>>
>> What's the commit id for this fix? I Would like to include the details
>> in my pull request to Linus.
>
> My mistake, I misread the merge commit. It has not been fixed in the
> drm-misc-fixes tree or the drm-fixes tree (or Linus' tree since the
> drm-fixes tree has been merged there) :-(
>
> The problem in this case is not with the format string types, but with
> a missing argument i.e. there is another argument required by the
> format string. It really should be fixed in the drm-misc-fixes tree
> and sent to Linus post haste.
>
> At least the change in the kunit-next tree will stop this happening in
> the future.
>
Thank you for looking into it.
David, please send a fix in as you suggested earlier. I will apply
it to avoid compile errors.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-03-01 22:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 4:26 linux-next: build failure after merge of the kunit-next tree Stephen Rothwell
2024-02-29 15:07 ` Shuah Khan
2024-03-01 7:15 ` David Gow
2024-03-01 10:43 ` Stephen Rothwell
2024-03-01 16:05 ` Shuah Khan
2024-03-01 20:46 ` Stephen Rothwell
2024-03-01 22:30 ` Shuah Khan [this message]
2024-03-06 15:25 ` Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2025-08-18 2:08 Stephen Rothwell
2025-08-18 16:32 ` Shuah Khan
2025-08-19 7:44 ` David Gow
2025-08-25 6:05 ` Stephen Rothwell
2025-08-26 2:15 ` Shuah Khan
2025-08-26 9:24 ` David Gow
2025-08-27 5:49 ` Shuah Khan
2025-08-27 6:37 ` David Gow
2024-10-04 4:11 Stephen Rothwell
2024-10-04 13:26 ` Gabriela Bittencourt
2024-10-04 18:36 ` Shuah Khan
2024-02-28 2:48 Stephen Rothwell
2024-02-28 3:26 ` Shuah Khan
2020-01-16 5:57 Stephen Rothwell
2020-01-16 11:23 ` Alan Maguire
2020-01-16 23:27 ` Rafael J. Wysocki
2020-01-10 6:43 Stephen Rothwell
2020-01-10 11:56 ` Alan Maguire
2020-01-13 21:11 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0abafb8-65c8-4e54-a410-8a5ac7dccee6@linuxfoundation.org \
--to=skhan@linuxfoundation$(echo .)org \
--cc=airlied@redhat$(echo .)com \
--cc=brendanhiggins@google$(echo .)com \
--cc=christian.koenig@amd$(echo .)com \
--cc=daniel.vetter@ffwll$(echo .)ch \
--cc=davidgow@google$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=matthew.auld@intel$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox