From: Shuah Khan <skhan@linuxfoundation•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Brendan Higgins <brendanhiggins@google•com>,
Daniel Vetter <daniel.vetter@ffwll•ch>
Cc: "Intel Graphics" <intel-gfx@lists•freedesktop.org>,
DRI <dri-devel@lists•freedesktop.org>,
"Christian König" <christian.koenig@amd•com>,
"Matthew Auld" <matthew.auld@intel•com>,
"David Gow" <davidgow@google•com>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Linux Next Mailing List" <linux-next@vger•kernel.org>,
"Shuah Khan" <skhan@linuxfoundation•org>
Subject: Re: linux-next: build failure after merge of the kunit-next tree
Date: Thu, 29 Feb 2024 08:07:10 -0700 [thread overview]
Message-ID: <be2e812c-3898-4be8-8a9d-e221acb837c3@linuxfoundation.org> (raw)
In-Reply-To: <20240229152653.09ecf771@canb.auug.org.au>
Hi Stephen,
On 2/28/24 21:26, Stephen Rothwell wrote:
> Hi all,
>
> After merging the kunit-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from drivers/gpu/drm/tests/drm_buddy_test.c:7:
> drivers/gpu/drm/tests/drm_buddy_test.c: In function 'drm_test_buddy_alloc_range_bias':
> drivers/gpu/drm/tests/drm_buddy_test.c:191:40: error: format '%u' expects a matching 'unsigned int' argument [-Werror=format=]
> 191 | "buddy_alloc failed with bias(%x-%x), size=%u, ps=%u\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:597:37: note: in definition of macro '_KUNIT_FAILED'
> 597 | fmt, \
> | ^~~
> include/kunit/test.h:662:9: note: in expansion of macro 'KUNIT_UNARY_ASSERTION'
> 662 | KUNIT_UNARY_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:1233:9: note: in expansion of macro 'KUNIT_FALSE_MSG_ASSERTION'
> 1233 | KUNIT_FALSE_MSG_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/tests/drm_buddy_test.c:186:17: note: in expansion of macro 'KUNIT_ASSERT_FALSE_MSG'
> 186 | KUNIT_ASSERT_FALSE_MSG(test,
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/tests/drm_buddy_test.c:191:91: note: format string is defined here
> 191 | "buddy_alloc failed with bias(%x-%x), size=%u, ps=%u\n",
> | ~^
> | |
> | unsigned int
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 806cb2270237 ("kunit: Annotate _MSG assertion variants with gnu printf specifiers")
>
Thank you. I did allmodconfig build on kselftest kunit branch to make
sure all is well, before I pushed the commits.
> interacting with commit
>
> c70703320e55 ("drm/tests/drm_buddy: add alloc_range_bias test")
>
> from the drm-misc-fixes tree.
>
> I have applied the following patch for today (this should probably
> actually be fixed in the drm-misc-fixes tree).
>
Danial, David,
I can carry the fix through kselftest kunit if it works
for all.
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Thu, 29 Feb 2024 15:18:36 +1100
> Subject: [PATCH] fix up for "drm/tests/drm_buddy: add alloc_range_bias test"
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> drivers/gpu/drm/tests/drm_buddy_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c
> index 1e73e3f0d278..369edf587b44 100644
> --- a/drivers/gpu/drm/tests/drm_buddy_test.c
> +++ b/drivers/gpu/drm/tests/drm_buddy_test.c
> @@ -188,7 +188,7 @@ static void drm_test_buddy_alloc_range_bias(struct kunit *test)
> bias_end, size, ps,
> &allocated,
> DRM_BUDDY_RANGE_ALLOCATION),
> - "buddy_alloc failed with bias(%x-%x), size=%u, ps=%u\n",
> + "buddy_alloc failed with bias(%x-%x), size=%u\n",
> bias_start, bias_end, size);
> bias_rem -= size;
>
thanks,
-- Shuah
next prev parent reply other threads:[~2024-02-29 15:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 4:26 linux-next: build failure after merge of the kunit-next tree Stephen Rothwell
2024-02-29 15:07 ` Shuah Khan [this message]
2024-03-01 7:15 ` David Gow
2024-03-01 10:43 ` Stephen Rothwell
2024-03-01 16:05 ` Shuah Khan
2024-03-01 20:46 ` Stephen Rothwell
2024-03-01 22:30 ` Shuah Khan
2024-03-06 15:25 ` Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2025-08-18 2:08 Stephen Rothwell
2025-08-18 16:32 ` Shuah Khan
2025-08-19 7:44 ` David Gow
2025-08-25 6:05 ` Stephen Rothwell
2025-08-26 2:15 ` Shuah Khan
2025-08-26 9:24 ` David Gow
2025-08-27 5:49 ` Shuah Khan
2025-08-27 6:37 ` David Gow
2024-10-04 4:11 Stephen Rothwell
2024-10-04 13:26 ` Gabriela Bittencourt
2024-10-04 18:36 ` Shuah Khan
2024-02-28 2:48 Stephen Rothwell
2024-02-28 3:26 ` Shuah Khan
2020-01-16 5:57 Stephen Rothwell
2020-01-16 11:23 ` Alan Maguire
2020-01-16 23:27 ` Rafael J. Wysocki
2020-01-10 6:43 Stephen Rothwell
2020-01-10 11:56 ` Alan Maguire
2020-01-13 21:11 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be2e812c-3898-4be8-8a9d-e221acb837c3@linuxfoundation.org \
--to=skhan@linuxfoundation$(echo .)org \
--cc=brendanhiggins@google$(echo .)com \
--cc=christian.koenig@amd$(echo .)com \
--cc=daniel.vetter@ffwll$(echo .)ch \
--cc=davidgow@google$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=matthew.auld@intel$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox