* linux-next: sound tree build warning
@ 2009-07-08 4:18 Stephen Rothwell
2009-07-08 5:57 ` [PATCH] sound: pci/hda/patch_via.c fix compilation warning Jaswinder Singh Rajput
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2009-07-08 4:18 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
Hi Takashi,
Today's linux-next build (x86_64 allmodconfig) produced these warnings:
sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
sound/pci/hda/patch_via.c: In function 'get_mux_nids':
sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
Introduced by commit 337b9d02b4873ceac91565272545fb6fd446d939 ("ALSA: hda
- Fix capture source selection in patch_via.c").
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] sound: pci/hda/patch_via.c fix compilation warning
2009-07-08 4:18 linux-next: sound tree build warning Stephen Rothwell
@ 2009-07-08 5:57 ` Jaswinder Singh Rajput
2009-07-08 6:00 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Jaswinder Singh Rajput @ 2009-07-08 5:57 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Takashi Iwai, linux-next, linux-kernel
On Wed, 2009-07-08 at 14:18 +1000, Stephen Rothwell wrote:
> Hi Takashi,
>
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
>
> sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
> sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
> sound/pci/hda/patch_via.c: In function 'get_mux_nids':
> sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
> sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
>
> Introduced by commit 337b9d02b4873ceac91565272545fb6fd446d939 ("ALSA: hda
> - Fix capture source selection in patch_via.c").
>
[PATCH] sound: pci/hda/patch_via.c fix compilation warning
sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
sound/pci/hda/patch_via.c: In function 'get_mux_nids':
sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail•com>
---
sound/pci/hda/patch_via.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
index 38db459..d05b718 100644
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -392,7 +392,6 @@ static int via_mux_enum_put(struct snd_kcontrol *kcontrol,
struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
struct via_spec *spec = codec->spec;
unsigned int adc_idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
- unsigned int vendor_id = codec->vendor_id;
if (!spec->mux_nids[adc_idx])
return -EINVAL;
@@ -1330,11 +1329,10 @@ static int via_auto_init(struct hda_codec *codec)
return 0;
}
-static int get_mux_nids(struct hda_codec *codec)
+static void get_mux_nids(struct hda_codec *codec)
{
struct via_spec *spec = codec->spec;
hda_nid_t nid, conn[8];
- unsigned int type;
int i, n;
for (i = 0; i < spec->num_adc_nids; i++) {
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sound: pci/hda/patch_via.c fix compilation warning
2009-07-08 5:57 ` [PATCH] sound: pci/hda/patch_via.c fix compilation warning Jaswinder Singh Rajput
@ 2009-07-08 6:00 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2009-07-08 6:00 UTC (permalink / raw)
To: Jaswinder Singh Rajput; +Cc: Stephen Rothwell, linux-next, linux-kernel
At Wed, 08 Jul 2009 11:27:50 +0530,
Jaswinder Singh Rajput wrote:
>
> On Wed, 2009-07-08 at 14:18 +1000, Stephen Rothwell wrote:
> > Hi Takashi,
> >
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> >
> > sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
> > sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
> > sound/pci/hda/patch_via.c: In function 'get_mux_nids':
> > sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
> > sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
> >
> > Introduced by commit 337b9d02b4873ceac91565272545fb6fd446d939 ("ALSA: hda
> > - Fix capture source selection in patch_via.c").
> >
>
> [PATCH] sound: pci/hda/patch_via.c fix compilation warning
>
> sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
> sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
> sound/pci/hda/patch_via.c: In function 'get_mux_nids':
> sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
> sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
>
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail•com>
It was already fixed a few minutes ago :) Thanks anyway.
Takashi
> ---
> sound/pci/hda/patch_via.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
> index 38db459..d05b718 100644
> --- a/sound/pci/hda/patch_via.c
> +++ b/sound/pci/hda/patch_via.c
> @@ -392,7 +392,6 @@ static int via_mux_enum_put(struct snd_kcontrol *kcontrol,
> struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
> struct via_spec *spec = codec->spec;
> unsigned int adc_idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
> - unsigned int vendor_id = codec->vendor_id;
>
> if (!spec->mux_nids[adc_idx])
> return -EINVAL;
> @@ -1330,11 +1329,10 @@ static int via_auto_init(struct hda_codec *codec)
> return 0;
> }
>
> -static int get_mux_nids(struct hda_codec *codec)
> +static void get_mux_nids(struct hda_codec *codec)
> {
> struct via_spec *spec = codec->spec;
> hda_nid_t nid, conn[8];
> - unsigned int type;
> int i, n;
>
> for (i = 0; i < spec->num_adc_nids; i++) {
> --
> 1.6.0.6
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-08 6:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-08 4:18 linux-next: sound tree build warning Stephen Rothwell
2009-07-08 5:57 ` [PATCH] sound: pci/hda/patch_via.c fix compilation warning Jaswinder Singh Rajput
2009-07-08 6:00 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox