* linux-next: sound tree build warning
@ 2009-07-08 4:18 Stephen Rothwell
2009-07-08 5:57 ` [PATCH] sound: pci/hda/patch_via.c fix compilation warning Jaswinder Singh Rajput
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2009-07-08 4:18 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
Hi Takashi,
Today's linux-next build (x86_64 allmodconfig) produced these warnings:
sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
sound/pci/hda/patch_via.c: In function 'get_mux_nids':
sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
Introduced by commit 337b9d02b4873ceac91565272545fb6fd446d939 ("ALSA: hda
- Fix capture source selection in patch_via.c").
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] sound: pci/hda/patch_via.c fix compilation warning
2009-07-08 4:18 linux-next: sound tree build warning Stephen Rothwell
@ 2009-07-08 5:57 ` Jaswinder Singh Rajput
2009-07-08 6:00 ` Takashi Iwai
0 siblings, 1 reply; 16+ messages in thread
From: Jaswinder Singh Rajput @ 2009-07-08 5:57 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Takashi Iwai, linux-next, linux-kernel
On Wed, 2009-07-08 at 14:18 +1000, Stephen Rothwell wrote:
> Hi Takashi,
>
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
>
> sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
> sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
> sound/pci/hda/patch_via.c: In function 'get_mux_nids':
> sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
> sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
>
> Introduced by commit 337b9d02b4873ceac91565272545fb6fd446d939 ("ALSA: hda
> - Fix capture source selection in patch_via.c").
>
[PATCH] sound: pci/hda/patch_via.c fix compilation warning
sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
sound/pci/hda/patch_via.c: In function 'get_mux_nids':
sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail•com>
---
sound/pci/hda/patch_via.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
index 38db459..d05b718 100644
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -392,7 +392,6 @@ static int via_mux_enum_put(struct snd_kcontrol *kcontrol,
struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
struct via_spec *spec = codec->spec;
unsigned int adc_idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
- unsigned int vendor_id = codec->vendor_id;
if (!spec->mux_nids[adc_idx])
return -EINVAL;
@@ -1330,11 +1329,10 @@ static int via_auto_init(struct hda_codec *codec)
return 0;
}
-static int get_mux_nids(struct hda_codec *codec)
+static void get_mux_nids(struct hda_codec *codec)
{
struct via_spec *spec = codec->spec;
hda_nid_t nid, conn[8];
- unsigned int type;
int i, n;
for (i = 0; i < spec->num_adc_nids; i++) {
--
1.6.0.6
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] sound: pci/hda/patch_via.c fix compilation warning
2009-07-08 5:57 ` [PATCH] sound: pci/hda/patch_via.c fix compilation warning Jaswinder Singh Rajput
@ 2009-07-08 6:00 ` Takashi Iwai
0 siblings, 0 replies; 16+ messages in thread
From: Takashi Iwai @ 2009-07-08 6:00 UTC (permalink / raw)
To: Jaswinder Singh Rajput; +Cc: Stephen Rothwell, linux-next, linux-kernel
At Wed, 08 Jul 2009 11:27:50 +0530,
Jaswinder Singh Rajput wrote:
>
> On Wed, 2009-07-08 at 14:18 +1000, Stephen Rothwell wrote:
> > Hi Takashi,
> >
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> >
> > sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
> > sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
> > sound/pci/hda/patch_via.c: In function 'get_mux_nids':
> > sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
> > sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
> >
> > Introduced by commit 337b9d02b4873ceac91565272545fb6fd446d939 ("ALSA: hda
> > - Fix capture source selection in patch_via.c").
> >
>
> [PATCH] sound: pci/hda/patch_via.c fix compilation warning
>
> sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
> sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
> sound/pci/hda/patch_via.c: In function 'get_mux_nids':
> sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
> sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
>
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail•com>
It was already fixed a few minutes ago :) Thanks anyway.
Takashi
> ---
> sound/pci/hda/patch_via.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
> index 38db459..d05b718 100644
> --- a/sound/pci/hda/patch_via.c
> +++ b/sound/pci/hda/patch_via.c
> @@ -392,7 +392,6 @@ static int via_mux_enum_put(struct snd_kcontrol *kcontrol,
> struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
> struct via_spec *spec = codec->spec;
> unsigned int adc_idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
> - unsigned int vendor_id = codec->vendor_id;
>
> if (!spec->mux_nids[adc_idx])
> return -EINVAL;
> @@ -1330,11 +1329,10 @@ static int via_auto_init(struct hda_codec *codec)
> return 0;
> }
>
> -static int get_mux_nids(struct hda_codec *codec)
> +static void get_mux_nids(struct hda_codec *codec)
> {
> struct via_spec *spec = codec->spec;
> hda_nid_t nid, conn[8];
> - unsigned int type;
> int i, n;
>
> for (i = 0; i < spec->num_adc_nids; i++) {
> --
> 1.6.0.6
>
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: sound tree build warning
@ 2009-07-15 3:13 Stephen Rothwell
2009-07-15 8:35 ` Mark Brown
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2009-07-15 3:13 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Mark Brown
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
Hi Takashi,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
sound/soc/codecs/wm8993.c: In function 'wm8993_hw_params':
sound/soc/codecs/wm8993.c:1799: warning: array subscript is above array bounds
Introduced by commit 942c435ba79fd263a922bb114d56eccab6250662 ("ASoC: Add
WM8993 CODEC driver").
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: sound tree build warning
2009-07-15 3:13 linux-next: sound tree build warning Stephen Rothwell
@ 2009-07-15 8:35 ` Mark Brown
2009-07-15 9:09 ` Takashi Iwai
0 siblings, 1 reply; 16+ messages in thread
From: Mark Brown @ 2009-07-15 8:35 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Takashi Iwai, linux-next, linux-kernel
On Wed, Jul 15, 2009 at 01:13:54PM +1000, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
That's one of the configurations I regularly test build but I've not
seen this - which compiler are you using? Might be worth reporting that
along with warnings.
> sound/soc/codecs/wm8993.c: In function 'wm8993_hw_params':
> sound/soc/codecs/wm8993.c:1799: warning: array subscript is above array bounds
Fixed, though Takashi seems to be away at the minute so it'll not appear
in -next until he reappears.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: sound tree build warning
2009-07-15 8:35 ` Mark Brown
@ 2009-07-15 9:09 ` Takashi Iwai
2009-07-15 9:12 ` Mark Brown
0 siblings, 1 reply; 16+ messages in thread
From: Takashi Iwai @ 2009-07-15 9:09 UTC (permalink / raw)
To: Mark Brown; +Cc: Stephen Rothwell, linux-next, linux-kernel
At Wed, 15 Jul 2009 09:35:21 +0100,
Mark Brown wrote:
>
> On Wed, Jul 15, 2009 at 01:13:54PM +1000, Stephen Rothwell wrote:
>
> > Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> That's one of the configurations I regularly test build but I've not
> seen this - which compiler are you using? Might be worth reporting that
> along with warnings.
>
> > sound/soc/codecs/wm8993.c: In function 'wm8993_hw_params':
> > sound/soc/codecs/wm8993.c:1799: warning: array subscript is above array bounds
>
> Fixed, though Takashi seems to be away at the minute so it'll not appear
> in -next until he reappears.
I'm back now and pulled your trees. The tomorrow's next tree should
be fine.
thanks,
Takashi
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: sound tree build warning
2009-07-15 9:09 ` Takashi Iwai
@ 2009-07-15 9:12 ` Mark Brown
0 siblings, 0 replies; 16+ messages in thread
From: Mark Brown @ 2009-07-15 9:12 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Stephen Rothwell, linux-next, linux-kernel
On Wed, Jul 15, 2009 at 11:09:18AM +0200, Takashi Iwai wrote:
> At Wed, 15 Jul 2009 09:35:21 +0100,
> Mark Brown wrote:
> > Fixed, though Takashi seems to be away at the minute so it'll not appear
> > in -next until he reappears.
> I'm back now and pulled your trees. The tomorrow's next tree should
> be fine.
Ah, excellent - I'll send a pull request for the fix later this morning.
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: sound tree build warning
@ 2009-08-10 4:15 Stephen Rothwell
2009-08-10 7:34 ` Takashi Iwai
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2009-08-10 4:15 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Mark Brown
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
Hi Takashi,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
sound/soc/codecs/wm8731.c:44: warning: 'wm8731_spi_write' declared 'static' but never defined
Introduced by commit 27ded041f03026e8c6be9efc626e11ddfb4620c1 ("ASoC:
Factor out 7 bit register 9 bit data SPI write").
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: sound tree build warning
2009-08-10 4:15 Stephen Rothwell
@ 2009-08-10 7:34 ` Takashi Iwai
2009-08-10 18:43 ` Mark Brown
0 siblings, 1 reply; 16+ messages in thread
From: Takashi Iwai @ 2009-08-10 7:34 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-next, linux-kernel, Stephen Rothwell
At Mon, 10 Aug 2009 14:15:18 +1000,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> sound/soc/codecs/wm8731.c:44: warning: 'wm8731_spi_write' declared 'static' but never defined
>
> Introduced by commit 27ded041f03026e8c6be9efc626e11ddfb4620c1 ("ASoC:
> Factor out 7 bit register 9 bit data SPI write").
Looks like a forgotten piece since the reg-cache branch merge.
Mark, could you clean up?
thanks,
Takashi
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: sound tree build warning
2009-08-10 7:34 ` Takashi Iwai
@ 2009-08-10 18:43 ` Mark Brown
0 siblings, 0 replies; 16+ messages in thread
From: Mark Brown @ 2009-08-10 18:43 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Stephen Rothwell
On Mon, Aug 10, 2009 at 09:34:49AM +0200, Takashi Iwai wrote:
> Looks like a forgotten piece since the reg-cache branch merge.
> Mark, could you clean up?
The changes I pushed earlier today did so.
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: sound tree build warning
@ 2009-08-11 3:22 Stephen Rothwell
2009-08-11 6:17 ` Takashi Iwai
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2009-08-11 3:22 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Clemens Ladisch
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
Hi Takashi,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
sound/usb/usbaudio.c: In function 'init_substream_urbs':
sound/usb/usbaudio.c:1087: warning: comparison of distinct pointer types lacks a cast
Introduced by commit 765e8db078e63fdc076fcf6024c15d3b7b955746 ("sound:
usb-audio: do not make URBs longer than sync packet interval").
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: sound tree build warning
2009-08-11 3:22 Stephen Rothwell
@ 2009-08-11 6:17 ` Takashi Iwai
2009-08-11 6:21 ` Stephen Rothwell
0 siblings, 1 reply; 16+ messages in thread
From: Takashi Iwai @ 2009-08-11 6:17 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Clemens Ladisch
At Tue, 11 Aug 2009 13:22:58 +1000,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> sound/usb/usbaudio.c: In function 'init_substream_urbs':
> sound/usb/usbaudio.c:1087: warning: comparison of distinct pointer types lacks a cast
>
> Introduced by commit 765e8db078e63fdc076fcf6024c15d3b7b955746 ("sound:
> usb-audio: do not make URBs longer than sync packet interval").
Thanks, fixed now on sound git tree with the patch below.
Takashi
---
diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c
index fa3f7a1..5149c58 100644
--- a/sound/usb/usbaudio.c
+++ b/sound/usb/usbaudio.c
@@ -1084,7 +1084,7 @@ static int init_substream_urbs(struct snd_usb_substream *subs, unsigned int peri
urb_packs = 1;
urb_packs *= packs_per_ms;
if (subs->syncpipe)
- urb_packs = min(urb_packs, 1 << subs->syncinterval);
+ urb_packs = min(urb_packs, 1U << subs->syncinterval);
/* decide how many packets to be used */
if (is_playback) {
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: linux-next: sound tree build warning
2009-08-11 6:17 ` Takashi Iwai
@ 2009-08-11 6:21 ` Stephen Rothwell
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2009-08-11 6:21 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Clemens Ladisch
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
Hi Takashi,
On Tue, 11 Aug 2009 08:17:35 +0200 Takashi Iwai <tiwai@suse•de> wrote:
>
> Thanks, fixed now on sound git tree with the patch below.
Thanks.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: sound tree build warning
@ 2009-08-12 1:13 Stephen Rothwell
2009-08-12 5:58 ` Takashi Iwai
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2009-08-12 1:13 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Daniel Ribeiro, Mark Brown
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
Hi Takashi,
Today's linux-next build (x86_64 allmodconfig) produced this warning:
sound/soc/codecs/ad1938.c:458: warning: initialization from incompatible pointer type
Introduced by commit a5479e389e989acfeca9c32eeb0083d086202280 ("ASoC:
change set_tdm_slot api to allow slot_width override").
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: sound tree build warning
2009-08-12 1:13 Stephen Rothwell
@ 2009-08-12 5:58 ` Takashi Iwai
2009-08-12 13:33 ` Mark Brown
0 siblings, 1 reply; 16+ messages in thread
From: Takashi Iwai @ 2009-08-12 5:58 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, Daniel Ribeiro, Mark Brown, Barry Song
At Wed, 12 Aug 2009 11:13:49 +1000,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> sound/soc/codecs/ad1938.c:458: warning: initialization from incompatible pointer type
>
> Introduced by commit a5479e389e989acfeca9c32eeb0083d086202280 ("ASoC:
> change set_tdm_slot api to allow slot_width override").
Hrm, sorry, I overlooked warnings...
Obviously ad1938.c was missing in the change above.
Mark, could you care?
thanks,
Takashi
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: sound tree build warning
2009-08-12 5:58 ` Takashi Iwai
@ 2009-08-12 13:33 ` Mark Brown
0 siblings, 0 replies; 16+ messages in thread
From: Mark Brown @ 2009-08-12 13:33 UTC (permalink / raw)
To: Takashi Iwai
Cc: Stephen Rothwell, linux-next, linux-kernel, Daniel Ribeiro,
Barry Song
On Wed, Aug 12, 2009 at 07:58:23AM +0200, Takashi Iwai wrote:
> Mark, could you care?
Updated, will send a pull request later today.
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2009-08-12 13:33 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-08 4:18 linux-next: sound tree build warning Stephen Rothwell
2009-07-08 5:57 ` [PATCH] sound: pci/hda/patch_via.c fix compilation warning Jaswinder Singh Rajput
2009-07-08 6:00 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2009-07-15 3:13 linux-next: sound tree build warning Stephen Rothwell
2009-07-15 8:35 ` Mark Brown
2009-07-15 9:09 ` Takashi Iwai
2009-07-15 9:12 ` Mark Brown
2009-08-10 4:15 Stephen Rothwell
2009-08-10 7:34 ` Takashi Iwai
2009-08-10 18:43 ` Mark Brown
2009-08-11 3:22 Stephen Rothwell
2009-08-11 6:17 ` Takashi Iwai
2009-08-11 6:21 ` Stephen Rothwell
2009-08-12 1:13 Stephen Rothwell
2009-08-12 5:58 ` Takashi Iwai
2009-08-12 13:33 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox