From: Michael Ellerman <michael@ellerman•id.au>
To: Linas Vepstas <linas@austin•ibm.com>
Cc: srinivasa@in•ibm.com, ego@in•ibm.com, linuxppc-dev@ozlabs•org,
paulus@samba•org, Anton Blanchard <anton@samba•org>,
ntl@pobox•com
Subject: Re: [PATCH] Reorganise and then fixup the pseries cpu hotplug code
Date: Mon, 20 Nov 2006 12:08:34 +1100 [thread overview]
Message-ID: <1163984914.7832.16.camel@localhost.localdomain> (raw)
In-Reply-To: <20061117180456.GG23600@austin.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1779 bytes --]
On Fri, 2006-11-17 at 12:04 -0600, Linas Vepstas wrote:
> On Fri, Nov 17, 2006 at 02:36:35PM +1100, Michael Ellerman wrote:
> > The pseries cpu hotplug code is currently spread between ./kernel/rtas.c,
> > ./platforms/pseries/smp.c and ./platforms/pseries/setup.c. Some of it is
> > not #ifdef CONFIG_HOTPLUG_CPU, but it should be.
> >
> > So move all the cpu hotplug code into platforms/pseries/hotplug-cpu.c
>
> Yes, much cleaner this way.
I agree :)
> > + /* Isolation and deallocation are definatly done by
> ^^^^^^^^^
> typo
>
> > + * drslot_chrp_cpu. If they were not they would be
> > + * done here. Change isolate state to Isolate and
> > + * change allocation-state to Unusable.
> > + */
> > + paca[cpu].cpu_start = 0;
>
> I can't figure out what the comment means with respect
> to this code ...
Me either. It's unchanged from the original merge of cpu hotplug:
http://kernel.org/git/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=commit;h=24c13f21f0a6abe07020a959990da2b134e6734f
http://kernel.org/git/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=blobdiff;h=72144b6122f9336e7fa242e50b65b099df0cd72b;hp=f671515c0676e61064ae414273fa4546d0c04938;hb=24c13f21f0a6abe07020a959990da2b134e6734f;f=arch/ppc64/kernel/smp.c
Which carries the name of one Joel Schopp :)
Grepping the tree at that point finds no other mention of
drslot_chrp_cpu, so I think it's a stale comment - we should probably
just rip it out - Joel?
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-11-20 1:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 14:39 [RFC] [PATCH] cpu hotplug on power based systems Srinivasa Ds
2006-11-16 15:40 ` Nathan Lynch
2006-11-16 21:02 ` Linas Vepstas
2006-11-17 3:36 ` [PATCH] Reorganise and then fixup the pseries cpu hotplug code Michael Ellerman
2006-11-17 3:59 ` Michael Ellerman
2006-11-17 4:31 ` Stephen Rothwell
2006-11-17 4:44 ` Michael Ellerman
2006-11-17 5:02 ` Stephen Rothwell
2006-11-17 18:11 ` Linas Vepstas
2006-11-20 0:44 ` Michael Ellerman
2006-11-17 18:04 ` Linas Vepstas
2006-11-20 1:08 ` Michael Ellerman [this message]
2006-11-20 4:22 ` jschopp
2006-11-20 5:59 ` Michael Ellerman
2006-11-21 16:43 ` Nathan Lynch
-- strict thread matches above, loose matches on Subject: below --
2006-11-23 2:11 Michael Ellerman
2006-11-24 11:03 ` Srinivasa Ds
2006-11-27 8:13 ` Srinivasa Ds
2006-11-27 21:10 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163984914.7832.16.camel@localhost.localdomain \
--to=michael@ellerman$(echo .)id.au \
--cc=anton@samba$(echo .)org \
--cc=ego@in$(echo .)ibm.com \
--cc=linas@austin$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=ntl@pobox$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=srinivasa@in$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox