From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Michael Ellerman <michael@ellerman•id.au>
Cc: ego@in•ibm.com, linuxppc-dev@ozlabs•org, srinivasa@in•ibm.com,
Anton Blanchard <anton@samba•org>,
ntl@pobox•com, paulus@samba•org
Subject: Re: [PATCH] Reorganise and then fixup the pseries cpu hotplug code
Date: Fri, 17 Nov 2006 15:31:05 +1100 [thread overview]
Message-ID: <20061117153105.edca0777.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20061117033638.0E24B67BCE@ozlabs.org>
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
One small nit ...
On Fri, 17 Nov 2006 14:36:35 +1100 Michael Ellerman <michael@ellerman•id.au> wrote:
>
> +static int __init pseries_cpu_hotplug_init(void)
> +{
> + rtas_stop_self_args.token = rtas_token("stop-self");
> + qcss_tok = rtas_token("query-cpu-stopped-state");
> +
> + if (rtas_stop_self_args.token == RTAS_UNKNOWN_SERVICE ||
> + qcss_tok == RTAS_UNKNOWN_SERVICE)
> + return 1;
initcall fucntions should return 0 or -<error>; -ENODEV is ignored,
other nonzero values cause a log message if initcall debugging is enabled.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-11-17 4:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 14:39 [RFC] [PATCH] cpu hotplug on power based systems Srinivasa Ds
2006-11-16 15:40 ` Nathan Lynch
2006-11-16 21:02 ` Linas Vepstas
2006-11-17 3:36 ` [PATCH] Reorganise and then fixup the pseries cpu hotplug code Michael Ellerman
2006-11-17 3:59 ` Michael Ellerman
2006-11-17 4:31 ` Stephen Rothwell [this message]
2006-11-17 4:44 ` Michael Ellerman
2006-11-17 5:02 ` Stephen Rothwell
2006-11-17 18:11 ` Linas Vepstas
2006-11-20 0:44 ` Michael Ellerman
2006-11-17 18:04 ` Linas Vepstas
2006-11-20 1:08 ` Michael Ellerman
2006-11-20 4:22 ` jschopp
2006-11-20 5:59 ` Michael Ellerman
2006-11-21 16:43 ` Nathan Lynch
-- strict thread matches above, loose matches on Subject: below --
2006-11-23 2:11 Michael Ellerman
2006-11-24 11:03 ` Srinivasa Ds
2006-11-27 8:13 ` Srinivasa Ds
2006-11-27 21:10 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061117153105.edca0777.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=anton@samba$(echo .)org \
--cc=ego@in$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael@ellerman$(echo .)id.au \
--cc=ntl@pobox$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=srinivasa@in$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox