From: Srinivasa Ds <srinivasa@in•ibm.com>
To: Michael Ellerman <michael@ellerman•id.au>
Cc: ego@in•ibm.com, linuxppc-dev@ozlabs•org,
Paul Mackerras <paulus@samba•org>,
Anton Blanchard <anton@samba•org>,
ntl@pobox•com, linas@boardhead•austin.ibm.com
Subject: Re: [PATCH] Reorganise and then fixup the pseries cpu hotplug code
Date: Mon, 27 Nov 2006 13:43:30 +0530 [thread overview]
Message-ID: <456A9E2A.7030606@in.ibm.com> (raw)
In-Reply-To: <20061123021132.B03F767C18@ozlabs.org>
Michael Ellerman wrote:
> Currently we unconditionally hookup pSeries_mach_cpu_die to ppc_md.cpu_die,
> even if we don't have CONFIG_HOTPLUG_CPU enabled. This is wrong, as it
> signals the sysfs code to create the online attribute for cpu nodes,
> allowing the user to attempt an offline when it's not actually supported.
>
> There is also a problem on systems that don't have the correct RTAS tokens
> available to do RTAS-based cpu hotplug, we still indicate via sysfs that
> we support cpu hotplug - and then attempt to do so with missing RTAS tokens.
>
> Both problems are solved by conditionally registering the cpu hotplug
> callbacks, only when CONFIG_HOTPLUG_CPU is enabled, and only after we've
> found the requisite RTAS tokens.
>
> Signed-off-by: Michael Ellerman <michael@ellerman•id.au>
> ---
>
> Updated to printk if we can't find the RTAS tokens, and to remove the
> comment about drslot_chrp_cpu etc.
>
> Linas, Srinivasa, can you test that this addresses the problems you
> were seeing. It should, but it'd be good if you could test it.
>
I tested your patch,it works fine. I didn't see "online" file on my JS20
system.
Thanks
Srinivasa DS
Linux technology centre
IBM-ISL Bangalore
> cheers
>
>
next prev parent reply other threads:[~2006-11-27 6:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-23 2:11 [PATCH] Reorganise and then fixup the pseries cpu hotplug code Michael Ellerman
2006-11-24 11:03 ` Srinivasa Ds
2006-11-27 8:13 ` Srinivasa Ds [this message]
2006-11-27 21:10 ` Linas Vepstas
-- strict thread matches above, loose matches on Subject: below --
2006-11-16 15:40 [RFC] [PATCH] cpu hotplug on power based systems Nathan Lynch
2006-11-17 3:36 ` [PATCH] Reorganise and then fixup the pseries cpu hotplug code Michael Ellerman
2006-11-17 3:59 ` Michael Ellerman
2006-11-17 4:31 ` Stephen Rothwell
2006-11-17 4:44 ` Michael Ellerman
2006-11-17 5:02 ` Stephen Rothwell
2006-11-17 18:11 ` Linas Vepstas
2006-11-20 0:44 ` Michael Ellerman
2006-11-17 18:04 ` Linas Vepstas
2006-11-20 1:08 ` Michael Ellerman
2006-11-20 4:22 ` jschopp
2006-11-20 5:59 ` Michael Ellerman
2006-11-21 16:43 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456A9E2A.7030606@in.ibm.com \
--to=srinivasa@in$(echo .)ibm.com \
--cc=anton@samba$(echo .)org \
--cc=ego@in$(echo .)ibm.com \
--cc=linas@boardhead$(echo .)austin.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael@ellerman$(echo .)id.au \
--cc=ntl@pobox$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox