* Broken CONFIG_HIGHPTE
@ 2009-04-01 5:38 Benjamin Herrenschmidt
2009-04-01 13:25 ` Kumar Gala
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2009-04-01 5:38 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev list
Hi !
Just noticed... And I'll be travelling for a while so with no much
time to look at it.
Your changes to use the PTE page free batch via RCU on ppc32 broke
CONFIG_HIGHPTE for hash32...
You rely on passing a page_address() of the PTE page down to the
freeing layer. That doesn't work for highmem pages. That needs to
be changes to a struct page * on 32-bit (not on 64-bit where we
are using slabs though)
Cheers,
Ben.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Broken CONFIG_HIGHPTE
2009-04-01 5:38 Broken CONFIG_HIGHPTE Benjamin Herrenschmidt
@ 2009-04-01 13:25 ` Kumar Gala
0 siblings, 0 replies; 2+ messages in thread
From: Kumar Gala @ 2009-04-01 13:25 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev list
On Apr 1, 2009, at 12:38 AM, Benjamin Herrenschmidt wrote:
> Hi !
>
> Just noticed... And I'll be travelling for a while so with no much
> time to look at it.
>
> Your changes to use the PTE page free batch via RCU on ppc32 broke
> CONFIG_HIGHPTE for hash32...
>
> You rely on passing a page_address() of the PTE page down to the
> freeing layer. That doesn't work for highmem pages. That needs to
> be changes to a struct page * on 32-bit (not on 64-bit where we
> are using slabs though)
I can look into this, how does this show up?
- k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-01 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-01 5:38 Broken CONFIG_HIGHPTE Benjamin Herrenschmidt
2009-04-01 13:25 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox