From: Olof Johansson <olof@lixom•net>
To: John Rigby <jrigby@freescale•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 3/7] Basic Freescale MPC512x support
Date: Tue, 8 Jan 2008 11:40:38 -0600 [thread overview]
Message-ID: <20080108174038.GA20819@lixom.net> (raw)
In-Reply-To: <1199808093-15929-4-git-send-email-jrigby@freescale.com>
Hi,
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 66a3d8c..81c3f05 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -470,7 +470,7 @@ config PCI
> bool "PCI support" if 40x || CPM2 || PPC_83xx || PPC_85xx || PPC_86xx \
> || PPC_MPC52xx || (EMBEDDED && (PPC_PSERIES || PPC_ISERIES)) \
> || PPC_PS3
> - default y if !40x && !CPM2 && !8xx && !PPC_83xx \
> + default y if !40x && !CPM2 && !8xx && !PPC_512x && !PPC_83xx \
> && !PPC_85xx && !PPC_86xx
This is getting out of control. Not a comment to this specific patch,
but it's getting silly.
Btw, why no PCI by default on this platform when it seemingly is default
on 5200? I thought they were fairly similar.
> diff --git a/arch/powerpc/platforms/512x/Kconfig b/arch/powerpc/platforms/512x/Kconfig
> new file mode 100644
> index 0000000..399d279
> --- /dev/null
> +++ b/arch/powerpc/platforms/512x/Kconfig
> @@ -0,0 +1,20 @@
> +menu "Platform support"
> + depends on PPC_512x
> +
> +choice
> + prompt "Machine Type"
> + default MPC5121_ADS
> +
> +config MPC5121_ADS
> + bool "Freescale MPC5121E ADS"
> + select DEFAULT_UIMAGE
> + help
> + This option enables support for the MPC5121E ADS board.
> +
> +endchoice
For new platforms it makes more sense to make it possible to build
multiplatform kernels instead of using 'choice'.
I know some embedded board guys prefer to build a custom kernel for just
their board (since it means extra revenue for them to spin a kernel
for every customer), but it's still convenient to be able to build
multiplatform kernels. Especially since there's some companies out there
with intent to make end-user products with this cpu.
> @@ -0,0 +1,90 @@
> +#include <asm/system.h>
> +#include <asm/atomic.h>
> +#include <asm/machdep.h>
> +#include <asm/ipic.h>
> +#include <asm/prom.h>
> +#include <asm/time.h>
> +#include <asm/of_platform.h>
Stephen will tell you to include linux/of_platform.h instead. :-)
> @@ -229,7 +229,7 @@ config NR_CPUS
>
> config NOT_COHERENT_CACHE
> bool
> - depends on 4xx || 8xx || E200
> + depends on 4xx || 8xx || E200 || PPC_512x
> default y
Why do you need this, when 5200 doesn't?
-Olof
next prev parent reply other threads:[~2008-01-08 17:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 16:01 [PATCH 0/7] mpc5121 support John Rigby
2008-01-08 16:01 ` [PATCH 1/7] mpc5121: Add IPIC config option John Rigby
2008-01-08 16:01 ` [PATCH 2/7] Add mpc512x ipic support John Rigby
2008-01-08 16:01 ` [PATCH 3/7] Basic Freescale MPC512x support John Rigby
2008-01-08 16:01 ` [PATCH 4/7] Device tree for MPC5121 ADS John Rigby
2008-01-08 16:01 ` [PATCH 5/7] Separate MPC52xx PSC FIFO registers from rest of PSC John Rigby
2008-01-08 16:01 ` [PATCH 6/7] Add mpc512x_find_ips_freq John Rigby
2008-01-08 16:01 ` [PATCH 7/7] Add MPC512x PSC serial driver John Rigby
2008-01-08 17:32 ` Grant Likely
2008-01-08 17:47 ` John Rigby
2008-01-08 20:16 ` Grant Likely
2008-01-09 3:16 ` Stephen Rothwell
2008-01-09 6:06 ` Stephen Rothwell
2008-01-08 17:27 ` [PATCH 6/7] Add mpc512x_find_ips_freq Grant Likely
2008-01-08 18:15 ` Arnd Bergmann
2008-01-08 17:26 ` [PATCH 5/7] Separate MPC52xx PSC FIFO registers from rest of PSC Grant Likely
2008-01-08 17:25 ` [PATCH 4/7] Device tree for MPC5121 ADS Grant Likely
2008-01-08 19:22 ` Scott Wood
2008-01-10 2:18 ` David Gibson
2008-01-08 17:19 ` [PATCH 3/7] Basic Freescale MPC512x support Grant Likely
2008-01-08 17:55 ` Scott Wood
2008-01-08 17:56 ` Grant Likely
2008-01-08 19:25 ` Scott Wood
2008-01-08 20:37 ` Generic desktop/server/laptop lable is confusing [Was Re: [PATCH 3/7] Basic Freescale MPC512x support] John Rigby
2008-01-08 21:40 ` Grant Likely
2008-01-08 21:46 ` Scott Wood
2008-01-08 17:40 ` Olof Johansson [this message]
2008-01-08 17:44 ` [PATCH 3/7] Basic Freescale MPC512x support Jon Loeliger
2008-01-08 18:01 ` John Rigby
2008-01-08 18:13 ` Arnd Bergmann
2008-01-08 18:16 ` John Rigby
2008-01-08 18:07 ` Arnd Bergmann
2008-01-08 18:25 ` John Rigby
2008-01-09 2:36 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108174038.GA20819@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=jrigby@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox