From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: Olof Johansson <olof@lixom•net>, John Rigby <jrigby@freescale•com>
Subject: Re: [PATCH 3/7] Basic Freescale MPC512x support
Date: Tue, 8 Jan 2008 19:13:22 +0100 [thread overview]
Message-ID: <200801081913.23475.arnd@arndb.de> (raw)
In-Reply-To: <20080108174038.GA20819@lixom.net>
On Tuesday 08 January 2008, Olof Johansson wrote:
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > index 66a3d8c..81c3f05 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -470,7 +470,7 @@ config PCI
> > =A0=A0=A0=A0=A0=A0bool "PCI support" if 40x || CPM2 || PPC_83xx || PPC_=
85xx || PPC_86xx \
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0|| PPC_MPC52xx || (EMBEDDED &=
& (PPC_PSERIES || PPC_ISERIES)) \
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0|| PPC_PS3
> > -=A0=A0=A0=A0=A0default y if !40x && !CPM2 && !8xx && !PPC_83xx \
> > +=A0=A0=A0=A0=A0default y if !40x && !CPM2 && !8xx && !PPC_512x && !PPC=
_83xx \
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0&& !PPC_85xx && !PPC_86xx
>=20
> This is getting out of control. Not a comment to this specific patch,
> but it's getting silly.
>=20
> Btw, why no PCI by default on this platform when it seemingly is default
> on 5200? I thought they were fairly similar.
>=20
Just an idea how to restructure this, you could have
config PCI_POSSIBLE
bool
help
select this from your platform if it can support PCI.
config PCI_DEFAULT
bool
select
help
select this from your platform if you want PCI on by default
config PCI
bool "PCI support"
depends on PCI_POSSIBLE || PCI_DEFAULT
default PCI_DEFAULT
config 40x
# there could be PCI, but normally there isn't
select PCI_POSSIBLE
=09
config PPC_83xx=20
# PCI is normally wanted on 83xx, but you can disable it
select PCI_DEFAULT
config CHRP
# CHRP can only be built correctly when PCI is enabled
select PCI
Arnd <><
next prev parent reply other threads:[~2008-01-08 18:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 16:01 [PATCH 0/7] mpc5121 support John Rigby
2008-01-08 16:01 ` [PATCH 1/7] mpc5121: Add IPIC config option John Rigby
2008-01-08 16:01 ` [PATCH 2/7] Add mpc512x ipic support John Rigby
2008-01-08 16:01 ` [PATCH 3/7] Basic Freescale MPC512x support John Rigby
2008-01-08 16:01 ` [PATCH 4/7] Device tree for MPC5121 ADS John Rigby
2008-01-08 16:01 ` [PATCH 5/7] Separate MPC52xx PSC FIFO registers from rest of PSC John Rigby
2008-01-08 16:01 ` [PATCH 6/7] Add mpc512x_find_ips_freq John Rigby
2008-01-08 16:01 ` [PATCH 7/7] Add MPC512x PSC serial driver John Rigby
2008-01-08 17:32 ` Grant Likely
2008-01-08 17:47 ` John Rigby
2008-01-08 20:16 ` Grant Likely
2008-01-09 3:16 ` Stephen Rothwell
2008-01-09 6:06 ` Stephen Rothwell
2008-01-08 17:27 ` [PATCH 6/7] Add mpc512x_find_ips_freq Grant Likely
2008-01-08 18:15 ` Arnd Bergmann
2008-01-08 17:26 ` [PATCH 5/7] Separate MPC52xx PSC FIFO registers from rest of PSC Grant Likely
2008-01-08 17:25 ` [PATCH 4/7] Device tree for MPC5121 ADS Grant Likely
2008-01-08 19:22 ` Scott Wood
2008-01-10 2:18 ` David Gibson
2008-01-08 17:19 ` [PATCH 3/7] Basic Freescale MPC512x support Grant Likely
2008-01-08 17:55 ` Scott Wood
2008-01-08 17:56 ` Grant Likely
2008-01-08 19:25 ` Scott Wood
2008-01-08 20:37 ` Generic desktop/server/laptop lable is confusing [Was Re: [PATCH 3/7] Basic Freescale MPC512x support] John Rigby
2008-01-08 21:40 ` Grant Likely
2008-01-08 21:46 ` Scott Wood
2008-01-08 17:40 ` [PATCH 3/7] Basic Freescale MPC512x support Olof Johansson
2008-01-08 17:44 ` Jon Loeliger
2008-01-08 18:01 ` John Rigby
2008-01-08 18:13 ` Arnd Bergmann [this message]
2008-01-08 18:16 ` John Rigby
2008-01-08 18:07 ` Arnd Bergmann
2008-01-08 18:25 ` John Rigby
2008-01-09 2:36 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801081913.23475.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=jrigby@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olof@lixom$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox