From: Scott Wood <scottwood@freescale•com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: linuxppc-dev@ozlabs•org, John Rigby <jrigby@freescale•com>
Subject: Re: [PATCH 3/7] Basic Freescale MPC512x support
Date: Tue, 8 Jan 2008 13:25:31 -0600 [thread overview]
Message-ID: <20080108192531.GB5296@loki.buserror.net> (raw)
In-Reply-To: <fa686aa40801080956n20f31a54xe02328a139ac3a3b@mail.gmail.com>
On Tue, Jan 08, 2008 at 10:56:41AM -0700, Grant Likely wrote:
> On 1/8/08, Scott Wood <scottwood@freescale•com> wrote:
> > On Tue, Jan 08, 2008 at 10:19:20AM -0700, Grant Likely wrote:
> > > > +config MPC5121_ADS
> > > > + bool "Freescale MPC5121E ADS"
> > > > + select DEFAULT_UIMAGE
> > > > + help
> > > > + This option enables support for the MPC5121E ADS board.
> > >
> > > Make this depend on PPC_MULTIPLATFORM and PPC32
> >
> > I don't think PPC_MULTIPLATFORM is appropriate here... it seems to be
> > OF-specific.
>
> 52xx is multiplatform.
"multiplatform" and "PPC_MULTIPLATFORM" are not the same. The config option
is misnamed.
> It works well on both OF and non-OF boards.
It may work, but it pulls in code like prom_init.c that is not needed on
non-OF boards. It's also quite confusing to have an embedded board's
checkbox only show up when you say yes to "Generic desktop/server/laptop".
-Scott
next prev parent reply other threads:[~2008-01-08 19:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 16:01 [PATCH 0/7] mpc5121 support John Rigby
2008-01-08 16:01 ` [PATCH 1/7] mpc5121: Add IPIC config option John Rigby
2008-01-08 16:01 ` [PATCH 2/7] Add mpc512x ipic support John Rigby
2008-01-08 16:01 ` [PATCH 3/7] Basic Freescale MPC512x support John Rigby
2008-01-08 16:01 ` [PATCH 4/7] Device tree for MPC5121 ADS John Rigby
2008-01-08 16:01 ` [PATCH 5/7] Separate MPC52xx PSC FIFO registers from rest of PSC John Rigby
2008-01-08 16:01 ` [PATCH 6/7] Add mpc512x_find_ips_freq John Rigby
2008-01-08 16:01 ` [PATCH 7/7] Add MPC512x PSC serial driver John Rigby
2008-01-08 17:32 ` Grant Likely
2008-01-08 17:47 ` John Rigby
2008-01-08 20:16 ` Grant Likely
2008-01-09 3:16 ` Stephen Rothwell
2008-01-09 6:06 ` Stephen Rothwell
2008-01-08 17:27 ` [PATCH 6/7] Add mpc512x_find_ips_freq Grant Likely
2008-01-08 18:15 ` Arnd Bergmann
2008-01-08 17:26 ` [PATCH 5/7] Separate MPC52xx PSC FIFO registers from rest of PSC Grant Likely
2008-01-08 17:25 ` [PATCH 4/7] Device tree for MPC5121 ADS Grant Likely
2008-01-08 19:22 ` Scott Wood
2008-01-10 2:18 ` David Gibson
2008-01-08 17:19 ` [PATCH 3/7] Basic Freescale MPC512x support Grant Likely
2008-01-08 17:55 ` Scott Wood
2008-01-08 17:56 ` Grant Likely
2008-01-08 19:25 ` Scott Wood [this message]
2008-01-08 20:37 ` Generic desktop/server/laptop lable is confusing [Was Re: [PATCH 3/7] Basic Freescale MPC512x support] John Rigby
2008-01-08 21:40 ` Grant Likely
2008-01-08 21:46 ` Scott Wood
2008-01-08 17:40 ` [PATCH 3/7] Basic Freescale MPC512x support Olof Johansson
2008-01-08 17:44 ` Jon Loeliger
2008-01-08 18:01 ` John Rigby
2008-01-08 18:13 ` Arnd Bergmann
2008-01-08 18:16 ` John Rigby
2008-01-08 18:07 ` Arnd Bergmann
2008-01-08 18:25 ` John Rigby
2008-01-09 2:36 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108192531.GB5296@loki.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=jrigby@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox