* [PATCH 1/2] qe_lib: qe_issue_cmd writes wrong value to CECDR
@ 2006-10-31 9:53 Li Yang
0 siblings, 0 replies; only message in thread
From: Li Yang @ 2006-10-31 9:53 UTC (permalink / raw)
To: Paul; +Cc: linuxppc-dev
From: Timur Tabi <timur@freescale•com>
Changed qe_issue_cmd() to write cmd_input to the CECDR unmodified. It
was treating cmd_input as a virtual address and tried to convert it to
a physical address.
Signed-off-by: Timur Tabi <timur@freescale•com>
---
diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
index 2bae632..e422322 100644
--- a/arch/powerpc/sysdev/qe_lib/qe.c
+++ b/arch/powerpc/sysdev/qe_lib/qe.c
@@ -122,8 +122,7 @@ int qe_issue_cmd(u32 cmd, u32 device, u8
mcn_shift = QE_CR_MCN_NORMAL_SHIFT;
}
- out_be32(&qe_immr->cp.cecdr,
- immrbar_virt_to_phys((void *)cmd_input));
+ out_be32(&qe_immr->cp.cecdr, cmd_input);
out_be32(&qe_immr->cp.cecr,
(cmd | QE_CR_FLG | ((u32) device << dev_shift) | (u32)
mcn_protocol << mcn_shift));
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-10-31 9:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-31 9:53 [PATCH 1/2] qe_lib: qe_issue_cmd writes wrong value to CECDR Li Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox