From: Geoff Levand <geoffrey.levand@am•sony.com>
To: Paul Mackerras <paulus@samba•org>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>,
Linux/PPC Development <linuxppc-dev@ozlabs•org>
Subject: Re: [PATCH] ps3_free_io_irq: inverted error check
Date: Fri, 12 Jan 2007 09:16:16 -0800 [thread overview]
Message-ID: <45A7C260.3010101@am.sony.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0612211355150.20731@pademelon.sonytel.be>
Geert Uytterhoeven wrote:
> ps3_free_io_irq: Fix inverted error check after calling
> lv1_destruct_io_irq_outlet()
>
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>
>
> ---
> arch/powerpc/platforms/ps3/interrupt.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- ps3-linux-src.orig/arch/powerpc/platforms/ps3/interrupt.c
> +++ ps3-linux-src/arch/powerpc/platforms/ps3/interrupt.c
> @@ -71,7 +71,7 @@ int ps3_free_io_irq(unsigned int virq)
>
> result = lv1_destruct_io_irq_outlet(virq_to_hw(virq));
>
> - if (!result)
> + if (result)
> pr_debug("%s:%d: lv1_destruct_io_irq_outlet failed: %s\n",
> __func__, __LINE__, ps3_result(result));
>
>
Paul,
If you don't see any trouble, it would be nice for this to go in
for 2.6.20, as it fixes a problem currently in Linus' tree.
Sorry it took so long to merge in and test.
Acked-by: Geoff Levand <geoffrey.levand@am•sony.com>
-Geoff
prev parent reply other threads:[~2007-01-12 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 12:57 [PATCH] ps3_free_io_irq: inverted error check Geert Uytterhoeven
2007-01-12 17:16 ` Geoff Levand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A7C260.3010101@am.sony.com \
--to=geoffrey.levand@am$(echo .)sony.com \
--cc=Geert.Uytterhoeven@sonycom$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox