* [PATCH] ps3_free_io_irq: inverted error check
@ 2006-12-21 12:57 Geert Uytterhoeven
2007-01-12 17:16 ` Geoff Levand
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2006-12-21 12:57 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Linux/PPC Development
ps3_free_io_irq: Fix inverted error check after calling
lv1_destruct_io_irq_outlet()
Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>
---
arch/powerpc/platforms/ps3/interrupt.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- ps3-linux-src.orig/arch/powerpc/platforms/ps3/interrupt.c
+++ ps3-linux-src/arch/powerpc/platforms/ps3/interrupt.c
@@ -71,7 +71,7 @@ int ps3_free_io_irq(unsigned int virq)
result = lv1_destruct_io_irq_outlet(virq_to_hw(virq));
- if (!result)
+ if (result)
pr_debug("%s:%d: lv1_destruct_io_irq_outlet failed: %s\n",
__func__, __LINE__, ps3_result(result));
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom•com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ps3_free_io_irq: inverted error check
2006-12-21 12:57 [PATCH] ps3_free_io_irq: inverted error check Geert Uytterhoeven
@ 2007-01-12 17:16 ` Geoff Levand
0 siblings, 0 replies; 2+ messages in thread
From: Geoff Levand @ 2007-01-12 17:16 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Geert Uytterhoeven, Linux/PPC Development
Geert Uytterhoeven wrote:
> ps3_free_io_irq: Fix inverted error check after calling
> lv1_destruct_io_irq_outlet()
>
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>
>
> ---
> arch/powerpc/platforms/ps3/interrupt.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- ps3-linux-src.orig/arch/powerpc/platforms/ps3/interrupt.c
> +++ ps3-linux-src/arch/powerpc/platforms/ps3/interrupt.c
> @@ -71,7 +71,7 @@ int ps3_free_io_irq(unsigned int virq)
>
> result = lv1_destruct_io_irq_outlet(virq_to_hw(virq));
>
> - if (!result)
> + if (result)
> pr_debug("%s:%d: lv1_destruct_io_irq_outlet failed: %s\n",
> __func__, __LINE__, ps3_result(result));
>
>
Paul,
If you don't see any trouble, it would be nice for this to go in
for 2.6.20, as it fixes a problem currently in Linus' tree.
Sorry it took so long to merge in and test.
Acked-by: Geoff Levand <geoffrey.levand@am•sony.com>
-Geoff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-12 17:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-21 12:57 [PATCH] ps3_free_io_irq: inverted error check Geert Uytterhoeven
2007-01-12 17:16 ` Geoff Levand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox