From: Bartlomiej Sieka <tur@semihalf•com>
To: Richard Purdie <rpurdie@rpsys•net>
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>
Subject: Re: Please pull linux-2.6-mpc52xx.git
Date: Tue, 25 Mar 2008 16:29:47 +0100 [thread overview]
Message-ID: <47E91A6B.6010301@semihalf.com> (raw)
In-Reply-To: <1205834666.7500.27.camel@dax.rpnet.com>
Richard Purdie wrote:
> On Tue, 2008-03-18 at 09:29 +0100, Bartlomiej Sieka wrote:
>> Grant Likely wrote:
>>> The LED code just hasn't been picked up. IIRC, it was reworked to
>>> make it a proper driver in drivers/leds.
>> Yes, the Motion-PRO LED driver has been reworked and posted:
>> http://patchwork.ozlabs.org/linuxppc/patch?q=Motion-pro&id=16617
>>
>> > I need to look at it again,
>>> but it is a lot of code for a very simple thing and I wasn't sure if I
>>> should be the one to pick it up because it is in drivers/leds which
>>> has a different maintainer.
>> I'm copying Richard Purdie who's listed as LED SUBSYSTEM maintainer.
>>
>> Richard -- could pick up the above mentioned Motion-PRO LED driver for
>> upstream inclusion? It started as a MPC5200-specific thing posted to
>> linuxppc-dev and got reviewed there, with the intent to go upstream via
>> Grant (MPC52XX maintainer). However, it seems that it should be merged
>> through your subsystem.
>
> There are some tweaks this driver needs before it can be merged.
>
> Firstly, it seems to re implement a timer to make the LED blink and I'm
> not keen on doing that. I notice that you have default_trigger = "timer"
> but that won't make it activate at boot which is probably why the other
> code exists?
That's right. The requirement is to have the LED blink while the system
is booting up, until a custom application takes control over.
> I will accept a patch which allows the default timer state
> to be configurable (either from the defconfig or from the commandline)
> which should solve your problem?
Yes, this should work. Will you accept a patch that allows default timer
configuration based on the information from the device tree blob (the
board in question is under arch/powerpc)?
>
> Secondly, can you confirm what of_get_property(op->node, "label", NULL);
> returns and whether this conforms to the LED naming guidelines?
No it does not -- thanks for bringing this point up. Will post code that
fixes this.
Thanks for your comments.
Regards,
Bartlomiej
next prev parent reply other threads:[~2008-03-25 15:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 7:35 Please pull linux-2.6-mpc52xx.git Grant Likely
[not found] ` <47DE94F4.90804@semihalf.com>
2008-03-17 19:19 ` Grant Likely
2008-03-17 20:59 ` Wolfgang Denk
2008-03-17 21:43 ` Grant Likely
2008-03-17 22:28 ` Wolfgang Denk
2008-03-17 23:43 ` Grant Likely
2008-03-18 0:26 ` Wolfgang Denk
2008-03-18 2:42 ` Grant Likely
2008-03-18 12:20 ` Josh Boyer
2008-03-18 8:29 ` Bartlomiej Sieka
2008-03-18 10:04 ` Richard Purdie
2008-03-25 15:29 ` Bartlomiej Sieka [this message]
2008-03-18 14:47 ` Grant Likely
2008-03-18 16:41 ` Richard Purdie
2008-03-18 16:53 ` Grant Likely
2008-03-25 16:50 ` Bartlomiej Sieka
2008-03-25 18:49 ` Grant Likely
2008-03-25 17:38 ` Bartlomiej Sieka
2008-03-25 18:51 ` Grant Likely
2008-04-01 12:37 ` Bartlomiej Sieka
2008-04-04 11:13 ` Bartlomiej Sieka
2008-04-04 16:11 ` Grant Likely
2008-04-04 16:14 ` Grant Likely
2008-04-04 16:38 ` Olof Johansson
2008-04-04 17:15 ` Josh Boyer
2008-04-04 17:25 ` Grant Likely
2008-04-15 10:34 ` Bartlomiej Sieka
2008-03-18 7:57 ` Bartlomiej Sieka
-- strict thread matches above, loose matches on Subject: below --
2009-01-09 23:09 Grant Likely
2008-11-14 19:20 Grant Likely
2008-11-24 3:38 ` Paul Mackerras
2008-11-24 14:41 ` Grant Likely
2008-05-01 18:04 Grant Likely
2008-04-29 13:34 Grant Likely
2007-10-16 23:22 Grant Likely
2007-10-17 10:27 ` Paul Mackerras
2007-10-17 13:13 ` Grant Likely
2007-10-10 16:30 Grant Likely
2007-10-11 17:35 ` tnt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E91A6B.6010301@semihalf.com \
--to=tur@semihalf$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=rpurdie@rpsys$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox