From: Wolfgang Grandegger <wg@grandegger•com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>,
Anatolij Gustschin <agust@denx•de>
Subject: Re: [RESEND][POWERPC] mpc5200: Amalgamated dts fixes and updates
Date: Wed, 26 Mar 2008 21:48:07 +0100 [thread overview]
Message-ID: <47EAB687.5040702@grandegger.com> (raw)
In-Reply-To: <fa686aa40803261335q2b8af09cw6f05dc0cf905d0b5@mail.gmail.com>
Grant Likely wrote:
> On Wed, Mar 26, 2008 at 1:45 PM, Bartlomiej Sieka <tur@semihalf•com> wrote:
>> The bulk of this patch is taken from
>> http://patchwork.ozlabs.org/linuxppc/patch?q=Balakowicz&id=16197, with few
>> other updates.
>>
>> Signed-off-by: Marian Balakowicz <m8@semihalf•com>
>> ---
>> Addressed comments from the list; would appreciate picking up as the patch
>> fixes booting issue on TQM5200 and Motion-PRO (cm5200 changes are analogous,
>> but not tested due to hardware unavailability).
>
> I see one obvious error; but other than that it looks good. Once that
> is fixed I can recommend for Paul to pick it up for .25. It's just
> dts changes, so I don't expect it to be a problem.
>
> Cheers,
> g.
>
>> diff --git a/arch/powerpc/boot/dts/motionpro.dts b/arch/powerpc/boot/dts/motionpro.dts
>> index 76951ab..f27256b 100644
>> --- a/arch/powerpc/boot/dts/motionpro.dts
>> +++ b/arch/powerpc/boot/dts/motionpro.dts
>> @@ -209,10 +208,25 @@
>> + mdio@3000 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "fsl,mpc5200b-mdio","fsl,mpc5200-mdio";
>> + reg = <3000 400>; // fec range, since we need to setup fec interrupts
>> + interrupts = <2 5 0>; // these are for "mii command finished", not link changes & co.
>> + interrupt-parent = <&mpc5200_pic>;
>> +
>> + phy0:ethernet-phy@0 {
>> + device_type = "ethernet-phy";
>> + reg = <2>;
>
> This doesn't look right. Reg should match the value in "ethernet-phy@0"
And whats about the two CAN nodes for tqm5200.dts? Do we have them already?
Thanks,
Wolfgang.
next prev parent reply other threads:[~2008-03-26 20:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 14:18 Oops with TQM5200 on TQM5200 Wolfgang Grandegger
2008-03-20 14:41 ` Grant Likely
2008-03-20 15:24 ` Anatolij Gustschin
2008-03-20 16:17 ` Bartlomiej Sieka
2008-03-20 21:27 ` Grant Likely
2008-03-22 10:49 ` Anatolij Gustschin
2008-03-22 14:39 ` Grant Likely
2008-03-20 16:29 ` Wolfgang Grandegger
2008-03-20 23:50 ` Grant Likely
2008-03-21 0:07 ` Bartlomiej Sieka
2008-03-21 0:20 ` Grant Likely
2008-03-21 23:56 ` [POWERPC] mpc52xx: Amalgamated dts fixes and updates Bartlomiej Sieka
2008-03-22 0:12 ` David Gibson
2008-03-22 3:47 ` Grant Likely
2008-03-22 0:41 ` Anatolij Gustschin
2008-03-22 3:14 ` Grant Likely
2008-03-26 19:45 ` [RESEND][POWERPC] mpc5200: " Bartlomiej Sieka
2008-03-26 20:35 ` Grant Likely
2008-03-26 20:48 ` Wolfgang Grandegger [this message]
2008-03-26 21:32 ` Bartlomiej Sieka
2008-03-26 21:18 ` [RESEND2][POWERPC] " Bartlomiej Sieka
2008-03-26 21:02 ` [RESEND][POWERPC] " Matt Sealey
2008-03-26 21:16 ` Grant Likely
2008-03-26 22:51 ` David Gibson
2008-03-26 22:57 ` Matt Sealey
2008-03-26 23:28 ` David Gibson
2008-03-24 16:59 ` [POWERPC] mpc52xx: " Wolfgang Grandegger
2008-03-21 6:30 ` Oops with TQM5200 on TQM5200 Wolfgang Grandegger
2008-03-21 19:02 ` Grant Likely
2008-03-24 6:47 ` Paul Mackerras
2008-03-25 9:54 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EAB687.5040702@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=agust@denx$(echo .)de \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox