public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Matt Sealey <matt@genesi-usa•com>
To: Grant Likely <grant.likely@secretlab•ca>,
	Matt Sealey <matt@genesi-usa•com>,
	linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>,
	Anatolij Gustschin <agust@denx•de>
Subject: Re: [RESEND][POWERPC] mpc5200: Amalgamated dts fixes and updates
Date: Wed, 26 Mar 2008 22:57:30 +0000	[thread overview]
Message-ID: <47EAD4DA.5050907@genesi-usa.com> (raw)
In-Reply-To: <20080326225128.GB5777@localhost.localdomain>

David Gibson wrote:
> On Wed, Mar 26, 2008 at 03:16:47PM -0600, Grant Likely wrote:
>> On Wed, Mar 26, 2008 at 3:02 PM, Matt Sealey <matt@genesi-usa•com> wrote:
>>> Bartlomiej Sieka wrote:
>>>  > +
>>>  > +                     phy0:ethernet-phy@0 {
>>>  > +                             device_type = "ethernet-phy";@0"
>>>  > +                             reg = <0>;
>>>  > +                     };
>>>
>>>  What's the parsing of this pan out to? What does it mean?
>>>
>>>  Having colons in device names is totally contrary to OF device naming
>>>  spec. Does the part after the colon have a special meaning to the DTC?
>> "phy0:" is a label used by dtc.
>> "ethernet-phy@0" is the node name.
> 
> I would suggest a space after the colon though, to make this clearer.
> That's the style I've been using in all my dts files.

I would suggest taking a hint from C structures...

ethernet-phy@0 {
	name = "ethernet-phy";
	reg = <0>;
	foo = bar;
} phy0;

I mean, this is really intuitive, we all do this every day...

-- 
Matt Sealey <matt@genesi-usa•com>
Genesi, Manager, Developer Relations

  reply	other threads:[~2008-03-26 22:57 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-20 14:18 Oops with TQM5200 on TQM5200 Wolfgang Grandegger
2008-03-20 14:41 ` Grant Likely
2008-03-20 15:24 ` Anatolij Gustschin
2008-03-20 16:17   ` Bartlomiej Sieka
2008-03-20 21:27     ` Grant Likely
2008-03-22 10:49       ` Anatolij Gustschin
2008-03-22 14:39         ` Grant Likely
2008-03-20 16:29   ` Wolfgang Grandegger
2008-03-20 23:50   ` Grant Likely
2008-03-21  0:07     ` Bartlomiej Sieka
2008-03-21  0:20       ` Grant Likely
2008-03-21 23:56         ` [POWERPC] mpc52xx: Amalgamated dts fixes and updates Bartlomiej Sieka
2008-03-22  0:12           ` David Gibson
2008-03-22  3:47             ` Grant Likely
2008-03-22  0:41           ` Anatolij Gustschin
2008-03-22  3:14           ` Grant Likely
2008-03-26 19:45             ` [RESEND][POWERPC] mpc5200: " Bartlomiej Sieka
2008-03-26 20:35               ` Grant Likely
2008-03-26 20:48                 ` Wolfgang Grandegger
2008-03-26 21:32                   ` Bartlomiej Sieka
2008-03-26 21:18                 ` [RESEND2][POWERPC] " Bartlomiej Sieka
2008-03-26 21:02               ` [RESEND][POWERPC] " Matt Sealey
2008-03-26 21:16                 ` Grant Likely
2008-03-26 22:51                   ` David Gibson
2008-03-26 22:57                     ` Matt Sealey [this message]
2008-03-26 23:28                       ` David Gibson
2008-03-24 16:59           ` [POWERPC] mpc52xx: " Wolfgang Grandegger
2008-03-21  6:30       ` Oops with TQM5200 on TQM5200 Wolfgang Grandegger
2008-03-21 19:02         ` Grant Likely
2008-03-24  6:47         ` Paul Mackerras
2008-03-25  9:54           ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47EAD4DA.5050907@genesi-usa.com \
    --to=matt@genesi-usa$(echo .)com \
    --cc=agust@denx$(echo .)de \
    --cc=grant.likely@secretlab$(echo .)ca \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=paulus@samba$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox