From: Wolfgang Grandegger <wg@grandegger•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules
Date: Fri, 30 May 2008 09:12:54 +0200 [thread overview]
Message-ID: <483FA8F6.30605@grandegger.com> (raw)
In-Reply-To: <20080530170153.45a763b6.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> Hi Wolfgang,
>
> On Fri, 30 May 2008 08:49:45 +0200 Wolfgang Grandegger <wg@grandegger•com> wrote:
>> +++ b/arch/powerpc/platforms/85xx/tqm85xx.c
>> @@ -120,8 +120,17 @@ static void __init tqm85xx_setup_arch(void)
>> #endif
>>
>> #ifdef CONFIG_PCI
>> - for_each_compatible_node(np, "pci", "fsl,mpc8540-pci")
>> - fsl_add_bridge(np, 1);
>> + for_each_node_by_type(np, "pci") {
>> + if (of_device_is_compatible(np, "fsl,mpc8540-pci") ||
>> + of_device_is_compatible(np, "fsl,mpc8548-pcie")) {
>> + struct resource rsrc;
>> + of_address_to_resource(np, 0, &rsrc);
>
> What happens if of_address_to_resource fails?
Checking the return code is missing, of course. Obviously a cut & paste
from a bad source (sbc8548.c).
Will fix.
Wolfgang.
next prev parent reply other threads:[~2008-05-30 7:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 6:49 [PATCH 0/4] 85xx: Add suport for TQM8548 and some TQM85xx fixes Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 2/4] [POWERPC] 85xx: support for the TQM8548 module using the big Flash Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 3/4] [POWERPC] 85xx: add local bus nodes for Flash and CAN to tqm8560.dts Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 4/4] [POWERPC] 85xx: correct vendor prefix in DTS files for TQM85xx modules Wolfgang Grandegger
2008-05-30 12:28 ` [PATCH 2/4] [POWERPC] 85xx: support for the TQM8548 module using the big Flash Anton Vorontsov
2008-05-30 18:02 ` Wolfgang Grandegger
2008-05-30 20:01 ` Kumar Gala
2008-05-30 20:07 ` Scott Wood
2008-05-30 20:10 ` Kumar Gala
2008-05-30 7:01 ` [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules Stephen Rothwell
2008-05-30 7:12 ` Wolfgang Grandegger [this message]
2008-05-30 8:24 ` Arnd Bergmann
2008-06-02 2:03 ` David Gibson
2008-06-02 6:31 ` Wolfgang Grandegger
2008-06-02 23:13 ` Kumar Gala
2008-06-03 10:08 ` Wolfgang Grandegger
2008-06-03 14:33 ` Kumar Gala
2008-06-03 22:39 ` David Gibson
2008-06-04 9:43 ` Wolfgang Grandegger
2008-06-04 13:27 ` Kumar Gala
2008-06-05 6:43 ` Wolfgang Grandegger
2008-06-05 7:43 ` Kumar Gala
2008-06-05 7:49 ` Wolfgang Grandegger
2008-06-05 11:00 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483FA8F6.30605@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox