From: Wolfgang Grandegger <wg@grandegger•com>
To: Wolfgang Grandegger <wg@grandegger•com>, Linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules
Date: Mon, 02 Jun 2008 08:31:40 +0200 [thread overview]
Message-ID: <484393CC.3080709@grandegger.com> (raw)
In-Reply-To: <20080602020352.GB19393@yookeroo.seuss>
David Gibson wrote:
> On Fri, May 30, 2008 at 08:49:45AM +0200, Wolfgang Grandegger wrote:
>> This patch adds support for the TQM8548 modules from TQ-Components
>> GmbH (http://www.tqc.de).
>
> [snip]
>> index 0000000..d09250a
>> --- /dev/null
>> +++ b/arch/powerpc/boot/dts/tqm8548.dts
>> @@ -0,0 +1,370 @@
>> +/*
>> + * TQM8548 Device Tree Source
>> + *
>> + * Copyright 2006 Freescale Semiconductor Inc.
>> + * Copyright 2008 Wolfgang Grandegger <wg@denx•de>
>> + *
>> + * This program is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU General Public License as published by the
>> + * Free Software Foundation; either version 2 of the License, or (at your
>> + * option) any later version.
>> + */
>> +
>> +/dts-v1/;
>
> [snip]
>> + i2c@3000 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + cell-index = <0>;
> [...]
>> + enet0: ethernet@24000 {
>> + cell-index = <0>;
> [...]
>> + serial0: serial@4500 {
>> + cell-index = <0>;
> [...]
>> + pci0: pci@e0008000 {
>> + cell-index = <0>;
>
> You have a whole lot of 'cell-index' properties through both these
> trees, and they all look wrong. cell-index is a hack, which should be
> avoided wherever practical - it should only be used when the index is
> used to offset into some global register block, never simply to
> differentiate (use reg for that) or name the devices (use aliases for
> that).
OK, I can remove them from the TQM85*.dts files but I think the problem
is more general. It seems to be frequently used for similar purposes,
also in the code, at least in 2.6.26-rc4:
$ cd linux-2.6/arch/powerpc/boot/dts
$ grep -l 'cell-index' *.dts | wc -l
58
Wolfgang
next prev parent reply other threads:[~2008-06-02 6:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 6:49 [PATCH 0/4] 85xx: Add suport for TQM8548 and some TQM85xx fixes Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 2/4] [POWERPC] 85xx: support for the TQM8548 module using the big Flash Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 3/4] [POWERPC] 85xx: add local bus nodes for Flash and CAN to tqm8560.dts Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 4/4] [POWERPC] 85xx: correct vendor prefix in DTS files for TQM85xx modules Wolfgang Grandegger
2008-05-30 12:28 ` [PATCH 2/4] [POWERPC] 85xx: support for the TQM8548 module using the big Flash Anton Vorontsov
2008-05-30 18:02 ` Wolfgang Grandegger
2008-05-30 20:01 ` Kumar Gala
2008-05-30 20:07 ` Scott Wood
2008-05-30 20:10 ` Kumar Gala
2008-05-30 7:01 ` [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules Stephen Rothwell
2008-05-30 7:12 ` Wolfgang Grandegger
2008-05-30 8:24 ` Arnd Bergmann
2008-06-02 2:03 ` David Gibson
2008-06-02 6:31 ` Wolfgang Grandegger [this message]
2008-06-02 23:13 ` Kumar Gala
2008-06-03 10:08 ` Wolfgang Grandegger
2008-06-03 14:33 ` Kumar Gala
2008-06-03 22:39 ` David Gibson
2008-06-04 9:43 ` Wolfgang Grandegger
2008-06-04 13:27 ` Kumar Gala
2008-06-05 6:43 ` Wolfgang Grandegger
2008-06-05 7:43 ` Kumar Gala
2008-06-05 7:49 ` Wolfgang Grandegger
2008-06-05 11:00 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484393CC.3080709@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox