From: Wolfgang Grandegger <wg@grandegger•com>
To: Kumar Gala <galak@kernel•crashing.org>,
Wolfgang Grandegger <wg@grandegger•com>,
Linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules
Date: Wed, 04 Jun 2008 11:43:55 +0200 [thread overview]
Message-ID: <484663DB.5000905@grandegger.com> (raw)
In-Reply-To: <20080603223905.GA22982@yookeroo.seuss>
David Gibson wrote:
> On Tue, Jun 03, 2008 at 09:33:12AM -0500, Kumar Gala wrote:
>> On Jun 3, 2008, at 5:08 AM, Wolfgang Grandegger wrote:
>>> Kumar Gala wrote:
>>>> On Jun 1, 2008, at 9:03 PM, David Gibson wrote:
>>>>> On Fri, May 30, 2008 at 08:49:45AM +0200, Wolfgang Grandegger wrote:
> [snip]
>>>>> You have a whole lot of 'cell-index' properties through both these
>>>>> trees, and they all look wrong. cell-index is a hack, which
>>>>> should be
>>>>> avoided wherever practical - it should only be used when the index
>>>>> is
>>>>> used to offset into some global register block, never simply to
>>>>> differentiate (use reg for that) or name the devices (use aliases
>>>>> for
>>>>> that).
>>>> this is why FSL device tree's have cell-index. We have global
>>>> control
>>>> registers that need to know such things.
>>> Should I remove them or not? OF is still a mystery for me :-(.
>> Don't remove them.
>
> Yes, they're ok, given this usage.
I'm puzzled. Could someone point me to some real code where cell-index
is used as a pointer into some global data. Sorry for my ignorance.
Thanks.
Wolfgang.
next prev parent reply other threads:[~2008-06-04 9:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 6:49 [PATCH 0/4] 85xx: Add suport for TQM8548 and some TQM85xx fixes Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 2/4] [POWERPC] 85xx: support for the TQM8548 module using the big Flash Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 3/4] [POWERPC] 85xx: add local bus nodes for Flash and CAN to tqm8560.dts Wolfgang Grandegger
2008-05-30 6:49 ` [PATCH 4/4] [POWERPC] 85xx: correct vendor prefix in DTS files for TQM85xx modules Wolfgang Grandegger
2008-05-30 12:28 ` [PATCH 2/4] [POWERPC] 85xx: support for the TQM8548 module using the big Flash Anton Vorontsov
2008-05-30 18:02 ` Wolfgang Grandegger
2008-05-30 20:01 ` Kumar Gala
2008-05-30 20:07 ` Scott Wood
2008-05-30 20:10 ` Kumar Gala
2008-05-30 7:01 ` [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules Stephen Rothwell
2008-05-30 7:12 ` Wolfgang Grandegger
2008-05-30 8:24 ` Arnd Bergmann
2008-06-02 2:03 ` David Gibson
2008-06-02 6:31 ` Wolfgang Grandegger
2008-06-02 23:13 ` Kumar Gala
2008-06-03 10:08 ` Wolfgang Grandegger
2008-06-03 14:33 ` Kumar Gala
2008-06-03 22:39 ` David Gibson
2008-06-04 9:43 ` Wolfgang Grandegger [this message]
2008-06-04 13:27 ` Kumar Gala
2008-06-05 6:43 ` Wolfgang Grandegger
2008-06-05 7:43 ` Kumar Gala
2008-06-05 7:49 ` Wolfgang Grandegger
2008-06-05 11:00 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484663DB.5000905@grandegger.com \
--to=wg@grandegger$(echo .)com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=galak@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox