From: Ritesh Harjani (IBM) <ritesh.list@gmail•com>
To: Christophe Leroy <christophe.leroy@csgroup•eu>,
linuxppc-dev@lists•ozlabs.org
Cc: Madhavan Srinivasan <maddy@linux•ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>,
Nicholas Piggin <npiggin@gmail•com>,
Paul Mackerras <paulus@ozlabs•org>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel•org>,
Donet Tom <donettom@linux•ibm.com>
Subject: Re: [RFC 6/8] powerpc/book3s64/slb: Make preload_add return type as void
Date: Sat, 30 Aug 2025 12:57:20 +0530 [thread overview]
Message-ID: <87v7m5jmlj.fsf@gmail.com> (raw)
In-Reply-To: <e1222528-911d-4558-b483-bceed8a99f2b@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup•eu> writes:
> Le 30/08/2025 à 05:51, Ritesh Harjani (IBM) a écrit :
>> We dropped preload_new_slb_context() in the previous patch. That means
>
> slb_setup_new_exec() was also checking preload_add() returned value but
> is also gone.
>
Right. Will add that.
>> we don't really need preload_add() return type anymore. So let's make
>> it's return type to void.
>
> s/it's/its
>
Sure.
>>
>> Cc: Madhavan Srinivasan <maddy@linux•ibm.com>
>> Cc: Michael Ellerman <mpe@ellerman•id.au>
>> Cc: Nicholas Piggin <npiggin@gmail•com>
>> Cc: Christophe Leroy <christophe.leroy@csgroup•eu>
>> Cc: Paul Mackerras <paulus@ozlabs•org>
>> Cc: "Aneesh Kumar K.V" <aneesh.kumar@kernel•org>
>> Cc: Donet Tom <donettom@linux•ibm.com>
>> Cc: linuxppc-dev@lists•ozlabs.org
>> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail•com>
>> ---
>> arch/powerpc/mm/book3s64/slb.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/powerpc/mm/book3s64/slb.c b/arch/powerpc/mm/book3s64/slb.c
>> index 7e053c561a09..780792b9a1e5 100644
>> --- a/arch/powerpc/mm/book3s64/slb.c
>> +++ b/arch/powerpc/mm/book3s64/slb.c
>> @@ -294,7 +294,7 @@ static bool preload_hit(struct thread_info *ti, unsigned long esid)
>> return false;
>> }
>>
>> -static bool preload_add(struct thread_info *ti, unsigned long ea)
>> +static void preload_add(struct thread_info *ti, unsigned long ea)
>> {
>> unsigned char idx;
>> unsigned long esid;
>> @@ -308,7 +308,7 @@ static bool preload_add(struct thread_info *ti, unsigned long ea)
>> esid = ea >> SID_SHIFT;
>>
>> if (preload_hit(ti, esid))
>> - return false;
>> + return;
>>
>> idx = (ti->slb_preload_tail + ti->slb_preload_nr) % SLB_PRELOAD_NR;
>> ti->slb_preload_esid[idx] = esid;
>> @@ -317,7 +317,7 @@ static bool preload_add(struct thread_info *ti, unsigned long ea)
>> else
>> ti->slb_preload_nr++;
>>
>> - return true;
>> + return;
>
> You don't need a valueless return at the end of a function
>
Right make sense. I will fix these in the next revision.
Thanks for the review!
-ritesh
next prev parent reply other threads:[~2025-08-30 7:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 3:51 [PATCH 0/8] powerpc/book3s64: Hash / SLB fixes & improvements Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 1/8] powerpc/mm: Fix SLB multihit issue during SLB preload Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 2/8] book3s64/hash: Restrict stress_hpt_struct memblock region to within RMA limit Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 3/8] book3s64/hash: Fix phys_addr_t printf format in htab_initialize() Ritesh Harjani (IBM)
2025-08-30 6:26 ` Christophe Leroy
2025-08-30 7:30 ` Ritesh Harjani
2025-08-30 3:51 ` [RFC 4/8] powerpc/ptdump/64: Fix kernel_hash_pagetable dump for ISA v3.00 HPTE format Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 5/8] powerpc/ptdump: Dump PXX level info for kernel_page_tables Ritesh Harjani (IBM)
2025-08-30 6:31 ` Christophe Leroy
2025-08-30 7:25 ` Ritesh Harjani
2025-08-30 3:51 ` [RFC 6/8] powerpc/book3s64/slb: Make preload_add return type as void Ritesh Harjani (IBM)
2025-08-30 6:36 ` Christophe Leroy
2025-08-30 7:27 ` Ritesh Harjani [this message]
2025-08-30 3:51 ` [RFC 7/8] powerpc/book3s64/slb: Add no_slb_preload early cmdline param Ritesh Harjani (IBM)
2025-08-30 6:42 ` Christophe Leroy
2025-08-30 10:11 ` Ritesh Harjani
2025-08-30 3:51 ` [RFC 8/8] powerpc/book3s64/slb: Add slb faults to vmstat Ritesh Harjani (IBM)
2025-08-30 4:45 ` Stephen Rothwell
2025-08-30 4:56 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7m5jmlj.fsf@gmail.com \
--to=ritesh.list@gmail$(echo .)com \
--cc=aneesh.kumar@kernel$(echo .)org \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=donettom@linux$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=paulus@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox