From: Ritesh Harjani (IBM) <ritesh.list@gmail•com>
To: Christophe Leroy <christophe.leroy@csgroup•eu>,
linuxppc-dev@lists•ozlabs.org
Cc: Madhavan Srinivasan <maddy@linux•ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>,
Nicholas Piggin <npiggin@gmail•com>,
Paul Mackerras <paulus@ozlabs•org>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel•org>,
Donet Tom <donettom@linux•ibm.com>
Subject: Re: [RFC 5/8] powerpc/ptdump: Dump PXX level info for kernel_page_tables
Date: Sat, 30 Aug 2025 12:55:49 +0530 [thread overview]
Message-ID: <87wm6ljmo2.fsf@gmail.com> (raw)
In-Reply-To: <12739812-aa4e-4124-8296-b98adecbc6eb@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup•eu> writes:
> Le 30/08/2025 à 05:51, Ritesh Harjani (IBM) a écrit :
>> This patch adds PGD/PUD/PMD/PTE level information while dumping kernel
>> page tables. Before this patch it was hard to identify which entries
>> belongs to which page table level e.g.
>>
>> ~ # dmesg |grep -i radix
>> [0.000000] radix-mmu: Mapped 0x0000000000000000-0x0000000005400000 with 2.00 MiB pages (exec)
>> [0.000000] radix-mmu: Mapped 0x0000000005400000-0x0000000040000000 with 2.00 MiB pages
>> [0.000000] radix-mmu: Mapped 0x0000000040000000-0x0000000100000000 with 1.00 GiB pages
>> [0.000000] radix-mmu: Initializing Radix MMU
>>
>> Before:
>> ---[ Start of kernel VM ]---
>> 0xc000000000000000-0xc000000003ffffff XXX 64M r X pte valid present dirty accessed
>> 0xc000000004000000-0xc00000003fffffff XXX 960M r w pte valid present dirty accessed
>> 0xc000000040000000-0xc0000000ffffffff XXX 3G r w pte valid present dirty accessed
>> ...
>> ---[ vmemmap start ]---
>> 0xc00c000000000000-0xc00c0000003fffff XXX 4M r w pte valid present dirty accessed
>>
>> After:
>> ---[ Start of kernel VM ]---
>> 0xc000000000000000-0xc000000003ffffff XXX 64M PMD r X pte valid present dirty accessed
>> 0xc000000004000000-0xc00000003fffffff XXX 960M PMD r w pte valid present dirty accessed
>> 0xc000000040000000-0xc0000000ffffffff XXX 3G PUD r w pte valid present dirty accessed
>> ...
>> ---[ vmemmap start ]---
>> 0xc00c000000000000-0xc00c0000003fffff XXX 4M PMD r w pte valid present dirty accessed
>>
>> Cc: Madhavan Srinivasan <maddy@linux•ibm.com>
>> Cc: Michael Ellerman <mpe@ellerman•id.au>
>> Cc: Nicholas Piggin <npiggin@gmail•com>
>> Cc: Christophe Leroy <christophe.leroy@csgroup•eu>
>> Cc: Paul Mackerras <paulus@ozlabs•org>
>> Cc: "Aneesh Kumar K.V" <aneesh.kumar@kernel•org>
>> Cc: Donet Tom <donettom@linux•ibm.com>
>> Cc: linuxppc-dev@lists•ozlabs.org
>> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail•com>
>> ---
>> arch/powerpc/mm/ptdump/8xx.c | 5 +++++
>> arch/powerpc/mm/ptdump/book3s64.c | 5 +++++
>> arch/powerpc/mm/ptdump/ptdump.c | 1 +
>> arch/powerpc/mm/ptdump/ptdump.h | 1 +
>> arch/powerpc/mm/ptdump/shared.c | 5 +++++
>> 5 files changed, 17 insertions(+)
>>
>> diff --git a/arch/powerpc/mm/ptdump/8xx.c b/arch/powerpc/mm/ptdump/8xx.c
>> index b5c79b11ea3c..1dc0f2438a73 100644
>> --- a/arch/powerpc/mm/ptdump/8xx.c
>> +++ b/arch/powerpc/mm/ptdump/8xx.c
>> @@ -71,18 +71,23 @@ static const struct flag_info flag_array[] = {
>>
>> struct pgtable_level pg_level[5] = {
>> { /* pgd */
>> + .name = "PGD",
>> .flag = flag_array,
>> .num = ARRAY_SIZE(flag_array),
>> }, { /* p4d */
>> + .name = "P4D",
>> .flag = flag_array,
>> .num = ARRAY_SIZE(flag_array),
>> }, { /* pud */
>> + .name = "PUD",
>> .flag = flag_array,
>> .num = ARRAY_SIZE(flag_array),
>> }, { /* pmd */
>> + .name = "PMD",
>> .flag = flag_array,
>> .num = ARRAY_SIZE(flag_array),
>> }, { /* pte */
>> + .name = "PTX",
>
> Why PTX not PTE ?
>
My bad I was checking something on 8xx and I missed reverting that back.
Thanks for pointing out. Will fix it in the next revision.
-ritesh
next prev parent reply other threads:[~2025-08-30 7:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 3:51 [PATCH 0/8] powerpc/book3s64: Hash / SLB fixes & improvements Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 1/8] powerpc/mm: Fix SLB multihit issue during SLB preload Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 2/8] book3s64/hash: Restrict stress_hpt_struct memblock region to within RMA limit Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 3/8] book3s64/hash: Fix phys_addr_t printf format in htab_initialize() Ritesh Harjani (IBM)
2025-08-30 6:26 ` Christophe Leroy
2025-08-30 7:30 ` Ritesh Harjani
2025-08-30 3:51 ` [RFC 4/8] powerpc/ptdump/64: Fix kernel_hash_pagetable dump for ISA v3.00 HPTE format Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 5/8] powerpc/ptdump: Dump PXX level info for kernel_page_tables Ritesh Harjani (IBM)
2025-08-30 6:31 ` Christophe Leroy
2025-08-30 7:25 ` Ritesh Harjani [this message]
2025-08-30 3:51 ` [RFC 6/8] powerpc/book3s64/slb: Make preload_add return type as void Ritesh Harjani (IBM)
2025-08-30 6:36 ` Christophe Leroy
2025-08-30 7:27 ` Ritesh Harjani
2025-08-30 3:51 ` [RFC 7/8] powerpc/book3s64/slb: Add no_slb_preload early cmdline param Ritesh Harjani (IBM)
2025-08-30 6:42 ` Christophe Leroy
2025-08-30 10:11 ` Ritesh Harjani
2025-08-30 3:51 ` [RFC 8/8] powerpc/book3s64/slb: Add slb faults to vmstat Ritesh Harjani (IBM)
2025-08-30 4:45 ` Stephen Rothwell
2025-08-30 4:56 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wm6ljmo2.fsf@gmail.com \
--to=ritesh.list@gmail$(echo .)com \
--cc=aneesh.kumar@kernel$(echo .)org \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=donettom@linux$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=paulus@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox