From: Ritesh Harjani (IBM) <ritesh.list@gmail•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linuxppc-dev@lists•ozlabs.org,
Madhavan Srinivasan <maddy@linux•ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>,
Nicholas Piggin <npiggin@gmail•com>,
Christophe Leroy <christophe.leroy@csgroup•eu>,
Donet Tom <donettom@linux•ibm.com>,
Andrew Morton <akpm@linux-foundation•org>,
David Hildenbrand <david@redhat•com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle•com>,
linux-kernel@vger•kernel.org, linux-mm@kvack•org
Subject: Re: [RFC 8/8] powerpc/book3s64/slb: Add slb faults to vmstat
Date: Sat, 30 Aug 2025 10:26:45 +0530 [thread overview]
Message-ID: <87y0r1jtki.fsf@gmail.com> (raw)
In-Reply-To: <20250830144542.6ba0e774@canb.auug.org.au>
Stephen Rothwell <sfr@canb•auug.org.au> writes:
> Hi Ritesh,
>
> On Sat, 30 Aug 2025 09:21:47 +0530 "Ritesh Harjani (IBM)" <ritesh.list@gmail•com> wrote:
>>
>> diff --git a/mm/vmstat.c b/mm/vmstat.c
>> index 71cd1ceba191..8cd17a5fc72b 100644
>> --- a/mm/vmstat.c
>> +++ b/mm/vmstat.c
>> @@ -1464,6 +1464,11 @@ const char * const vmstat_text[] = {
>> [I(DIRECT_MAP_LEVEL2_COLLAPSE)] = "direct_map_level2_collapses",
>> [I(DIRECT_MAP_LEVEL3_COLLAPSE)] = "direct_map_level3_collapses",
>> #endif
>> +#ifdef CONFIG_PPC_BOOK3S_64
>> + "slb_kernel_faults",
>> + "slb_user_faults",
>> +#endif
>> +
>> #ifdef CONFIG_PER_VMA_LOCK_STATS
>> [I(VMA_LOCK_SUCCESS)] = "vma_lock_success",
>> [I(VMA_LOCK_ABORT)] = "vma_lock_abort",
>
> Should you be using explicit indexes and the I() macro?
Aah yes, I guess the branch where I developed the patches was not
upstream tip and when I rebased and tested, I missed to see the I()
macro change in mm/vmstat.
Thanks Stephen for pointing it out. I will fix that in the next revision.
-ritesh
>
> --
> Cheers,
> Stephen Rothwell
prev parent reply other threads:[~2025-08-30 4:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 3:51 [PATCH 0/8] powerpc/book3s64: Hash / SLB fixes & improvements Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 1/8] powerpc/mm: Fix SLB multihit issue during SLB preload Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 2/8] book3s64/hash: Restrict stress_hpt_struct memblock region to within RMA limit Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 3/8] book3s64/hash: Fix phys_addr_t printf format in htab_initialize() Ritesh Harjani (IBM)
2025-08-30 6:26 ` Christophe Leroy
2025-08-30 7:30 ` Ritesh Harjani
2025-08-30 3:51 ` [RFC 4/8] powerpc/ptdump/64: Fix kernel_hash_pagetable dump for ISA v3.00 HPTE format Ritesh Harjani (IBM)
2025-08-30 3:51 ` [RFC 5/8] powerpc/ptdump: Dump PXX level info for kernel_page_tables Ritesh Harjani (IBM)
2025-08-30 6:31 ` Christophe Leroy
2025-08-30 7:25 ` Ritesh Harjani
2025-08-30 3:51 ` [RFC 6/8] powerpc/book3s64/slb: Make preload_add return type as void Ritesh Harjani (IBM)
2025-08-30 6:36 ` Christophe Leroy
2025-08-30 7:27 ` Ritesh Harjani
2025-08-30 3:51 ` [RFC 7/8] powerpc/book3s64/slb: Add no_slb_preload early cmdline param Ritesh Harjani (IBM)
2025-08-30 6:42 ` Christophe Leroy
2025-08-30 10:11 ` Ritesh Harjani
2025-08-30 3:51 ` [RFC 8/8] powerpc/book3s64/slb: Add slb faults to vmstat Ritesh Harjani (IBM)
2025-08-30 4:45 ` Stephen Rothwell
2025-08-30 4:56 ` Ritesh Harjani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0r1jtki.fsf@gmail.com \
--to=ritesh.list@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=david@redhat$(echo .)com \
--cc=donettom@linux$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo.stoakes@oracle$(echo .)com \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox