From: Alexander Zubkov <green@msu•ru>
To: Serhey Popovych <serhe.popovych@gmail•com>,
Luca Boccassi <bluca@debian•org>,
Stephen Hemminger <stephen@networkplumber•org>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"
Date: Wed, 14 Mar 2018 09:59:52 +0100 [thread overview]
Message-ID: <135881521017992@web3o.yandex.ru> (raw)
In-Reply-To: <3ebb9805-fb69-c67d-6222-c6d1d344f4ec@msu.ru>
Hello,
There was a series of patches by Serhey and specifically this one:
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=93fa12418dc6f5943692250244be303bb162175b
It drops handling of special prefix names in get_prefix_1(), and in get_addr_1() they always receive family and bytelen. But as I unerstand for any case it was important to keep it with unspecified family for further filtering. As I do not know what is the global idea, I want to discuss it. Because there are options depending on how and where we want to handle those special names. Like keep unspecified family or change filtering logic.
I have added Serhey Popovych in the recepients, so he can give some ideas on what his aim is and help choose better solution.
13.03.2018, 21:12, "Alexander Zubkov" <green@msu•ru>:
> Hi,
>
> I just realized that you need patch for v4.15.0, which is easier to do.
> I'll send it as separate message now. I will make patch for the master
> branch, but later.
>
> On 13.03.2018 13:02, Luca Boccassi wrote:
>> On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote:
>>> Hello again,
>>>
>>> The fun thing is that before the commit "ip route ls all" showed all
>>> routes, but "ip -[4|6] route ls all" showed only default. So it was
>>> broken too, but in other way.
>>> I see parsing of prefix was changed since my patch. So I need several
>>> days to propose fix. I think if "ip route ls [all|any]" shows all
>>> routes and "ip route ls default" shows only default, everybody will
>>> be happy with that?
>>
>> Hi,
>>
>> My only concern is that behaviour of existing commands that have been
>> in releases is not changed, otherwise I get bugs raised :-)
>>
>> Thank you for your work!
>>
>>> 13.03.2018, 09:46, "Alexander Zubkov" <green@msu•ru>:
>>>> Hello.
>>>>
>>>> May be the better way would be to change how "all"/"any" argument
>>>> behaves? My original concern was about "default" only. I agree too,
>>>> that "all" or "any" should work for all routes. But not for the
>>>> default.
>>>>
>>>> 12.03.2018, 22:37, "Luca Boccassi" <bluca@debian•org>:
>>>>> On Mon, 2018-03-12 at 14:03 -0700, Stephen Hemminger wrote:
>>>>>> This reverts commit 9135c4d6037ff9f1818507bac0049fc44db8c3d2.
>>>>>>
>>>>>> Debian maintainer found that basic command:
>>>>>> # ip route flush all
>>>>>> No longer worked as expected which breaks user scripts and
>>>>>> expectations. It no longer flushed all IPv4 routes.
>>>>>>
>>>>>> Reported-by: Luca Boccassi <bluca@debian•org>
>>>>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber•org>
>>>>>> ---
>>>>>> ip/iproute.c | 65 ++++++++++++++++++----------------------
>>>>>> --------
>>>>>> ------------
>>>>>> lib/utils.c | 13 ++++++++++++
>>>>>> 2 files changed, 32 insertions(+), 46 deletions(-)
>>>>>
>>>>> Tested-by: Luca Boccassi <bluca@debian•org>
>>>>>
>>>>> Thanks, solves the problem. I'll backport it to Debian.
>>>>>
>>>>> Alexander, reproducing the issue is quite simple - before that
>>>>> commit,
>>>>> ip route ls all showed all routes, but with the change it
>>>>> started
>>>>> showing only the default table. Same for ip route flush.
>>>>>
>>>>> --
>>>>> Kind regards,
>>>>> Luca Boccassi
next prev parent reply other threads:[~2018-03-14 8:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 21:03 [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Stephen Hemminger
2018-03-12 21:37 ` Luca Boccassi
2018-03-13 8:46 ` Alexander Zubkov
2018-03-13 11:05 ` Alexander Zubkov
2018-03-13 12:02 ` Luca Boccassi
2018-03-13 20:12 ` Alexander Zubkov
2018-03-13 20:15 ` Luca Boccassi
2018-03-14 8:59 ` Alexander Zubkov [this message]
2018-03-14 20:26 ` Alexander Zubkov
2018-03-18 16:50 ` [PATCH iproute2] treat "default" and "all"/"any" addresses differenty Alexander Zubkov
2018-03-18 17:02 ` Alexander Zubkov
2018-03-27 16:01 ` [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Stephen Hemminger
2018-03-27 16:29 ` Alexander Zubkov
2018-03-27 17:00 ` Stephen Hemminger
2018-03-27 17:33 ` Alexander Zubkov
2018-03-27 17:58 ` Stephen Hemminger
2018-03-27 23:57 ` [PATCH iproute] arrange prefix parsing code after redundant patches Alexander Zubkov
2018-03-29 15:44 ` Stephen Hemminger
2018-03-13 20:19 ` [PATCH iproute2] treat "default" and "all"/"any" parameters differenty Alexander Zubkov
2018-03-13 21:45 ` Luca Boccassi
2018-03-16 20:37 ` Stephen Hemminger
2018-03-16 20:59 ` Alexander Zubkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=135881521017992@web3o.yandex.ru \
--to=green@msu$(echo .)ru \
--cc=bluca@debian$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=serhe.popovych@gmail$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox