From: Alexander Zubkov <green@msu•ru>
To: Luca Boccassi <bluca@debian•org>,
Stephen Hemminger <stephen@networkplumber•org>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"
Date: Tue, 13 Mar 2018 09:46:44 +0100 [thread overview]
Message-ID: <3677951520930804@web6j.yandex.ru> (raw)
In-Reply-To: <1520890670.31389.1.camel@debian.org>
Hello.
May be the better way would be to change how "all"/"any" argument behaves? My original concern was about "default" only. I agree too, that "all" or "any" should work for all routes. But not for the default.
12.03.2018, 22:37, "Luca Boccassi" <bluca@debian•org>:
> On Mon, 2018-03-12 at 14:03 -0700, Stephen Hemminger wrote:
>> This reverts commit 9135c4d6037ff9f1818507bac0049fc44db8c3d2.
>>
>> Debian maintainer found that basic command:
>> # ip route flush all
>> No longer worked as expected which breaks user scripts and
>> expectations. It no longer flushed all IPv4 routes.
>>
>> Reported-by: Luca Boccassi <bluca@debian•org>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber•org>
>> ---
>> ip/iproute.c | 65 ++++++++++++++++++------------------------------
>> ------------
>> lib/utils.c | 13 ++++++++++++
>> 2 files changed, 32 insertions(+), 46 deletions(-)
>
> Tested-by: Luca Boccassi <bluca@debian•org>
>
> Thanks, solves the problem. I'll backport it to Debian.
>
> Alexander, reproducing the issue is quite simple - before that commit,
> ip route ls all showed all routes, but with the change it started
> showing only the default table. Same for ip route flush.
>
> --
> Kind regards,
> Luca Boccassi
next prev parent reply other threads:[~2018-03-13 8:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 21:03 [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Stephen Hemminger
2018-03-12 21:37 ` Luca Boccassi
2018-03-13 8:46 ` Alexander Zubkov [this message]
2018-03-13 11:05 ` Alexander Zubkov
2018-03-13 12:02 ` Luca Boccassi
2018-03-13 20:12 ` Alexander Zubkov
2018-03-13 20:15 ` Luca Boccassi
2018-03-14 8:59 ` Alexander Zubkov
2018-03-14 20:26 ` Alexander Zubkov
2018-03-18 16:50 ` [PATCH iproute2] treat "default" and "all"/"any" addresses differenty Alexander Zubkov
2018-03-18 17:02 ` Alexander Zubkov
2018-03-27 16:01 ` [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Stephen Hemminger
2018-03-27 16:29 ` Alexander Zubkov
2018-03-27 17:00 ` Stephen Hemminger
2018-03-27 17:33 ` Alexander Zubkov
2018-03-27 17:58 ` Stephen Hemminger
2018-03-27 23:57 ` [PATCH iproute] arrange prefix parsing code after redundant patches Alexander Zubkov
2018-03-29 15:44 ` Stephen Hemminger
2018-03-13 20:19 ` [PATCH iproute2] treat "default" and "all"/"any" parameters differenty Alexander Zubkov
2018-03-13 21:45 ` Luca Boccassi
2018-03-16 20:37 ` Stephen Hemminger
2018-03-16 20:59 ` Alexander Zubkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3677951520930804@web6j.yandex.ru \
--to=green@msu$(echo .)ru \
--cc=bluca@debian$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox