From: Alexander Zubkov <green@msu•ru>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: Serhey Popovych <serhe.popovych@gmail•com>,
Luca Boccassi <bluca@debian•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"
Date: Tue, 27 Mar 2018 19:33:28 +0200 [thread overview]
Message-ID: <998171522172008@web36j.yandex.ru> (raw)
In-Reply-To: <20180327100014.466e3f8b@xeon-e3>
master before merging revert + my recent patch (1) should work. Or you mean to prepare patch to change new master to desired state? I can do it.
1) https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/patch/?id=7696f1097f79be2ce5984a8a16103fd17391cac2
27.03.2018, 19:00, "Stephen Hemminger" <stephen@networkplumber•org>:
> On Tue, 27 Mar 2018 18:29:31 +0200
> Alexander Zubkov <green@msu•ru> wrote:
>
>> Hi Stephen,
>>
>> Looks like the new patch was applied after the revert of original patch and fix patch for 4.15 branch. Which is not correct and I did not test it. This is how patches were designed:
>> 1) your revert patch - rolls back 4.15 branch to old behaviour by reverting the original patch
>> 2) my patch for 4.15 - fixes problem is 4.15 branch, it does not require revert patch, it is an alternative solution for the problem, it is designed solely for version 4.15
>> 3) my patch for master - fixes problem, it requires neither revert patch nor my patch for 4.15, it is standalone patch designed to do things right in master branch
>>
>> 27.03.2018, 18:01, "Stephen Hemminger" <stephen@networkplumber•org>:
>> > On Wed, 14 Mar 2018 21:26:40 +0100
>> > Alexander Zubkov <green@msu•ru> wrote:
>> >
>> >> Hello,
>> >>
>> >> For example, it can be fixed in such way (patch is below):
>> >> - split handling of default and all/any
>> >> - set needed attributes in get_addr: PREFIXLEN_SPECIFIED flag for default
>> >> - and AF_UNSPEC for all/any
>> >> In this case "ip route show default" shows only default route and "ip
>> >> route show all" shows all routes. And both also work when family (-4 or
>> >> -6) is specified.
>> >> Serhey, does it goes in line with what you wanted to achieve? Because I
>> >> do not know - may be there are reasons why all/any should be provided
>> >> with specific family. If you think this solution is suitable, I'll do
>> >> some additional tests and package the patch in a proper way for this
>> >> mailing list.
>> >> And I'm unsure if check for AF_DECnet and AF_MPLS should be kept in both
>> >> branches. May be someone have some additional thoughts on that?
>> >
>> > I applied this to master.
>> >
>> > We can work on the other cases after that.
>
> Please send the update back to what works.
next prev parent reply other threads:[~2018-03-27 17:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 21:03 [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Stephen Hemminger
2018-03-12 21:37 ` Luca Boccassi
2018-03-13 8:46 ` Alexander Zubkov
2018-03-13 11:05 ` Alexander Zubkov
2018-03-13 12:02 ` Luca Boccassi
2018-03-13 20:12 ` Alexander Zubkov
2018-03-13 20:15 ` Luca Boccassi
2018-03-14 8:59 ` Alexander Zubkov
2018-03-14 20:26 ` Alexander Zubkov
2018-03-18 16:50 ` [PATCH iproute2] treat "default" and "all"/"any" addresses differenty Alexander Zubkov
2018-03-18 17:02 ` Alexander Zubkov
2018-03-27 16:01 ` [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Stephen Hemminger
2018-03-27 16:29 ` Alexander Zubkov
2018-03-27 17:00 ` Stephen Hemminger
2018-03-27 17:33 ` Alexander Zubkov [this message]
2018-03-27 17:58 ` Stephen Hemminger
2018-03-27 23:57 ` [PATCH iproute] arrange prefix parsing code after redundant patches Alexander Zubkov
2018-03-29 15:44 ` Stephen Hemminger
2018-03-13 20:19 ` [PATCH iproute2] treat "default" and "all"/"any" parameters differenty Alexander Zubkov
2018-03-13 21:45 ` Luca Boccassi
2018-03-16 20:37 ` Stephen Hemminger
2018-03-16 20:59 ` Alexander Zubkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=998171522172008@web36j.yandex.ru \
--to=green@msu$(echo .)ru \
--cc=bluca@debian$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=serhe.popovych@gmail$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox