From: Michael Ellerman <mpe@ellerman•id.au>
To: Shuah Khan <shuahkh@osg•samsung.com>
Cc: linux-kernel@vger•kernel.org, mmarek@suse•cz,
gregkh@linuxfoundation•org, akpm@linux-foundation•org,
rostedt@goodmis•org, mingo@redhat•com, davem@davemloft•net,
keescook@chromium•org, tranmanphong@gmail•com,
cov@codeaurora•org, dh.herrmann@gmail•com, hughd@google•com,
bobby.prani@gmail•com, serge.hallyn@ubuntu•com,
ebiederm@xmission•com, tim.bird@sonymobile•com,
josh@joshtriplett•org, koct9i@gmail•com,
linux-kbuild@vger•kernel.org, linux-api@vger•kernel.org,
netdev@vger•kernel.org
Subject: Re: [PATCH 2/6] selftests: Add install target
Date: Tue, 20 Jan 2015 14:13:15 +1100 [thread overview]
Message-ID: <1421723595.10632.2.camel@ellerman.id.au> (raw)
In-Reply-To: <54BD326A.6030409@osg.samsung.com>
On Mon, 2015-01-19 at 09:35 -0700, Shuah Khan wrote:
> On 01/18/2015 05:35 PM, Michael Ellerman wrote:
> > On Fri, 2015-01-16 at 10:46 -0700, Shuah Khan wrote:
> >> On 01/09/2015 02:06 AM, Michael Ellerman wrote:
> >>> This adds make install support to selftests. The basic usage is:
> >>>
> >>> $ cd tools/testing/selftests
> >>> $ make install
> >>>
> >>> That installs into tools/testing/selftests/install, which can then be
> >>> copied where ever necessary.
> >>>
> >>> The install destination is also configurable using eg:
> >>>
> >>> $ INSTALL_PATH=/mnt/selftests make install
> >>
> >> Please see my response to [PATCH 4/6] kbuild: add a new
> >> kselftest_install make target to install selftests
> >>
> >> These are addressed by the current approach to use existing
> >> INSTALL_MOD_PATH.
> >
> > No that's a separate issue.
> >
> > This patch adds install support for tools/testing/selftests, *completely
> > separate* from the kbuild infrastructure.
>
> What's the use-case for this feature? I don't see why we need multiple
> ways to do the install?
Exactly the use case I described in the sentence above.
Currently the selftests directory is usable on its own. You can copy the
selftests directory somewhere and it is functional. That is a useful feature,
and there's no reason to break it.
cheers
next prev parent reply other threads:[~2015-01-20 3:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 9:06 [PATCH 1/6] selftests: Introduce minimal shared logic for running tests Michael Ellerman
2015-01-09 9:06 ` [PATCH 2/6] selftests: Add install target Michael Ellerman
2015-01-16 17:46 ` Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
[not found] ` <1421627752.3787.8.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-01-19 16:35 ` Shuah Khan
2015-01-20 3:13 ` Michael Ellerman [this message]
2015-01-09 9:06 ` [PATCH 3/6] selftests: Add install support for the powerpc tests Michael Ellerman
[not found] ` <1420794375-31881-1-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-01-09 9:06 ` [PATCH 4/6] kbuild: add a new kselftest_install make target to install selftests Michael Ellerman
2015-01-16 16:34 ` Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
2015-01-19 16:34 ` Shuah Khan
2015-01-16 17:53 ` [PATCH 1/6] selftests: Introduce minimal shared logic for running tests Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
2015-01-19 16:39 ` Shuah Khan
2015-01-20 3:08 ` Michael Ellerman
2015-01-09 9:06 ` [PATCH 5/6] kbuild: Don't pass -rR to selftest makefiles Michael Ellerman
2015-01-09 9:06 ` [PATCH 6/6] selftests: Set CC using CROSS_COMPILE once in lib.mk Michael Ellerman
2015-01-16 16:37 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421723595.10632.2.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bobby.prani@gmail$(echo .)com \
--cc=cov@codeaurora$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dh.herrmann@gmail$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hughd@google$(echo .)com \
--cc=josh@joshtriplett$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=koct9i@gmail$(echo .)com \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mingo@redhat$(echo .)com \
--cc=mmarek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rostedt@goodmis$(echo .)org \
--cc=serge.hallyn@ubuntu$(echo .)com \
--cc=shuahkh@osg$(echo .)samsung.com \
--cc=tim.bird@sonymobile$(echo .)com \
--cc=tranmanphong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox