From: Shuah Khan <shuahkh@osg•samsung.com>
To: Michael Ellerman <mpe@ellerman•id.au>, linux-kernel@vger•kernel.org
Cc: mmarek@suse•cz, gregkh@linuxfoundation•org,
akpm@linux-foundation•org, rostedt@goodmis•org, mingo@redhat•com,
davem@davemloft•net, keescook@chromium•org,
tranmanphong@gmail•com, cov@codeaurora•org,
dh.herrmann@gmail•com, hughd@google•com, bobby.prani@gmail•com,
serge.hallyn@ubuntu•com, ebiederm@xmission•com,
tim.bird@sonymobile•com, josh@joshtriplett•org, koct9i@gmail•com,
linux-kbuild@vger•kernel.org, linux-api@vger•kernel.org,
netdev@vger•kernel.org
Subject: Re: [PATCH 6/6] selftests: Set CC using CROSS_COMPILE once in lib.mk
Date: Fri, 16 Jan 2015 09:37:04 -0700 [thread overview]
Message-ID: <54B93E30.3060002@osg.samsung.com> (raw)
In-Reply-To: <1420794375-31881-6-git-send-email-mpe@ellerman.id.au>
On 01/09/2015 02:06 AM, Michael Ellerman wrote:
Missing commit log. Please make sure your future include
a meaningful commit log that describes what the patch does.
> Signed-off-by: Michael Ellerman <mpe@ellerman•id.au>
> ---
> tools/testing/selftests/efivarfs/Makefile | 1 -
> tools/testing/selftests/exec/Makefile | 1 -
> tools/testing/selftests/kcmp/Makefile | 1 -
> tools/testing/selftests/lib.mk | 6 ++++++
> tools/testing/selftests/net/Makefile | 1 -
> tools/testing/selftests/powerpc/Makefile | 3 +--
> tools/testing/selftests/size/Makefile | 2 --
> tools/testing/selftests/vm/Makefile | 1 -
> 8 files changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/tools/testing/selftests/efivarfs/Makefile b/tools/testing/selftests/efivarfs/Makefile
> index 3052d0bda24b..d683486a859b 100644
> --- a/tools/testing/selftests/efivarfs/Makefile
> +++ b/tools/testing/selftests/efivarfs/Makefile
> @@ -1,4 +1,3 @@
> -CC = $(CROSS_COMPILE)gcc
> CFLAGS = -Wall
>
> test_objs = open-unlink create-read
> diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
> index 886cabe307b1..4edb7d0da29b 100644
> --- a/tools/testing/selftests/exec/Makefile
> +++ b/tools/testing/selftests/exec/Makefile
> @@ -1,4 +1,3 @@
> -CC = $(CROSS_COMPILE)gcc
> CFLAGS = -Wall
> BINARIES = execveat
> DEPS = execveat.symlink execveat.denatured script subdir
> diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile
> index 0eecd183058c..2ae7450a9a89 100644
> --- a/tools/testing/selftests/kcmp/Makefile
> +++ b/tools/testing/selftests/kcmp/Makefile
> @@ -1,4 +1,3 @@
> -CC := $(CROSS_COMPILE)$(CC)
> CFLAGS += -I../../../../usr/include/
>
> all: kcmp_test
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 7bd3dabe2846..abae16396c43 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -1,3 +1,9 @@
> +# When we're called from kbuild $(CC) already contains $(CROSS_COMPILE), so
> +# here we need to use "cc", otherwise we'll get $(CROSS_COMPILE) twice. The
> +# only downside is it breaks someone overriding $(CC), but that's probably OK,
> +# they can probably cope by changing their path.
I don't want to see the compiles broken and users needing to
work-around. Pleas find a way to not break the compiles.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg•samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-01-16 16:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 9:06 [PATCH 1/6] selftests: Introduce minimal shared logic for running tests Michael Ellerman
2015-01-09 9:06 ` [PATCH 2/6] selftests: Add install target Michael Ellerman
2015-01-16 17:46 ` Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
[not found] ` <1421627752.3787.8.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-01-19 16:35 ` Shuah Khan
2015-01-20 3:13 ` Michael Ellerman
2015-01-09 9:06 ` [PATCH 3/6] selftests: Add install support for the powerpc tests Michael Ellerman
2015-01-09 9:06 ` [PATCH 5/6] kbuild: Don't pass -rR to selftest makefiles Michael Ellerman
2015-01-09 9:06 ` [PATCH 6/6] selftests: Set CC using CROSS_COMPILE once in lib.mk Michael Ellerman
2015-01-16 16:37 ` Shuah Khan [this message]
[not found] ` <1420794375-31881-1-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-01-09 9:06 ` [PATCH 4/6] kbuild: add a new kselftest_install make target to install selftests Michael Ellerman
2015-01-16 16:34 ` Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
2015-01-19 16:34 ` Shuah Khan
2015-01-16 17:53 ` [PATCH 1/6] selftests: Introduce minimal shared logic for running tests Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
2015-01-19 16:39 ` Shuah Khan
2015-01-20 3:08 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B93E30.3060002@osg.samsung.com \
--to=shuahkh@osg$(echo .)samsung.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bobby.prani@gmail$(echo .)com \
--cc=cov@codeaurora$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dh.herrmann@gmail$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hughd@google$(echo .)com \
--cc=josh@joshtriplett$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=koct9i@gmail$(echo .)com \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mingo@redhat$(echo .)com \
--cc=mmarek@suse$(echo .)cz \
--cc=mpe@ellerman$(echo .)id.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rostedt@goodmis$(echo .)org \
--cc=serge.hallyn@ubuntu$(echo .)com \
--cc=tim.bird@sonymobile$(echo .)com \
--cc=tranmanphong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox