From: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public•gmane.org>
To: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public•gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Cc: mmarek-AlSwsSmVLrQ@public•gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public•gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org,
rostedt-nx8X9YLhiw1AfugRpC6u6w@public•gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org,
keescook-F7+t8E8rja9g9hUCZPvPmw@public•gmane.org,
tranmanphong-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org,
cov-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org,
dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org,
hughd-hpIqsD4AKlfQT0dZR+AlfA@public•gmane.org,
bobby.prani-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org,
serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public•gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public•gmane.org,
tim.bird-/MT0OVThwyLZJqsBc5GL+g@public•gmane.org,
josh-iaAMLnmF4UmaiuxdJuQwMA@public•gmane.org,
koct9i-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org,
linux-kbuild-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH 1/6] selftests: Introduce minimal shared logic for running tests
Date: Fri, 16 Jan 2015 10:53:10 -0700 [thread overview]
Message-ID: <54B95006.3080502@osg.samsung.com> (raw)
In-Reply-To: <1420794375-31881-1-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
On 01/09/2015 02:06 AM, Michael Ellerman wrote:
> This adds a Make include file which most selftests can then include to
> get the run_tests logic.
>
> On its own this has the advantage of some reduction in repetition, and
> also means the pass/fail message is defined in fewer places.
>
> However the key advantage is it will allow us to implement install very
> simply in a subsequent patch.
>
> The default implementation just executes each program in $(TEST_PROGS).
>
> We use a variable to hold the default implementation of $(RUN_TESTS)
> because that gives us a clean way to override it if necessary, ie. using
> override. The mount, memory-hotplug and mqueue tests use that to provide
> a different implementation.
>
> Tests are not run via /bin/bash, so if they are scripts they must be
> executable, we add u+x to several.
>
> Signed-off-by: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public•gmane.org>
I like the shared logic approach in general provided it leaves the
flexibility to not use the shared logic if a test have the need to
do so. This series requires some patch planning. shared logic patch
followed by individual test patches as opposed a single patch.
I would like to see the shared logic work done on top of my patch v4
series.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public•gmane.org | (970) 217-8978
next prev parent reply other threads:[~2015-01-16 17:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 9:06 [PATCH 1/6] selftests: Introduce minimal shared logic for running tests Michael Ellerman
2015-01-09 9:06 ` [PATCH 2/6] selftests: Add install target Michael Ellerman
2015-01-16 17:46 ` Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
[not found] ` <1421627752.3787.8.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-01-19 16:35 ` Shuah Khan
2015-01-20 3:13 ` Michael Ellerman
2015-01-09 9:06 ` [PATCH 3/6] selftests: Add install support for the powerpc tests Michael Ellerman
2015-01-09 9:06 ` [PATCH 5/6] kbuild: Don't pass -rR to selftest makefiles Michael Ellerman
2015-01-09 9:06 ` [PATCH 6/6] selftests: Set CC using CROSS_COMPILE once in lib.mk Michael Ellerman
2015-01-16 16:37 ` Shuah Khan
[not found] ` <1420794375-31881-1-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-01-09 9:06 ` [PATCH 4/6] kbuild: add a new kselftest_install make target to install selftests Michael Ellerman
2015-01-16 16:34 ` Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
2015-01-19 16:34 ` Shuah Khan
2015-01-16 17:53 ` Shuah Khan [this message]
2015-01-19 0:35 ` [PATCH 1/6] selftests: Introduce minimal shared logic for running tests Michael Ellerman
2015-01-19 16:39 ` Shuah Khan
2015-01-20 3:08 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B95006.3080502@osg.samsung.com \
--to=shuahkh-jph+aebz4p+uejcrhfaqsw@public$(echo .)gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public$(echo .)gmane.org \
--cc=bobby.prani-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=cov-sgV2jX0FEOL9JmXXK+q4OQ@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public$(echo .)gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public$(echo .)gmane.org \
--cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=josh-iaAMLnmF4UmaiuxdJuQwMA@public$(echo .)gmane.org \
--cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public$(echo .)gmane.org \
--cc=koct9i-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-kbuild-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=mmarek-AlSwsSmVLrQ@public$(echo .)gmane.org \
--cc=mpe-Gsx/Oe8HsFggBc27wqDAHg@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public$(echo .)gmane.org \
--cc=serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=tim.bird-/MT0OVThwyLZJqsBc5GL+g@public$(echo .)gmane.org \
--cc=tranmanphong-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox