* [PATCH net] net:amd-xgbe: ensure to reset the tx_timer_active flag
@ 2022-01-27 6:02 Raju Rangoju
2022-01-27 14:46 ` Tom Lendacky
2022-01-28 3:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Raju Rangoju @ 2022-01-27 6:02 UTC (permalink / raw)
To: thomas.lendacky, davem, kuba
Cc: netdev, Shyam-sundar.S-k, Sudheesh.Mavila, Raju.Rangoju,
Sudheesh Mavila
Ensure to reset the tx_timer_active flag in xgbe_stop(),
otherwise a port restart may result in tx timeout due to
uncleared flag.
Fixes: c635eaacbf77 ("amd-xgbe: Remove Tx coalescing")
Co-developed-by: Sudheesh Mavila <sudheesh.mavila@amd•com>
Signed-off-by: Sudheesh Mavila <sudheesh.mavila@amd•com>
Signed-off-by: Raju Rangoju <Raju.Rangoju@amd•com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
index 492ac383f16d..4949ba69c097 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
@@ -721,7 +721,9 @@ static void xgbe_stop_timers(struct xgbe_prv_data *pdata)
if (!channel->tx_ring)
break;
+ /* Deactivate the Tx timer */
del_timer_sync(&channel->tx_timer);
+ channel->tx_timer_active = 0;
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net:amd-xgbe: ensure to reset the tx_timer_active flag
2022-01-27 6:02 [PATCH net] net:amd-xgbe: ensure to reset the tx_timer_active flag Raju Rangoju
@ 2022-01-27 14:46 ` Tom Lendacky
2022-01-28 3:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Tom Lendacky @ 2022-01-27 14:46 UTC (permalink / raw)
To: Raju Rangoju, davem, kuba; +Cc: netdev, Shyam-sundar.S-k, Sudheesh.Mavila
On 1/27/22 00:02, Raju Rangoju wrote:
> Ensure to reset the tx_timer_active flag in xgbe_stop(),
> otherwise a port restart may result in tx timeout due to
> uncleared flag.
>
> Fixes: c635eaacbf77 ("amd-xgbe: Remove Tx coalescing")
> Co-developed-by: Sudheesh Mavila <sudheesh.mavila@amd•com>
> Signed-off-by: Sudheesh Mavila <sudheesh.mavila@amd•com>
> Signed-off-by: Raju Rangoju <Raju.Rangoju@amd•com>
Acked-by: Tom Lendacky <thomas.lendacky@amd•com>
> ---
> drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> index 492ac383f16d..4949ba69c097 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> @@ -721,7 +721,9 @@ static void xgbe_stop_timers(struct xgbe_prv_data *pdata)
> if (!channel->tx_ring)
> break;
>
> + /* Deactivate the Tx timer */
> del_timer_sync(&channel->tx_timer);
> + channel->tx_timer_active = 0;
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net:amd-xgbe: ensure to reset the tx_timer_active flag
2022-01-27 6:02 [PATCH net] net:amd-xgbe: ensure to reset the tx_timer_active flag Raju Rangoju
2022-01-27 14:46 ` Tom Lendacky
@ 2022-01-28 3:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-01-28 3:20 UTC (permalink / raw)
To: Raju Rangoju
Cc: thomas.lendacky, davem, kuba, netdev, Shyam-sundar.S-k,
Sudheesh.Mavila, sudheesh.mavila
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel•org>:
On Thu, 27 Jan 2022 11:32:22 +0530 you wrote:
> Ensure to reset the tx_timer_active flag in xgbe_stop(),
> otherwise a port restart may result in tx timeout due to
> uncleared flag.
>
> Fixes: c635eaacbf77 ("amd-xgbe: Remove Tx coalescing")
> Co-developed-by: Sudheesh Mavila <sudheesh.mavila@amd•com>
> Signed-off-by: Sudheesh Mavila <sudheesh.mavila@amd•com>
> Signed-off-by: Raju Rangoju <Raju.Rangoju@amd•com>
>
> [...]
Here is the summary with links:
- [net] net:amd-xgbe: ensure to reset the tx_timer_active flag
https://git.kernel.org/netdev/net/c/7674b7b559b6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-28 3:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-27 6:02 [PATCH net] net:amd-xgbe: ensure to reset the tx_timer_active flag Raju Rangoju
2022-01-27 14:46 ` Tom Lendacky
2022-01-28 3:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox