* [PATCH net-next] eth: pse: add missing static inlines
@ 2022-10-04 4:03 Jakub Kicinski
2022-10-04 4:51 ` Oleksij Rempel
2022-10-04 5:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2022-10-04 4:03 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, Jakub Kicinski, kernel test robot,
linux, andrew, bagasdotme
build bot reports missing 'static inline' qualifiers in the header.
Reported-by: kernel test robot <lkp@intel•com>
Fixes: 18ff0bcda6d1 ("ethtool: add interface to interact with Ethernet Power Equipment")
Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
CC: linux@rempel-privat•de
CC: andrew@lunn•ch
CC: bagasdotme@gmail•com
CC: lkp@intel•com
---
include/linux/pse-pd/pse.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/linux/pse-pd/pse.h b/include/linux/pse-pd/pse.h
index fd1a916eeeba..fb724c65c77b 100644
--- a/include/linux/pse-pd/pse.h
+++ b/include/linux/pse-pd/pse.h
@@ -110,16 +110,16 @@ static inline void pse_control_put(struct pse_control *psec)
{
}
-int pse_ethtool_get_status(struct pse_control *psec,
- struct netlink_ext_ack *extack,
- struct pse_control_status *status)
+static inline int pse_ethtool_get_status(struct pse_control *psec,
+ struct netlink_ext_ack *extack,
+ struct pse_control_status *status)
{
return -ENOTSUPP;
}
-int pse_ethtool_set_config(struct pse_control *psec,
- struct netlink_ext_ack *extack,
- const struct pse_control_config *config)
+static inline int pse_ethtool_set_config(struct pse_control *psec,
+ struct netlink_ext_ack *extack,
+ const struct pse_control_config *config)
{
return -ENOTSUPP;
}
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] eth: pse: add missing static inlines
2022-10-04 4:03 [PATCH net-next] eth: pse: add missing static inlines Jakub Kicinski
@ 2022-10-04 4:51 ` Oleksij Rempel
2022-10-04 5:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Oleksij Rempel @ 2022-10-04 4:51 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, kernel test robot, linux, andrew,
bagasdotme
On Mon, Oct 03, 2022 at 09:03:27PM -0700, Jakub Kicinski wrote:
> build bot reports missing 'static inline' qualifiers in the header.
>
> Reported-by: kernel test robot <lkp@intel•com>
> Fixes: 18ff0bcda6d1 ("ethtool: add interface to interact with Ethernet Power Equipment")
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix•de>
Thank you!
> ---
> CC: linux@rempel-privat•de
> CC: andrew@lunn•ch
> CC: bagasdotme@gmail•com
> CC: lkp@intel•com
> ---
> include/linux/pse-pd/pse.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/pse-pd/pse.h b/include/linux/pse-pd/pse.h
> index fd1a916eeeba..fb724c65c77b 100644
> --- a/include/linux/pse-pd/pse.h
> +++ b/include/linux/pse-pd/pse.h
> @@ -110,16 +110,16 @@ static inline void pse_control_put(struct pse_control *psec)
> {
> }
>
> -int pse_ethtool_get_status(struct pse_control *psec,
> - struct netlink_ext_ack *extack,
> - struct pse_control_status *status)
> +static inline int pse_ethtool_get_status(struct pse_control *psec,
> + struct netlink_ext_ack *extack,
> + struct pse_control_status *status)
> {
> return -ENOTSUPP;
> }
>
> -int pse_ethtool_set_config(struct pse_control *psec,
> - struct netlink_ext_ack *extack,
> - const struct pse_control_config *config)
> +static inline int pse_ethtool_set_config(struct pse_control *psec,
> + struct netlink_ext_ack *extack,
> + const struct pse_control_config *config)
> {
> return -ENOTSUPP;
> }
> --
> 2.37.3
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] eth: pse: add missing static inlines
2022-10-04 4:03 [PATCH net-next] eth: pse: add missing static inlines Jakub Kicinski
2022-10-04 4:51 ` Oleksij Rempel
@ 2022-10-04 5:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-04 5:00 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, lkp, linux, andrew, bagasdotme
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel•org>:
On Mon, 3 Oct 2022 21:03:27 -0700 you wrote:
> build bot reports missing 'static inline' qualifiers in the header.
>
> Reported-by: kernel test robot <lkp@intel•com>
> Fixes: 18ff0bcda6d1 ("ethtool: add interface to interact with Ethernet Power Equipment")
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
> ---
> CC: linux@rempel-privat•de
> CC: andrew@lunn•ch
> CC: bagasdotme@gmail•com
> CC: lkp@intel•com
>
> [...]
Here is the summary with links:
- [net-next] eth: pse: add missing static inlines
https://git.kernel.org/netdev/net-next/c/681bf011b9b5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-04 5:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-04 4:03 [PATCH net-next] eth: pse: add missing static inlines Jakub Kicinski
2022-10-04 4:51 ` Oleksij Rempel
2022-10-04 5:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox