From: Ben Hutchings <bhutchings@solarflare•com>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki•fi>
Cc: Jeff Garzik <jgarzik@pobox•com>, Netdev <netdev@vger•kernel.org>,
linux-net-drivers@solarflare•com
Subject: Re: [PATCH 3/9] Removed bogus 'fall-thru' comments
Date: Fri, 9 May 2008 13:12:07 +0100 [thread overview]
Message-ID: <20080509121206.GE13470@solarflare.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0805072328570.23091@wrl-59.cs.helsinki.fi>
Ilpo Järvinen wrote:
> On Wed, 7 May 2008, Ben Hutchings wrote:
>
> > Fall-through is expected outside a switch statement.
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare•com>
> > ---
> > drivers/net/sfc/falcon.c | 2 --
> > drivers/net/sfc/rx.c | 1 -
> > 2 files changed, 0 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/sfc/falcon.c b/drivers/net/sfc/falcon.c
> > index 46db549..9cac344 100644
> > --- a/drivers/net/sfc/falcon.c
> > +++ b/drivers/net/sfc/falcon.c
> > @@ -2468,14 +2468,12 @@ int falcon_probe_nic(struct efx_nic *efx)
> > fail5:
> > falcon_free_buffer(efx, &efx->irq_status);
> > fail4:
> > - /* fall-thru */
> > fail3:
> > if (nic_data->pci_dev2) {
> > pci_dev_put(nic_data->pci_dev2);
> > nic_data->pci_dev2 = NULL;
> > }
> > fail2:
> > - /* fall-thru */
> > fail1:
> > kfree(efx->nic_data);
> > return rc;
>
> Is there really any point in keeping those extra goto targets? I'd suggest
> that you simply eliminate the extra ones completely.
I think we'll do that at some point, along with giving them meaningful
names rather than numbers. But not right now.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
next prev parent reply other threads:[~2008-05-09 12:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 11:41 [PATCH 0/9] sfc: various updates Ben Hutchings
2008-05-07 11:51 ` [PATCH 1/9] Add TSO support Ben Hutchings
2008-05-13 5:17 ` Jeff Garzik
2008-05-07 11:55 ` [PATCH 2/9] Add phy_flash_cfg module parameter and implementation Ben Hutchings
2008-05-07 11:56 ` [PATCH 3/9] Removed bogus 'fall-thru' comments Ben Hutchings
2008-05-07 20:30 ` Ilpo Järvinen
2008-05-09 12:12 ` Ben Hutchings [this message]
2008-05-07 11:57 ` [PATCH 4/9] Remove garbage from comment Ben Hutchings
2008-05-07 11:58 ` [PATCH 5/9] Remove kernel-doc comments for removed members of struct efx_nic Ben Hutchings
2008-05-07 11:58 ` [PATCH 6/9] Fix code formatting Ben Hutchings
2008-05-07 11:59 ` [PATCH 7/9] Remove unused macro EFX_XAUI_RETRAIN_MAX Ben Hutchings
2008-05-07 12:00 ` [PATCH 8/9] Increment rx_reset when reported as driver event Ben Hutchings
2008-05-07 12:36 ` [PATCH 9/9] sfc: Add self-test support Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080509121206.GE13470@solarflare.com \
--to=bhutchings@solarflare$(echo .)com \
--cc=ilpo.jarvinen@helsinki$(echo .)fi \
--cc=jgarzik@pobox$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox