From: Jeff Garzik <jgarzik@pobox•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: netdev@vger•kernel.org, linux-net-drivers@solarflare•com
Subject: Re: [PATCH 1/9] Add TSO support
Date: Tue, 13 May 2008 01:17:46 -0400 [thread overview]
Message-ID: <4829247A.5020407@pobox.com> (raw)
In-Reply-To: <20080507115112.GM2217@solarflare.com>
Ben Hutchings wrote:
> The SFC4000 controller does not have hardware support for TSO, and the
> core GSO code incurs a high cost in allocating and freeing skbs. This
> TSO implementation uses lightweight packet header structures and is
> substantially faster.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare•com>
> ---
> drivers/net/sfc/efx.c | 4 +-
> drivers/net/sfc/ethtool.c | 27 ++
> drivers/net/sfc/net_driver.h | 14 +
> drivers/net/sfc/tx.c | 664 ++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 708 insertions(+), 1 deletions(-)
applied 1-9, with two comments:
1) your subject line is missing a useful prefix. see
http://linux.yyz.us/patch-format.html
2) normally TSO addition would not be permitting during the
bug-fixes-only phase of the kernel development (2.6.26-rc is current),
but since the driver is new, it is reasonable because there can be no
regressions
next prev parent reply other threads:[~2008-05-13 5:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 11:41 [PATCH 0/9] sfc: various updates Ben Hutchings
2008-05-07 11:51 ` [PATCH 1/9] Add TSO support Ben Hutchings
2008-05-13 5:17 ` Jeff Garzik [this message]
2008-05-07 11:55 ` [PATCH 2/9] Add phy_flash_cfg module parameter and implementation Ben Hutchings
2008-05-07 11:56 ` [PATCH 3/9] Removed bogus 'fall-thru' comments Ben Hutchings
2008-05-07 20:30 ` Ilpo Järvinen
2008-05-09 12:12 ` Ben Hutchings
2008-05-07 11:57 ` [PATCH 4/9] Remove garbage from comment Ben Hutchings
2008-05-07 11:58 ` [PATCH 5/9] Remove kernel-doc comments for removed members of struct efx_nic Ben Hutchings
2008-05-07 11:58 ` [PATCH 6/9] Fix code formatting Ben Hutchings
2008-05-07 11:59 ` [PATCH 7/9] Remove unused macro EFX_XAUI_RETRAIN_MAX Ben Hutchings
2008-05-07 12:00 ` [PATCH 8/9] Increment rx_reset when reported as driver event Ben Hutchings
2008-05-07 12:36 ` [PATCH 9/9] sfc: Add self-test support Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4829247A.5020407@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox