From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>
To: Jamie Iles <jamie@jamieiles•com>
Cc: Nicolas Ferre <nicolas.ferre@atmel•com>,
David Miller <davem@davemloft•net>,
Russell King - ARM Linux <linux@arm•linux.org.uk>,
netdev@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
Andrew Victor <linux@maxim•org.za>,
Peter Korsgaard <jacmet@sunsite•dk>
Subject: Re: [PATCHv2 0/9] macb: add support for Cadence GEM
Date: Thu, 24 Mar 2011 17:25:17 +0100 [thread overview]
Message-ID: <20110324162517.GI6466@game.jcrosoft.org> (raw)
In-Reply-To: <20110322175523.GE10058@pulham.picochip.com>
On 17:55 Tue 22 Mar , Jamie Iles wrote:
> Hi Jean-Christophe,
>
> On Tue, Mar 22, 2011 at 04:39:17PM +0000, Jamie Iles wrote:
> > Hi Jean-Christophe,
> >
> > On Tue, Mar 22, 2011 at 05:18:11PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 11:18 Mon 21 Mar , Jamie Iles wrote:
> > > > I have an existing tree for this at
> > > >
> > > > git://github.com/jamieiles/linux-2.6-ji.git macb-gem
> > > >
> > > > based off of 2.6.38 (with your ACK's now added) and I'd be happy with
> > > > either route.
> > > but we must detect the gem via the version register and ditto for macb for
> > > avr32 and at91
> > >
> > > so please rebase it over my patch
> > >
> > > and you get my sob too
> >
> > Would you mind respinning your patch without the changes to the clk
> > stuff? Otherwise we're changing it from compile time to version based,
> > only to completely remove it in subsequent patches.
>
> Actually, this patch doesn't work anyway as the version register is
> being read before the clks are enabled so the device isn't accessible
> (and the registers haven't yet been ioremap()'d).
yeah I found it also I forget to put he RFC in the patch title as I want just to
give the way to detect it the way to detect it for avr32 and at91
so we can remove the ifdef fully
>
> > Also, can you confirm that the module ID's that you are using to
> > differentiate between AT91 and AVR32 won't clash with MACB uses in
> > other, non-at91/avr32 chips, or that it doesn't matter?
>
> If this does work, then it would be nice if we made the else path of the
> RMII AT91 tests also test for avr32 too so we aren't driving the USRIO
> pins on platforms that aren't at91 but also aren't avr32. So something
> the patch below instead.
I'm currently traveling so I can not test it yet will test it next week
but looks good
Best Regards,
J.
next prev parent reply other threads:[~2011-03-24 16:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 10:14 [PATCHv2 0/9] macb: add support for Cadence GEM Jamie Iles
2011-03-15 10:14 ` [PATCHv2 1/9] at91: provide macb clks with "pclk" and "hclk" name Jamie Iles
2011-03-15 12:35 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 12:44 ` Jamie Iles
2011-03-16 6:53 ` avictor.za
2011-03-16 8:38 ` Russell King - ARM Linux
2011-03-17 9:22 ` Andrew Victor
2011-03-17 10:00 ` Russell King - ARM Linux
2011-03-17 10:09 ` Jamie Iles
2011-03-15 10:14 ` [PATCHv2 2/9] macb: remove conditional clk handling Jamie Iles
2011-03-15 10:14 ` [PATCHv2 3/9] macb: unify at91 and avr32 platform data Jamie Iles
2011-03-15 11:14 ` Peter Korsgaard
2011-03-15 11:34 ` Jamie Iles
2011-03-15 12:36 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-17 8:43 ` avictor.za
2011-03-17 8:48 ` Peter Korsgaard
2011-03-17 8:58 ` Russell King - ARM Linux
2011-03-17 9:22 ` Peter Korsgaard
2011-03-17 9:34 ` Jamie Iles
2011-03-17 21:51 ` Jamie Iles
2011-03-18 15:41 ` Russell King - ARM Linux
2011-03-18 15:48 ` Jamie Iles
2011-03-18 15:54 ` Russell King - ARM Linux
2011-03-19 15:49 ` Nicolas Ferre
2011-04-23 5:48 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 10:14 ` [PATCHv2 4/9] macb: convert printk to netdev_ and friends Jamie Iles
2011-03-15 12:36 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 10:14 ` [PATCHv2 5/9] macb: initial support for Cadence GEM Jamie Iles
2011-03-15 10:14 ` [PATCHv2 6/9] macb: support higher rate GEM MDIO clock divisors Jamie Iles
2011-03-15 10:14 ` [PATCHv2 7/9] macb: support statistics for GEM devices Jamie Iles
2011-03-15 10:14 ` [PATCHv2 8/9] macb: support DMA bus widths > 32 bits Jamie Iles
2011-03-15 10:14 ` [PATCHv2 9/9] macb: allow GEM to have configurable receive buffer size Jamie Iles
2011-03-16 20:17 ` [PATCHv2 0/9] macb: add support for Cadence GEM David Miller
2011-03-21 6:38 ` Nicolas Ferre
2011-03-21 11:18 ` Jamie Iles
2011-03-22 16:18 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-22 16:39 ` Jamie Iles
2011-03-22 17:55 ` Jamie Iles
2011-03-24 16:25 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-03-31 9:40 ` Jamie Iles
2011-04-05 10:28 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 10:49 ` Jamie Iles
2011-04-05 11:21 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 11:47 ` Jamie Iles
2011-04-05 11:57 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 11:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324162517.GI6466@game.jcrosoft.org \
--to=plagnioj@jcrosoft$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jacmet@sunsite$(echo .)dk \
--cc=jamie@jamieiles$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linux@maxim$(echo .)org.za \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@atmel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox