From: Peter Korsgaard <jacmet@sunsite•dk>
To: Jamie Iles <jamie@jamieiles•com>
Cc: netdev@vger•kernel.org, plagnioj@jcrosoft•com,
nicolas.ferre@atmel•com, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCHv2 3/9] macb: unify at91 and avr32 platform data
Date: Tue, 15 Mar 2011 12:14:31 +0100 [thread overview]
Message-ID: <87vczkmy94.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1300184096-13937-4-git-send-email-jamie@jamieiles.com> (Jamie Iles's message of "Tue, 15 Mar 2011 10:14:50 +0000")
>>>>> "Jamie" == Jamie Iles <jamie@jamieiles•com> writes:
Hi,
Jamie> Both at91 and avr32 defines its own platform data structure for
Jamie> the macb driver and both share common structures though at91
Jamie> includes a currently unused phy_irq_pin. Create a common
Jamie> eth_platform_data for macb that both at91 and avr32 can use. In
Jamie> future we can use this to support other architectures that use the
Jamie> same IP block with the macb driver.
Nice!
Jamie> Signed-off-by: Jamie Iles <jamie@jamieiles•com>
Jamie> +++ b/include/linux/platform_data/macb.h
Jamie> @@ -0,0 +1,17 @@
Jamie> +/*
Jamie> + * Copyright (C) 2004-2006 Atmel Corporation
Jamie> + *
Jamie> + * This program is free software; you can redistribute it and/or modify
Jamie> + * it under the terms of the GNU General Public License version 2 as
Jamie> + * published by the Free Software Foundation.
Jamie> + */
Jamie> +#ifndef __MACB_PDATA_H__
Jamie> +#define __MACB_PDATA_H__
Jamie> +
Jamie> +struct eth_platform_data {
How about at the same time renaming it to something a bit less generic
like macb_platform_data?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-03-15 11:14 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 10:14 [PATCHv2 0/9] macb: add support for Cadence GEM Jamie Iles
2011-03-15 10:14 ` [PATCHv2 1/9] at91: provide macb clks with "pclk" and "hclk" name Jamie Iles
2011-03-15 12:35 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 12:44 ` Jamie Iles
2011-03-16 6:53 ` avictor.za
2011-03-16 8:38 ` Russell King - ARM Linux
2011-03-17 9:22 ` Andrew Victor
2011-03-17 10:00 ` Russell King - ARM Linux
2011-03-17 10:09 ` Jamie Iles
2011-03-15 10:14 ` [PATCHv2 2/9] macb: remove conditional clk handling Jamie Iles
2011-03-15 10:14 ` [PATCHv2 3/9] macb: unify at91 and avr32 platform data Jamie Iles
2011-03-15 11:14 ` Peter Korsgaard [this message]
2011-03-15 11:34 ` Jamie Iles
2011-03-15 12:36 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-17 8:43 ` avictor.za
2011-03-17 8:48 ` Peter Korsgaard
2011-03-17 8:58 ` Russell King - ARM Linux
2011-03-17 9:22 ` Peter Korsgaard
2011-03-17 9:34 ` Jamie Iles
2011-03-17 21:51 ` Jamie Iles
2011-03-18 15:41 ` Russell King - ARM Linux
2011-03-18 15:48 ` Jamie Iles
2011-03-18 15:54 ` Russell King - ARM Linux
2011-03-19 15:49 ` Nicolas Ferre
2011-04-23 5:48 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 10:14 ` [PATCHv2 4/9] macb: convert printk to netdev_ and friends Jamie Iles
2011-03-15 12:36 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 10:14 ` [PATCHv2 5/9] macb: initial support for Cadence GEM Jamie Iles
2011-03-15 10:14 ` [PATCHv2 6/9] macb: support higher rate GEM MDIO clock divisors Jamie Iles
2011-03-15 10:14 ` [PATCHv2 7/9] macb: support statistics for GEM devices Jamie Iles
2011-03-15 10:14 ` [PATCHv2 8/9] macb: support DMA bus widths > 32 bits Jamie Iles
2011-03-15 10:14 ` [PATCHv2 9/9] macb: allow GEM to have configurable receive buffer size Jamie Iles
2011-03-16 20:17 ` [PATCHv2 0/9] macb: add support for Cadence GEM David Miller
2011-03-21 6:38 ` Nicolas Ferre
2011-03-21 11:18 ` Jamie Iles
2011-03-22 16:18 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-22 16:39 ` Jamie Iles
2011-03-22 17:55 ` Jamie Iles
2011-03-24 16:25 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-31 9:40 ` Jamie Iles
2011-04-05 10:28 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 10:49 ` Jamie Iles
2011-04-05 11:21 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 11:47 ` Jamie Iles
2011-04-05 11:57 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 11:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vczkmy94.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=jamie@jamieiles$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@atmel$(echo .)com \
--cc=plagnioj@jcrosoft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox