From: Jamie Iles <jamie@jamieiles•com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>
Cc: Jamie Iles <jamie@jamieiles•com>,
Russell King - ARM Linux <linux@arm•linux.org.uk>,
netdev@vger•kernel.org, Nicolas Ferre <nicolas.ferre@atmel•com>,
David Miller <davem@davemloft•net>,
Peter Korsgaard <jacmet@sunsite•dk>,
Andrew Victor <linux@maxim•org.za>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCHv2 0/9] macb: add support for Cadence GEM
Date: Tue, 5 Apr 2011 12:47:55 +0100 [thread overview]
Message-ID: <20110405114754.GG4797@pulham.picochip.com> (raw)
In-Reply-To: <20110405112102.GB19268@game.jcrosoft.org>
On Tue, Apr 05, 2011 at 01:21:02PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 11:49 Tue 05 Apr , Jamie Iles wrote:
> > On Tue, Apr 05, 2011 at 12:28:42PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > work fine on 9263ek except the IP version detection.
> > >
> > > the at91 macb ip version is supposed to be at 0x0601010C but it's not.
> > > At least on 9263 it's 0x0001010C. So we can not detect the arch at runtime
> > > but we can detect that it's a macb.
> > >
> > > So could keep the ifdef for 2 archs but use the ip version on arm
> >
> > OK, well I think my patches are already doing that so should be OK as
> > they are.
> >
> > Russell, are you able to take these through your tree (I think they
> > count as consolidation work) or should I ask Stephen for a tree in
> > linux-next for a while first?
> no please do not us the is_gem but the same way as I did in the ip detection
> keep the version register and then check it.
>
> as this ip can be used on other arch we do not want to see thousands
> of is_xxx
But GEM isn't an architecture/machine type, it's a new Cadence Ethernet
controller that follows on from MACB, not some arch specific tweaks so
we really only have two options - MACB or GEM.
Still, if it's important to you then I'll make the change.
Jamie
next prev parent reply other threads:[~2011-04-05 11:47 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 10:14 [PATCHv2 0/9] macb: add support for Cadence GEM Jamie Iles
2011-03-15 10:14 ` [PATCHv2 1/9] at91: provide macb clks with "pclk" and "hclk" name Jamie Iles
2011-03-15 12:35 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 12:44 ` Jamie Iles
2011-03-16 6:53 ` avictor.za
2011-03-16 8:38 ` Russell King - ARM Linux
2011-03-17 9:22 ` Andrew Victor
2011-03-17 10:00 ` Russell King - ARM Linux
2011-03-17 10:09 ` Jamie Iles
2011-03-15 10:14 ` [PATCHv2 2/9] macb: remove conditional clk handling Jamie Iles
2011-03-15 10:14 ` [PATCHv2 3/9] macb: unify at91 and avr32 platform data Jamie Iles
2011-03-15 11:14 ` Peter Korsgaard
2011-03-15 11:34 ` Jamie Iles
2011-03-15 12:36 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-17 8:43 ` avictor.za
2011-03-17 8:48 ` Peter Korsgaard
2011-03-17 8:58 ` Russell King - ARM Linux
2011-03-17 9:22 ` Peter Korsgaard
2011-03-17 9:34 ` Jamie Iles
2011-03-17 21:51 ` Jamie Iles
2011-03-18 15:41 ` Russell King - ARM Linux
2011-03-18 15:48 ` Jamie Iles
2011-03-18 15:54 ` Russell King - ARM Linux
2011-03-19 15:49 ` Nicolas Ferre
2011-04-23 5:48 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 10:14 ` [PATCHv2 4/9] macb: convert printk to netdev_ and friends Jamie Iles
2011-03-15 12:36 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 10:14 ` [PATCHv2 5/9] macb: initial support for Cadence GEM Jamie Iles
2011-03-15 10:14 ` [PATCHv2 6/9] macb: support higher rate GEM MDIO clock divisors Jamie Iles
2011-03-15 10:14 ` [PATCHv2 7/9] macb: support statistics for GEM devices Jamie Iles
2011-03-15 10:14 ` [PATCHv2 8/9] macb: support DMA bus widths > 32 bits Jamie Iles
2011-03-15 10:14 ` [PATCHv2 9/9] macb: allow GEM to have configurable receive buffer size Jamie Iles
2011-03-16 20:17 ` [PATCHv2 0/9] macb: add support for Cadence GEM David Miller
2011-03-21 6:38 ` Nicolas Ferre
2011-03-21 11:18 ` Jamie Iles
2011-03-22 16:18 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-22 16:39 ` Jamie Iles
2011-03-22 17:55 ` Jamie Iles
2011-03-24 16:25 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-31 9:40 ` Jamie Iles
2011-04-05 10:28 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 10:49 ` Jamie Iles
2011-04-05 11:21 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 11:47 ` Jamie Iles [this message]
2011-04-05 11:57 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 11:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405114754.GG4797@pulham.picochip.com \
--to=jamie@jamieiles$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jacmet@sunsite$(echo .)dk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linux@maxim$(echo .)org.za \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@atmel$(echo .)com \
--cc=plagnioj@jcrosoft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox