From: Gustavo Padovan <gustavo-THi1TnShQwVAfugRpC6u6w@public•gmane.org>
To: Chen Gang <gang.chen-bOixZGp5f+dBDgjK7y7TUQ@public•gmane.org>
Cc: Jiri Kosina <jkosina-AlSwsSmVLrQ@public•gmane.org>,
David Herrmann
<dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public•gmane.org>,
Johan Hedberg
<johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
andrei.emeltchenko-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org,
"linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [PATCH v3] Bluetooth: hidp: using strlcpy instead of strncpy, also beautify code.
Date: Mon, 20 May 2013 18:52:24 -0300 [thread overview]
Message-ID: <20130520215224.GE17712@joana> (raw)
In-Reply-To: <51904ACF.6010904-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
Hi Chen,
* Chen Gang <gang.chen-bOixZGp5f+dBDgjK7y7TUQ@public•gmane.org> [2013-05-13 10:07:11 +0800]:
>
> For NUL terminated string, need always let it ended by zero.
>
> Since have already called memcpy() to initialize 'ci', so need not
> redundant initialization.
>
> Better use ''if(session->hid) {} else if(session->input) {}"" instead
> of ''if(session->hid) {}; if(session->input) {};''
>
> Signed-off-by: Chen Gang <gang.chen-bOixZGp5f+dBDgjK7y7TUQ@public•gmane.org>
> ---
> net/bluetooth/hidp/core.c | 14 ++++----------
> 1 files changed, 4 insertions(+), 10 deletions(-)
Sorry for the big delay on this, patches has now been applied to
bluetooth-next. Thanks all.
Gustavo
next prev parent reply other threads:[~2013-05-20 21:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 13:50 [PATCH] Bluetooth: hidp: using strlcpy or strcpy instead of strncpy Chen Gang
2013-05-07 14:08 ` [Suggestion] Bluetooth: hidp: redundant initialization or issue for function hidp_copy_session Chen Gang
[not found] ` <51890AC9.7010501-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-07 19:37 ` David Herrmann
[not found] ` <CANq1E4Q8g6Uy5DMiEf3aEBmfWN=KnVCfqxErYr=ZWD94D4vmAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-08 1:50 ` Chen Gang
2013-05-07 19:31 ` [PATCH] Bluetooth: hidp: using strlcpy or strcpy instead of strncpy David Herrmann
[not found] ` <CANq1E4SmY+CD0uf53_b6GeFkQ-LYnpdxsDGSRMWdn2i1mnb6WQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-08 1:02 ` Chen Gang
[not found] ` <5189A417.503-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-08 3:34 ` [PATCH v2] Bluetooth: hidp: using strlcpy instead of strncpy, also beautify code Chen Gang
[not found] ` <5189C7C6.8090408-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-08 15:16 ` David Herrmann
2013-05-09 1:07 ` Chen Gang
2013-05-09 8:42 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1305091041140.23038-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2013-05-09 8:48 ` Chen Gang
2013-05-13 2:07 ` [PATCH v3] " Chen Gang
2013-05-17 7:04 ` Chen Gang
[not found] ` <51904ACF.6010904-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-20 21:52 ` Gustavo Padovan [this message]
2013-05-21 1:40 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130520215224.GE17712@joana \
--to=gustavo-thi1tnshqwvafugrpc6u6w@public$(echo .)gmane.org \
--cc=andrei.emeltchenko-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=gang.chen-bOixZGp5f+dBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=jkosina-AlSwsSmVLrQ@public$(echo .)gmane.org \
--cc=johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox