From: Chen Gang <gang.chen@asianux•com>
To: Gustavo Padovan <gustavo@padovan•org>,
Jiri Kosina <jkosina@suse•cz>,
David Herrmann <dh.herrmann@gmail•com>,
Marcel Holtmann <marcel@holtmann•org>,
Johan Hedberg <johan.hedberg@gmail•com>,
David Miller <davem@davemloft•net>,
andrei.emeltchenko@intel•com,
"linux-bluetooth@vger•kernel.org"
<linux-bluetooth@vger•kernel.org>,
netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH v3] Bluetooth: hidp: using strlcpy instead of strncpy, also beautify code.
Date: Tue, 21 May 2013 09:40:02 +0800 [thread overview]
Message-ID: <519AD072.1090102@asianux.com> (raw)
In-Reply-To: <20130520215224.GE17712@joana>
On 05/21/2013 05:52 AM, Gustavo Padovan wrote:
> Hi Chen,
>
> * Chen Gang <gang.chen@asianux•com> [2013-05-13 10:07:11 +0800]:
>
>> >
>> > For NUL terminated string, need always let it ended by zero.
>> >
>> > Since have already called memcpy() to initialize 'ci', so need not
>> > redundant initialization.
>> >
>> > Better use ''if(session->hid) {} else if(session->input) {}"" instead
>> > of ''if(session->hid) {}; if(session->input) {};''
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux•com>
>> > ---
>> > net/bluetooth/hidp/core.c | 14 ++++----------
>> > 1 files changed, 4 insertions(+), 10 deletions(-)
> Sorry for the big delay on this, patches has now been applied to
> bluetooth-next. Thanks all.
It doesn't matter, every member have their own work, especially, most of
us are busy.
Thank you for your work, too.
Thanks.
--
Chen Gang
Asianux Corporation
prev parent reply other threads:[~2013-05-21 1:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 13:50 [PATCH] Bluetooth: hidp: using strlcpy or strcpy instead of strncpy Chen Gang
2013-05-07 14:08 ` [Suggestion] Bluetooth: hidp: redundant initialization or issue for function hidp_copy_session Chen Gang
[not found] ` <51890AC9.7010501-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-07 19:37 ` David Herrmann
[not found] ` <CANq1E4Q8g6Uy5DMiEf3aEBmfWN=KnVCfqxErYr=ZWD94D4vmAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-08 1:50 ` Chen Gang
2013-05-07 19:31 ` [PATCH] Bluetooth: hidp: using strlcpy or strcpy instead of strncpy David Herrmann
[not found] ` <CANq1E4SmY+CD0uf53_b6GeFkQ-LYnpdxsDGSRMWdn2i1mnb6WQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-08 1:02 ` Chen Gang
[not found] ` <5189A417.503-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-08 3:34 ` [PATCH v2] Bluetooth: hidp: using strlcpy instead of strncpy, also beautify code Chen Gang
[not found] ` <5189C7C6.8090408-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-08 15:16 ` David Herrmann
2013-05-09 1:07 ` Chen Gang
2013-05-09 8:42 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1305091041140.23038-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2013-05-09 8:48 ` Chen Gang
2013-05-13 2:07 ` [PATCH v3] " Chen Gang
2013-05-17 7:04 ` Chen Gang
[not found] ` <51904ACF.6010904-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-20 21:52 ` Gustavo Padovan
2013-05-21 1:40 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519AD072.1090102@asianux.com \
--to=gang.chen@asianux$(echo .)com \
--cc=andrei.emeltchenko@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dh.herrmann@gmail$(echo .)com \
--cc=gustavo@padovan$(echo .)org \
--cc=jkosina@suse$(echo .)cz \
--cc=johan.hedberg@gmail$(echo .)com \
--cc=linux-bluetooth@vger$(echo .)kernel.org \
--cc=marcel@holtmann$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox