From: Chen Gang <gang.chen-bOixZGp5f+dBDgjK7y7TUQ@public•gmane.org>
To: David Herrmann <dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public•gmane.org>,
Gustavo Padovan <gustavo-THi1TnShQwVAfugRpC6u6w@public•gmane.org>,
Johan Hedberg
<johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
Jiri Kosina <jkosina-AlSwsSmVLrQ@public•gmane.org>,
andrei.emeltchenko-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org,
"linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [PATCH] Bluetooth: hidp: using strlcpy or strcpy instead of strncpy
Date: Wed, 08 May 2013 09:02:15 +0800 [thread overview]
Message-ID: <5189A417.503@asianux.com> (raw)
In-Reply-To: <CANq1E4SmY+CD0uf53_b6GeFkQ-LYnpdxsDGSRMWdn2i1mnb6WQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 2013年05月08日 03:31, David Herrmann wrote:
> On Tue, May 7, 2013 at 3:50 PM, Chen Gang <gang.chen-bOixZGp5f+dBDgjK7y7TUQ@public•gmane.org> wrote:
>> >
>> > For NUL terminated string, need always let it ended by zero.
>> >
>> > Since have already called memcpy() to initialize 'ci', so need not
>> > redundent initializations.
>> >
>> > Signed-off-by: Chen Gang <gang.chen-bOixZGp5f+dBDgjK7y7TUQ@public•gmane.org>
>> > ---
>> > net/bluetooth/hidp/core.c | 10 +++-------
>> > 1 files changed, 3 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
>> > index 940f5ac..9a8ae63 100644
>> > --- a/net/bluetooth/hidp/core.c
>> > +++ b/net/bluetooth/hidp/core.c
>> > @@ -76,25 +76,21 @@ static void hidp_copy_session(struct hidp_session *session, struct hidp_conninfo
>> > ci->flags = session->flags;
>> > ci->state = BT_CONNECTED;
>> >
>> > - ci->vendor = 0x0000;
>> > - ci->product = 0x0000;
>> > - ci->version = 0x0000;
>> > -
>> > if (session->input) {
>> > ci->vendor = session->input->id.vendor;
>> > ci->product = session->input->id.product;
>> > ci->version = session->input->id.version;
>> > if (session->input->name)
>> > - strncpy(ci->name, session->input->name, 128);
>> > + strlcpy(ci->name, session->input->name, 128);
>> > else
>> > - strncpy(ci->name, "HID Boot Device", 128);
>> > + strcpy(ci->name, "HID Boot Device");
> I'd actually prefer strlcpy() here, too (better be safe). Other than
> that the patch looks fine.
OK, thanks. I will send patch v2.
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-05-08 1:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 13:50 [PATCH] Bluetooth: hidp: using strlcpy or strcpy instead of strncpy Chen Gang
2013-05-07 14:08 ` [Suggestion] Bluetooth: hidp: redundant initialization or issue for function hidp_copy_session Chen Gang
[not found] ` <51890AC9.7010501-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-07 19:37 ` David Herrmann
[not found] ` <CANq1E4Q8g6Uy5DMiEf3aEBmfWN=KnVCfqxErYr=ZWD94D4vmAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-08 1:50 ` Chen Gang
2013-05-07 19:31 ` [PATCH] Bluetooth: hidp: using strlcpy or strcpy instead of strncpy David Herrmann
[not found] ` <CANq1E4SmY+CD0uf53_b6GeFkQ-LYnpdxsDGSRMWdn2i1mnb6WQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-08 1:02 ` Chen Gang [this message]
[not found] ` <5189A417.503-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-08 3:34 ` [PATCH v2] Bluetooth: hidp: using strlcpy instead of strncpy, also beautify code Chen Gang
[not found] ` <5189C7C6.8090408-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-08 15:16 ` David Herrmann
2013-05-09 1:07 ` Chen Gang
2013-05-09 8:42 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1305091041140.23038-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2013-05-09 8:48 ` Chen Gang
2013-05-13 2:07 ` [PATCH v3] " Chen Gang
2013-05-17 7:04 ` Chen Gang
[not found] ` <51904ACF.6010904-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-05-20 21:52 ` Gustavo Padovan
2013-05-21 1:40 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5189A417.503@asianux.com \
--to=gang.chen-boixzgp5f+dbdgjk7y7tuq@public$(echo .)gmane.org \
--cc=andrei.emeltchenko-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=gustavo-THi1TnShQwVAfugRpC6u6w@public$(echo .)gmane.org \
--cc=jkosina-AlSwsSmVLrQ@public$(echo .)gmane.org \
--cc=johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox