From: Stephen Hemminger <stephen@networkplumber•org>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>,
David Miller <davem@davemloft•net>
Subject: Re: [Patch iproute2] u32: add terminal parameter
Date: Fri, 11 Apr 2014 17:58:00 -0700 [thread overview]
Message-ID: <20140411175800.08e9ffe3@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <CAM_iQpVpNOJ1xiK45qXGRXgBZ2QcmwoPc7p=SOHCo=1kTwPfFQ@mail.gmail.com>
On Fri, 11 Apr 2014 17:45:53 -0700
Cong Wang <xiyou.wangcong@gmail•com> wrote:
> On Fri, Apr 11, 2014 at 2:04 PM, Stephen Hemminger
> <stephen@networkplumber•org> wrote:
> >
> > Iproute2 commands are supposed to be invertible.
> > If you take something as input, it should be displayed on output.
>
> It's already there:
>
> } else if (sel && sel->flags&TC_U32_TERMINAL) {
> fprintf(f, "terminal flowid ??? ");
> }
But it printing it like an error, not an known good option.
The ??? implies that somebody did something wrong.
next prev parent reply other threads:[~2014-04-12 0:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 17:17 [Patch iproute2] u32: add terminal parameter Cong Wang
2014-04-11 21:04 ` Stephen Hemminger
2014-04-12 0:45 ` Cong Wang
2014-04-12 0:58 ` Stephen Hemminger [this message]
2014-04-12 1:15 ` Cong Wang
2014-04-12 11:43 ` Jamal Hadi Salim
2014-04-14 21:18 ` Cong Wang
2014-04-14 23:14 ` Jamal Hadi Salim
2014-04-15 1:57 ` Cong Wang
2014-04-15 13:00 ` Jamal Hadi Salim
2014-04-15 20:17 ` Cong Wang
2014-04-16 12:19 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411175800.08e9ffe3@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox